These are chat archives for fossasia/open-event-server

17th
Jun 2018
Saurav Tiwary
@srv-twry
Jun 17 2018 05:02

@bhaveshAn Please update your PR: fossasia/open-event-server#4872
I am quoting what I have commented on the PR

HTTP 500 in case of an event creation isn't good. It should be fixed ASAP. If you're busy or unable to fix it, please pass on the responsibility so that it could be resolved ASAP. It can be a blocker for the client projects.

Also please review: fossasia/open-event-server#4858 as it is a blocker for implementing Orders API. @Kreijstal Please review it too although you had approved it before but I lost all the approved reviews after squashing. Hence please review it again. Thanks :smile:

Harsimar
@simarsingh24
Jun 17 2018 06:29
why are discount codes not in relationships
with event
"relationships": {
"custom-forms": {
"links": {
"self": "/v1/events/76/relationships/custom-forms",
"related": "/v1/events/76/custom-forms"
}
},
"event-copyright": {
"links": {
"self": "/v1/events/76/relationships/event-copyright",
"related": "/v1/events/76/event-copyright"
}
},
"feedbacks": {
"links": {
"self": "/v1/events/76/relationships/feedbacks",
"related": "/v1/events/76/feedbacks"
}
},
"microlocations": {
"links": {
"self": "/v1/events/76/relationships/microlocations",
"related": "/v1/events/76/microlocations"
}
},
"tax": {
"links": {
"self": "/v1/events/76/relationships/tax",
"related": "/v1/events/76/tax"
}
},
"faqs": {
"links": {
"self": "/v1/events/76/relationships/faqs",
"related": "/v1/events/76/faqs"
}
},
"event-topic": {
"links": {
"self": "/v1/events/76/relationships/event-topic",
"related": "/v1/events/76/event-topic"
}
},
"speakers": {
"links": {
"self": "/v1/events/76/relationships/speakers",
"related": "/v1/events/76/speakers"
}
},
"social-links": {
"links": {
"self": "/v1/events/76/relationships/social-links",
"related": "/v1/events/76/social-links"
}
},
"sponsors": {
"links": {
"self": "/v1/events/76/relationships/sponsors",
"related": "/v1/events/76/sponsors"
}
},
"speakers-call": {
"links": {
"self": "/v1/events/76/relationships/speakers-call",
"related": "/v1/events/76/speakers-call"
}
},
"event-type": {
"links": {
"self": "/v1/events/76/relationships/event-type",
"related": "/v1/events/76/event-type"
}
},
"session-types": {
"links": {
"self": "/v1/events/76/relationships/session-types",
"related": "/v1/events/76/session-types"
}
},
"tracks": {
"links": {
"self": "/v1/events/76/relationships/tracks",
"related": "/v1/events/76/tracks"
}
},
"faq-types": {
"links": {
"self": "/v1/events/76/relationships/faq-types",
"related": "/v1/events/76/faq-types"
}
},
"tickets": {
"links": {
"self": "/v1/events/76/relationships/tickets",
"related": "/v1/events/76/tickets"
}
},
"ticket-tags": {
"links": {
"self": "/v1/events/76/relationships/ticket-tags",
"related": "/v1/events/76/ticket-tags"
}
}
Saurav Tiwary
@srv-twry
Jun 17 2018 06:34
get_event.png
It is for me :)
Harsimar
@simarsingh24
Jun 17 2018 06:35
what exact url you are making request to?
Saurav Tiwary
@srv-twry
Jun 17 2018 06:35
Are you by any chance using the master branch of the server ?
i am using the dev
Saurav Tiwary
@srv-twry
Jun 17 2018 06:36

what exact url you are making request to?

I am making requests to the localhost since i am running the server locally. so localhost:5000/v1/events/1

Harsimar
@simarsingh24
Jun 17 2018 06:37
Saurav Tiwary
@srv-twry
Jun 17 2018 06:41
Alright, yeah it's not present. It's present in the event details endpoint but not present in the event list.
Harsimar
@simarsingh24
Jun 17 2018 06:42
could you please resolve this issue
Saurav Tiwary
@srv-twry
Jun 17 2018 06:42
Please open an issue the tracker and it will be taken up by someone :)
Harsimar
@simarsingh24
Jun 17 2018 06:43
sure!
Saurav Tiwary
@srv-twry
Jun 17 2018 06:43
wait
Are you the organiser of the event ?
Harsimar
@simarsingh24
Jun 17 2018 06:44
no i am not
and this relation is not present in any of the event
Saurav Tiwary
@srv-twry
Jun 17 2018 06:45
Still create an issue, I'll look into it. Most probably it's not an issue but will check.
Harsimar
@simarsingh24
Jun 17 2018 06:46
okay thanks
Kreijstal
@Kreijstal
Jun 17 2018 08:54
what is event-copyright?
Guys I have opened a PR for adding the link to the dev handbook in the README so that devs are aware that something like this exists and hence we can avoid basic questions. Please review: fossasia/open-event-server#4924
Kreijstal
@Kreijstal
Jun 17 2018 09:46
@srv-twry can an event exist without a copyright
I'm getting this error:
Ember Data Request GET http://127.0.0.1:5000/v1/events/3/event-copyright returned a 404↵Payload (Empty Content-Type)
Saurav Tiwary
@srv-twry
Jun 17 2018 09:47
Yes, definitely. Infact we first create an event without the copyright.
Then we make a POST request to the copyright endpoint with a relationship field with event.
Kreijstal
@Kreijstal
Jun 17 2018 09:47
ah I see
Saurav Tiwary
@srv-twry
Jun 17 2018 09:47
404 is not an error. It's just that it doesn't exist
Kreijstal
@Kreijstal
Jun 17 2018 09:49
In this case it is, on the frontend I can only see these 2 buttons
image.png
image.png
when I click on either of them I get that error
and when I see the browser console it is the only error that shows up
Saurav Tiwary
@srv-twry
Jun 17 2018 09:49
There must be a different error.
On the first step of the wizard you only have two buttons.
Screenshot of the console please :)
Kreijstal
@Kreijstal
Jun 17 2018 09:51
Also "Assertion Failed: You cannot add a record of modelClass 'undefined' to the 'event.tax' relationship (only 'tax' allowed)"
It's probably that one
Saurav Tiwary
@srv-twry
Jun 17 2018 09:52

Also "Assertion Failed: You cannot add a record of modelClass 'undefined' to the 'event.tax' relationship (only 'tax' allowed)"

It means the tax isn't defined yet, which is totally fine in my opinion. Please add the screenshot of the console.

Kreijstal
@Kreijstal
Jun 17 2018 09:56
image.png
Saurav Tiwary
@srv-twry
Jun 17 2018 09:58
able to reproduce, create an issue in the Frontend. It's probably because of the tax issue.

Also "Assertion Failed: You cannot add a record of modelClass 'undefined' to the 'event.tax' relationship (only 'tax' allowed)"

I meant this one.

Saurav Tiwary
@srv-twry
Jun 17 2018 11:10
@niranjan94 currently any registered user is allowed to view the list of discount codes under an event using /v1/events/{event_identifier}/discount-codes
Is it the required behaviour ? I think it's a bug since only the event organiser and the admin should be able to see discount code list and details IMO.
Bhavesh Anand
@bhaveshAn
Jun 17 2018 11:27

@bhaveshAn Please update your PR: fossasia/open-event-server#4872
I am quoting what I have commented on the PR
HTTP 500 in case of an event creation isn't good. It should be fixed ASAP. If you're busy or unable to fix it, please pass on the responsibility so that it could be resolved ASAP. It can be a blocker for the client projects.

fossasia/open-event-server#4925

fossasia/open-event-server#4921 Approved by 2 admins @srv-twry can you review and merge
Saurav Tiwary
@srv-twry
Jun 17 2018 11:30
image.png
For some reason, unable to merge :worried:
Saurabh Chaturvedi
@schedutron
Jun 17 2018 11:31
Weird :worried:
This message was deleted
I guess
One more admin approval is required
Bhavesh Anand
@bhaveshAn
Jun 17 2018 11:33
merged :smile:
Saurav Tiwary
@srv-twry
Jun 17 2018 11:33
Yeah kreijstal did. I don't know why I wasn't able to merge it. I was the third persion with write access to approve it.
Kreijstal
@Kreijstal
Jun 17 2018 12:15
weird
did you refresh
Saurav Tiwary
@srv-twry
Jun 17 2018 12:17
Yes, I did. I mean it's showing that I've write access, but wasn't allowing me to merge it. May be Microsoft doing wonders ? :laughing:
Bhavesh Anand
@bhaveshAn
Jun 17 2018 12:49
its there for me too in merging fossasia/open-event-server#4924
@srv-twry @Kreijstal @maxlorenz Please review fossasia/open-event-server#4872
Saurav Tiwary
@srv-twry
Jun 17 2018 12:53

@mariobehling Has there been any change in the write permissions for me and @bhaveshAn ? We both aren't able to merge PRs even though the PR has two or more than two approved reviews from reviewers with write access.
You can check the below image:

image.png

@srv-twry @Kreijstal @maxlorenz Please review fossasia/open-event-server#4872

@bhaveshAn Already done :smile:

Bhavesh Anand
@bhaveshAn
Jun 17 2018 12:54
:+1:
Saurav Tiwary
@srv-twry
Jun 17 2018 13:10
@bhaveshAn @Kreijstal @mayank8318 @schedutron @iamareebjamal Please review: fossasia/open-event-server#4858
It has almost been reviewed and approved by everyone of you in the past but due to other PRs getting merged(the latest one being: fossasia/open-event-server#4918), I am having to update the migrations file to the new head. Then I squash the commits and the approved reviews go away. Can we please get this merged as a priority ? It is a blocker for the Orders endpoint. Thanks :smile:
Bhavesh Anand
@bhaveshAn
Jun 17 2018 13:19
:+1:
Bhavesh Anand
@bhaveshAn
Jun 17 2018 13:25
@niranjan94 @SaptakS @iamareebjamal Please share your thoughts on issue fossasia/open-event-server#4919
Bhavesh Anand
@bhaveshAn
Jun 17 2018 21:52
@srv-twry @schedutron @Kreijstal @maxlorenz fossasia/open-event-server#4803 Is a blocker for work of other things as it resolves event role permissions issue in admin dashboard so needs to be reviewed asap. Please review. I have added screenshots of each and every API and API blueprint at https://test31038.docs.apiary.io/ Thanks!