These are chat archives for fossasia/open-event-server

26th
Jun 2018
Saurav Tiwary
@srv-twry
Jun 26 2018 15:08

@Masquerade0097 Regarding this: fossasia/open-event-server#4899, You can access the list of attendees under an order if

  1. You're the event organizer or
  2. You're the user who gave placed that order.

Can you please make sure again that you satisfy this criteria ?

Priyanshu Khandelwal
@Masquerade0097
Jun 26 2018 15:18
@srv-twry Yes, I was the event organizer as well as placed the order. You can verify this too by using the Orga App developer account.
Bhavesh Anand
@bhaveshAn
Jun 26 2018 15:44
@niranjan94 https://open-event-api-dev.herokuapp.com requires to manually run populate_db.py after there is updation in this file ?
Please check fossasia/open-event-server#4969
Saurav Tiwary
@srv-twry
Jun 26 2018 16:40

@mayank8318 @bhaveshAn @schedutron please review: fossasia/open-event-server#4958, fossasia/open-event-server#4963

Even after asking in the chat, I only have one review on fossasia/open-event-server#4958 by @Kreijstal . Any issues guys with this ? Too long ?? @bhaveshAn @mayank8318 @schedutron

Saurav Tiwary
@srv-twry
Jun 26 2018 16:57

@srv-twry Yes, I was the event organizer as well as placed the order. You can verify this too by using the Orga App developer account.

It's very strange. I am not able to reproduce it locally but able to reproduce it on the dev server on heroku. :confused:

@Masquerade0097 Can you please test it locally with postman if you're getting the same error locally or not. If not, then we can be sure that it is some bug with heroku not getting updated after PR gets merged.

Priyanshu Khandelwal
@Masquerade0097
Jun 26 2018 16:58
@srv-twry Okay, I'll check it.
Bhavesh Anand
@bhaveshAn
Jun 26 2018 17:10
@srv-twry Why I would have issue with that. Was just busy in fixing some other issue.
Also, asking review in chat doesn't prioritizes to get it reviewed, quickly. If that was the case then everyone would have asked reviews in chat only other then asking in PRs. So, problem of time has nothing to do with you and your PRs. Hence Reviewing :)
Saurav Tiwary
@srv-twry
Jun 26 2018 17:27

@bhaveshAn

Also, asking review in chat doesn't prioritizes to get it reviewed, quickly.

I never said this. As far as i remember we were asked to be persistent in our request for reviews and hence I requested it here.
Moreover I was just trying to make sure my PR was not too long since a few of my past PRs have been :)

Bhavesh Anand
@bhaveshAn
Jun 26 2018 17:28
Cool
Saurav Tiwary
@srv-twry
Jun 26 2018 17:52
@schedutron Adding to what I have said here: https://github.com/fossasia/open-event-server/pull/4911#discussion_r198027021 about having many to many relationship with tickets. Let's consider an example:
Let's say you're the event organizer and you only have one ticket in the event. You want to provide special discount of 10% to your friends and 5% to your relatives. How will you provide it if you don't allow tickets to have multiple associated discount codes ? Makes sense ?
Saurabh Chaturvedi
@schedutron
Jun 26 2018 17:59
But the tickets will be different for friends and relatives, right?
The tickets of friends will have a 10% discount code, and the tickets for relatives will have a 5% discount code.
A single ticket will not have both 10% and 5% discount codes.
Saurav Tiwary
@srv-twry
Jun 26 2018 18:03
Why different tickets for friends and relatives ?
One ticket priced at 10$ for general public.
9$ for friends and 9.5$ for relatives.
Saurabh Chaturvedi
@schedutron
Jun 26 2018 18:03
If we allow arbitrary number of discount codes to be applied on a single ticket, people may exploit it for themselves.
Saurav Tiwary
@srv-twry
Jun 26 2018 18:03
How ?
Saurabh Chaturvedi
@schedutron
Jun 26 2018 18:04
What if one gets access to both the discount codes - of the relatives and friends?
Saurav Tiwary
@srv-twry
Jun 26 2018 18:04
How will they get access to them ? They are only shown to the event organizer and the admin.
The event organizer provides them the discount code personally.
Saurabh Chaturvedi
@schedutron
Jun 26 2018 18:05
S/he will apply that on their own ticket to get a net price of <$9.

How will they get access to them ? They are only shown to the event organizer and the admin.

What if one of your relatives is friends with one of your friends? :)

The codes can be shared by people, right?
Saurav Tiwary
@srv-twry
Jun 26 2018 18:08
Then it's the event organizer's concern right ?

The codes can be shared by people, right?

Yes.

Saurabh Chaturvedi
@schedutron
Jun 26 2018 18:08
Actually, yes it's the organizer's concern.
But usually what you see with other services is that tickets don't support application of multiple discount codes.
Should we provide a choice to the organizer, whether to enable the use of multiple discount codes on tickets or not?
Saurav Tiwary
@srv-twry
Jun 26 2018 18:12
In the legacy server, we have many to many relationship between ticket and discount code.

Should we provide a choice to the organizer, whether to enable the use of multiple discount codes on tickets or not?

Probably later, not now.

Mario Behling
@mariobehling
Jun 26 2018 18:14

@srv-twry

In the legacy server, we have many to many relationship between ticket and discount code.

Yes, please follow legacy and also eventbrite. Of course you can have many different discount codes per ticket.

Pradeep Gangwar
@pradeepgangwar
Jun 26 2018 18:15
But during checkout, i think we should allow applying only one discount code. He/She can choose one which has higher discount value (This is what is followed at many places).
Saurav Tiwary
@srv-twry
Jun 26 2018 18:16
Absolutely, that's what we have in the legacy version also.
Saurav Tiwary
@srv-twry
Jun 26 2018 18:23

S/he will apply that on their own ticket to get a net price of <$9.

@schedutron Sorry I missed it. We are not allowing more than one discount code to be applied in an order. Hopefully this clears your confusion.

Saurabh Chaturvedi
@schedutron
Jun 26 2018 18:24
@srv-twry Yes it did :)
Saurabh Chaturvedi
@schedutron
Jun 26 2018 20:55
Do we need an endpoint to list the discount codes applied on a given ticket?
Saurav Tiwary
@srv-twry
Jun 26 2018 20:56
Not an immediate requirement I guess.
Saurabh Chaturvedi
@schedutron
Jun 26 2018 20:56
Like /tickets/<int:ticket_id>/discount_codes?
Saurav Tiwary
@srv-twry
Jun 26 2018 20:58
But since you're adding the relationship, you can easily add it maybe for future use.
Saurabh Chaturvedi
@schedutron
Jun 26 2018 20:58
:+1: