These are chat archives for fossasia/open-event-server

7th
Aug 2018
Priyanshu Khandelwal
@Masquerade0097
Aug 07 2018 16:44
@srv-twry Can we add the API to create onsite-attendees using the pre existing tickets for an event rather then creating onsite-tickets ?
Saurav Tiwary
@srv-twry
Aug 07 2018 16:46
I don't understand it properly. We are creating it for pre-existing tickets only.
The server expects the list of ticket id and ticket quantity in the payload to create an onsite order.
Priyanshu Khandelwal
@Masquerade0097
Aug 07 2018 16:47
I saw the docs, there it is stated that the type of ticket is 'on-site-ticket'
rather than just 'ticket'
Are you using this endpoint ?
Priyanshu Khandelwal
@Masquerade0097
Aug 07 2018 16:49
Yes,
on-site-tickets": [
        {
          "data": {
            "attributes": {
              "id": "1",
              "quantity": "2"
            },
            "type": "on-site-ticket"
          }
        },
Here, the type is stated 'on-site-ticket'. Can you please explain what this type signifies ?
Saurav Tiwary
@srv-twry
Aug 07 2018 16:53
Create a model named OnSiteTicket with two fields, the id and the quantity. The id should be equal to the id of the ticket and quantity should be equal to the quantity of the ticket bought.
for eg. If you want to buy 3 ticket of id=5 and 2 tickets of ticket id =4, then you should send a list of OnSiteTicket model with two entries, one with id=5 and quantity=3 and second entry with id=4 and quantity=2
Priyanshu Khandelwal
@Masquerade0097
Aug 07 2018 16:56
Okay, it's clear now.
Saurav Tiwary
@srv-twry
Aug 07 2018 16:57
:+1:
Saurav Tiwary
@srv-twry
Aug 07 2018 17:06
@bhaveshAn I understand that we are reaching the end of GSoC period but please don't ignore all the best practices completely. I had to add it here because you have been doing absolutely anything you want lately:
  1. Merging your own PRs without any reviews within hours(Why don't you just commit directly to the dev branch?): fossasia/open-event-server#5306, fossasia/open-event-server#5290
  2. Working on issues created by others without even asking for permissions from them: fossasia/open-event-server#5286
  3. Working on issues which were already assigned to someone else: fossasia/open-event-server#5211
Bhavesh Anand
@bhaveshAn
Aug 07 2018 17:14

Merging your own PRs without any reviews within hours: fossasia/open-event-server#5306, fossasia/open-event-server#5290
Working on issues which were already assigned to someone else: fossasia/open-event-server#5211

Apologies for those.

Working on issues created by others without even asking for permissions from them: fossasia/open-event-server#5286

Issue Opener's statement in issue doesn't showed that he wanna work on that. I usually writes that "Wanna work on this issue" in each and every issue if I want to take it : https://github.com/fossasia/open-event-server/issues/created_by/bhaveshAn

Saurav Tiwary
@srv-twry
Aug 07 2018 17:17

Issue Opener's statement in issue doesn't showed that he wanna work on that.

yes, i know that you add it but here is what the guidelines suggest.

If you would like to work on an issue, drop in a comment at the issue. If it is already assigned to someone, but there is no sign of any work being done, please free to drop in a comment so that the issue can be assigned to you if the previous assignee has dropped it entirely.

Focus on the first line. You should always drop a comment at the issue.

Bhavesh Anand
@bhaveshAn
Aug 07 2018 17:26
fair point but particularly to this issue, I self assigned it 22 hrs ago. Atleast that time Issue Opener should had a discussion on this mis understanding. I would have assigned him on that.
Saurav Tiwary
@srv-twry
Aug 07 2018 17:28
hmm, alright. No problem. Please keep it in mind :)
Bhavesh Anand
@bhaveshAn
Aug 07 2018 17:44
Also LMK if there is any problem with code at fossasia/open-event-server#5306, fossasia/open-event-server#5290 If its there then just revert it NP
Vaibhav Shrivastava
@mishuvs
Aug 07 2018 17:48

I self assigned it 22 hrs ago. Atleast that time Issue Opener should had a discussion

I think notifications are not issued for issue assignments unless a user themselves is assigned that's why guidelines suggest commenting, doesn't send email updates as well. https://developer.github.com/v3/activity/notifications/

Bhavesh Anand
@bhaveshAn
Aug 07 2018 17:57
Look no ones fault is there. You haven't wrote that you wanna work thats why I took it. Took that just because the project dev (Server dev) has a duty to solve the issues of Server(which he can solve) if no one have showed interest to work on it.
Vaibhav Shrivastava
@mishuvs
Aug 07 2018 18:15
No problem. But, gone through so many previous issues, it isn't mentioned usually that someone wants to work on their own issues, unless they have rights and self assign themselves. Also, additional context is not for writing that.
Interest would be visible if one reads the last comment to which no confirmation was received on the issue barely a day old. Anyway, no problem!
Bhavesh Anand
@bhaveshAn
Aug 07 2018 18:20

Interest would be visible if one reads the last comment to which no confirmation was received on the issue barely a day old.

Here is the last comment.

I think an online event is the same as an offline event except they don't have a location, for which we'll have to allow publishing without location. It's a small change I think, can we add it?

can we add it? If We here means I then you are right. You have showed interest :)

Saurav Tiwary
@srv-twry
Aug 07 2018 18:57

@bhaveshAn

Also LMK if there is any problem with code at fossasia/open-event-server#5306, fossasia/open-event-server#5290 If its there then just revert it NP

Went through them. Looks good. :+1:

Bhavesh Anand
@bhaveshAn
Aug 07 2018 19:00
Cool!
Bhavesh Anand
@bhaveshAn
Aug 07 2018 19:25

@srv-twry @mayank8318 Can you please check and ensure is mails statistics works fine or not ?

@srv-twry @mayank8318 LMK on this