I feel a bit stupid...
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L395
looks ok but
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L423
wat... any ideas?
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L395
-rw-r--r-- 1 root root 114231378 Oct 19 18:47 PSLab-Desktop Setup 2.2.7.exelooks ok but
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L423
dist/*.exe does not exist.wat... any ideas?
Anyway, the first release is now here: https://github.com/fossasia/pslab-desktop/releases/tag/v2.3.0 :tada:
If anyone can figure out why the .exe cannot be found (that actually exists...?), please let me know.
Aaah... Yea, that could do the trick. :) I am just confused that the other files could be found and upload. Well well... But here is another thing: The Windows build is running in Docker. It might be that it is not mounted in a way such that the files are propagated to outside again. I think that is the actual issue. I'll try another few things.
Another issue: The current release doesn't work. It looks like the Node <-> Python linkage fails due to path lookup problems. It's a bit messy because electron-builder moves files to different places. I have a work in progress branch to get asar (Electron app compression) back in place and there I had to adjust paths as well.
Thank you also a lot for the feedback on my PR Alex, I will get back to it. Now I need some rest again. :)
I dont get the difference between tag and release in Github.
Tags are what Git defines. Releases are a general concept, meaning a specific snapshot. GitHub offers an API to define releases. They can be based on git tags, and they can be decoupled and arbitrary. The API allows for attaching files, which can, but do not have to be related to the repository. When creating a release based on a tag, they will display download options for both snapshots of the source files and the attachments.
In other words: tags are part of the repository, so they reappear wherever a repo is cloned, and releases are a platform feature.
With the setup I am working on, the releases are created through the CI build configuration. That's why Travis needs to have a token for write access to GitHub.
ok, we are following a bit different style in other repos it seems e.g. https://github.com/fossasia/open-event-frontend/tags
so, before we jump to v2 maybe have a smaller number increase. v2 sounds like a major stable release and we are far away from a stable app.
I am a bit worried about expectations of people when they see we are already at "v2".
Keep in mind that the old PyQt4 app will not even be able to run on a current platform. Qt6 has just been released as first candidates, and Qt4 is EOL since a few years ago.
I ported the app to Qt5 two years ago when we spoke at C3, but couldn't really manage to upstream it back then.
Can you elaborate on your concerns?
I thought the release of Aakash is v1.
I was just thinking that we did not really have an official Electron app/Python release v2.
We never considered the version 2 usable and now we are advancing already to version 2.x.
I agree, we should have a better management. Actually nobody paid real attention to it. We should align with @CloudyPadmal as well.
Well, it needs to be thought-through, but this is what we are doing in Open Event -> open event frontend 1.18.0 works with open event backend 1.18.0.
The Python app was released at 1.0.0, see https://github.com/fossasia/pslab-desktop/releases/tag/v1.0.0
I created fossasia/pslab-desktop#638 to cover the matter.
I understand I have to wait for PSlab for Windows or IOS. In the meantime I can start with Python and I can buy a moderate Android tablet. In order to select which one to buy I want tot know if there are any minimal requirements or recommandatins with respect to screen size/resolution and USB connection. Is it possible or needed to use USB 2 , USB 3 or USB C with/without OTG. The current HW has an MCP 2200 UART so I expect that USB 2.0 will do and that an OTG connection may cause problems. But I am not sure.
Please feel free to join
i found this library for possibly implementing sd card functionality: http://elm-chan.org/fsw/ff/00index_e.html and a tutorial here: https://www.studentcompanion.co.za/interfacing-sd-card-with-pic-microcontroller-xc8/
i found this library for possibly implementing sd card functionality: http://elm-chan.org/fsw/ff/00index_e.html and a tutorial here: https://www.studentcompanion.co.za/interfacing-sd-card-with-pic-microcontroller-xc8/
Thank you @nielek2 .. I'm using this chan library generated from "Microchip Code Configurator" and it works as a separate function. Now need to integrate it with the current work flow.
Waveform table size does not seem to correlate with max amplitude:
@CloudyPadmal
Thank you @bessman ,, I'll try a simulation and hope it would narrow it down the bottleneck..
So, I made some changes in pslab-hardware repo (my fork) where I added a special branch to hold diff images comparing the new changes with the previous board. https://github.com/CloudyPadmal/pslab-hardware/tree/diff-img
@mariobehling , should I integrate that in to the main repo?
