On most of my windows computers I use "Python 3.7.0 with Idle" Reason for this version is needed for the chemical/physical math packages I need for solving destilation equations. So bundling specific Pslab-desktop python libs seems good as long as you can keep using a a Python version of let's say >=3.6, or am i missing something ?
If it produces a deb file, could you test it out? (I am having high hopes for today :D)
What target would the deb file have? Debian or Ubuntu? They are generally not compatible.
I hope it'll be somehow... electron-builder isn't that elaborate on that. They call their target "deb" and speak of Debian. They have a "snap" target as well. It's a mess. The core issue will be in what the main binary is linked against. We'll see, I guess... Sadly, testing that requires lots of effort and the binaries grow huge.
https://www.electron.build/configuration/linux#debian-package-options - interesting, I can add
pslab-python (should probably be python-pslab for distros, a convention we use in Arch for example). :)
Since Debian still lives in the past were python2 is
python :smirk:
https://travis-ci.org/github/fossasia/pslab-desktop/builds/735742554 looks like it's building for the tag now... if that works as I imagine, we will have a downloadable deb and exe. Woop woop! \o/
Yea in Arch it's vice versa lol - python2-pslab for Python 2, otherwise it is Python 3. :D
The only thing I'm unsure about is that there are two separate build tasks for Windows and Linux, but one section to specify the files to attach to the release.
Looks like there's more work ahead: https://travis-ci.org/github/fossasia/pslab-desktop/jobs/735750018#L345
travis-ci/travis-ci#9441 suggests that I need to create a new key. @mariobehling the GitHub access token should ideally be owned by the org, how are you handling then usually?
If you are available on Thursday eve we could have a Jitsi call to go through whatever is needed.
https://docs.python.org/3/library/venv.html says that it's adding a Python binary as well. Then we can bundle the full thing for Windows, just need to do some plumbing to get the paths right. :-) The downside is that the app may grow to something around half a gigabyte installed or something like that. I will look into asar bundling to shrink it (archive format from Electron).
I don't think it bundles libpython-stdlib though. That might be a problem.
I'm not sure that venvs are portable.
Doesn't look like they are: https://stackoverflow.com/questions/35035274/completely-self-contained-virtual-environment
I feel a bit stupid...
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L395
looks ok but
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L423
wat... any ideas?
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L395
-rw-r--r-- 1 root root 114231378 Oct 19 18:47 PSLab-Desktop Setup 2.2.7.exelooks ok but
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L423
dist/*.exe does not exist.wat... any ideas?
Anyway, the first release is now here: https://github.com/fossasia/pslab-desktop/releases/tag/v2.3.0 :tada:
If anyone can figure out why the .exe cannot be found (that actually exists...?), please let me know.
Aaah... Yea, that could do the trick. :) I am just confused that the other files could be found and upload. Well well... But here is another thing: The Windows build is running in Docker. It might be that it is not mounted in a way such that the files are propagated to outside again. I think that is the actual issue. I'll try another few things.
Another issue: The current release doesn't work. It looks like the Node <-> Python linkage fails due to path lookup problems. It's a bit messy because electron-builder moves files to different places. I have a work in progress branch to get asar (Electron app compression) back in place and there I had to adjust paths as well.
Thank you also a lot for the feedback on my PR Alex, I will get back to it. Now I need some rest again. :)
I dont get the difference between tag and release in Github.
Tags are what Git defines. Releases are a general concept, meaning a specific snapshot. GitHub offers an API to define releases. They can be based on git tags, and they can be decoupled and arbitrary. The API allows for attaching files, which can, but do not have to be related to the repository. When creating a release based on a tag, they will display download options for both snapshots of the source files and the attachments.