Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 05:46
    KushMehta1511 opened #2170
  • 05:46
    KushMehta1511 opened #2170
  • 05:31
    KushMehta1511 commented #2169
  • 05:31
    KushMehta1511 commented #2169
  • Jan 17 20:35
    bessman synchronize #666
  • Jan 17 20:32

    bessman on development

    Fix #658 - Oscillosope not disa… (compare)

  • Jan 17 20:32
    bessman closed #660
  • Jan 17 20:32
    bessman closed #658
  • Jan 17 16:54
    bessman edited #666
  • Jan 17 16:53
    bessman opened #666
  • Jan 17 16:21
    bessman commented #127
  • Jan 17 16:13
    bessman synchronize #158
  • Jan 17 16:07
    bessman edited #158
  • Jan 17 16:07
    bessman opened #158
  • Jan 17 12:34
    asaikarthikeya edited #2167
  • Jan 17 12:34
    asaikarthikeya edited #2167
  • Jan 17 05:12
    KushMehta1511 edited #2169
  • Jan 17 05:12
    KushMehta1511 edited #2169
  • Jan 17 05:11
    KushMehta1511 opened #2169
  • Jan 17 05:11
    KushMehta1511 opened #2169
Daniel Maslowski
@orangecms
I feel a bit stupid...
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L395
-rw-r--r-- 1 root root 114231378 Oct 19 18:47 PSLab-Desktop Setup 2.2.7.exe
looks ok but
https://travis-ci.com/github/fossasia/pslab-desktop/jobs/402147772#L423
dist/*.exe does not exist.
wat... any ideas?
Daniel Maslowski
@orangecms
Anyway, the first release is now here: https://github.com/fossasia/pslab-desktop/releases/tag/v2.3.0 :tada:
If anyone can figure out why the .exe cannot be found (that actually exists...?), please let me know.
Alexander Bessman
@bessman
Try file_glob: true.
Daniel Maslowski
@orangecms
Aaah... Yea, that could do the trick. :) I am just confused that the other files could be found and upload. Well well... But here is another thing: The Windows build is running in Docker. It might be that it is not mounted in a way such that the files are propagated to outside again. I think that is the actual issue. I'll try another few things.
Another issue: The current release doesn't work. It looks like the Node <-> Python linkage fails due to path lookup problems. It's a bit messy because electron-builder moves files to different places. I have a work in progress branch to get asar (Electron app compression) back in place and there I had to adjust paths as well.
Thank you also a lot for the feedback on my PR Alex, I will get back to it. Now I need some rest again. :)
Daniel Maslowski
@orangecms
I just deleted the release again due to the app not working anyway. Unfortunately I couldn't download the files beforehand to check whether it works.
Mario Behling
@mariobehling
@orangecms What release numbering should we follow? I see there are tags showing v.2.
I dont get the difference between tag and release in Github.
Daniel Maslowski
@orangecms
Tags are what Git defines. Releases are a general concept, meaning a specific snapshot. GitHub offers an API to define releases. They can be based on git tags, and they can be decoupled and arbitrary. The API allows for attaching files, which can, but do not have to be related to the repository. When creating a release based on a tag, they will display download options for both snapshots of the source files and the attachments.
In other words: tags are part of the repository, so they reappear wherever a repo is cloned, and releases are a platform feature.
With the setup I am working on, the releases are created through the CI build configuration. That's why Travis needs to have a token for write access to GitHub.
Mario Behling
@mariobehling
ok, we are following a bit different style in other repos it seems e.g. https://github.com/fossasia/open-event-frontend/tags
so, before we jump to v2 maybe have a smaller number increase. v2 sounds like a major stable release and we are far away from a stable app.
I am a bit worried about expectations of people when they see we are already at "v2".
Daniel Maslowski
@orangecms
It is a full rewrite, hence the reasoning. From my perspective, seeing that the app is quite mature, to keep moving forward, we need to reestablish a release process. Otherwise, people who do not want/like/manage to build from source won't receive it
Keep in mind that the old PyQt4 app will not even be able to run on a current platform. Qt6 has just been released as first candidates, and Qt4 is EOL since a few years ago.
I ported the app to Qt5 two years ago when we spoke at C3, but couldn't really manage to upstream it back then.
Daniel Maslowski
@orangecms
It's still at https://github.com/orangecms/pslab-desktop/tree/PyQt5
Can you elaborate on your concerns?
Mario Behling
@mariobehling
Sorry, I think I am confusing things. I did not realize that you call this old release v1.
I thought the release of Aakash is v1.
I was just thinking that we did not really have an official Electron app/Python release v2.
We never considered the version 2 usable and now we are advancing already to version 2.x.
I agree, we should have a better management. Actually nobody paid real attention to it. We should align with @CloudyPadmal as well.
Mario Behling
@mariobehling
An idea would also be to align version numbers with the Python component. This way people could more easily know which releases work well together.
Well, it needs to be thought-through, but this is what we are doing in Open Event -> open event frontend 1.18.0 works with open event backend 1.18.0.
Daniel Maslowski
@orangecms
The Python app was released at 1.0.0, see https://github.com/fossasia/pslab-desktop/releases/tag/v1.0.0
Norbert Preining
@norbusan
Yeah!
Daniel Maslowski
@orangecms
Regarding dependencies: I proposed to pin specific versions of the Python lib in the desktop app. Both are now under further development, but the desktop app is mainly behind in terms of features and the Python lib being stabilized.
I created fossasia/pslab-desktop#638 to cover the matter.
Mario Behling
@mariobehling
Thank you!
François Cartegnie
@fcartegnie
so finally that desktop bloat can be used ?
Daniel Maslowski
@orangecms
Oh that has been possible for months already, just yay -S pslab-desktop on Arch :)
Ir Jelle van der Linde
@Jelle007
I understand I have to wait for PSlab for Windows or IOS. In the meantime I can start with Python and I can buy a moderate Android tablet. In order to select which one to buy I want tot know if there are any minimal requirements or recommandatins with respect to screen size/resolution and USB connection. Is it possible or needed to use USB 2 , USB 3 or USB C with/without OTG. The current HW has an MCP 2200 UART so I expect that USB 2.0 will do and that an OTG connection may cause problems. But I am not sure.
Mario Behling
@mariobehling
@Jelle007 we have our weekly meeting now
Please feel free to join
https://meet.jit.si/fossasia-hw
nielek2
@nielek2
i found this library for possibly implementing sd card functionality: http://elm-chan.org/fsw/ff/00index_e.html and a tutorial here: https://www.studentcompanion.co.za/interfacing-sd-card-with-pic-microcontroller-xc8/
Ir Jelle van der Linde
@Jelle007
Thx I'll try to join next time
Alexander Bessman
@bessman
Waveform table size does not seem to correlate with max amplitude:

@CloudyPadmal
Padmal
@CloudyPadmal

i found this library for possibly implementing sd card functionality: http://elm-chan.org/fsw/ff/00index_e.html and a tutorial here: https://www.studentcompanion.co.za/interfacing-sd-card-with-pic-microcontroller-xc8/

Thank you @nielek2 .. I'm using this chan library generated from "Microchip Code Configurator" and it works as a separate function. Now need to integrate it with the current work flow.

Waveform table size does not seem to correlate with max amplitude:

@CloudyPadmal

Thank you @bessman ,, I'll try a simulation and hope it would narrow it down the bottleneck..

Padmal
@CloudyPadmal
So, I made some changes in pslab-hardware repo (my fork) where I added a special branch to hold diff images comparing the new changes with the previous board. https://github.com/CloudyPadmal/pslab-hardware/tree/diff-img
@mariobehling , should I integrate that in to the main repo?
Abhijay Jain
@Abhijay007
I made some changes in PSLab where I set-upped Storybook UI environment and Updated Electron to version 10. Now Codacy/PR Quality Reviewer show that some test case is not passed but I don't understand what is the reason.
@mariobehling,@orangecms sir review my PR here : fossasia/pslab-desktop#642
when you get time.
Daniel Maslowski
@orangecms
Really nice, thank you! Let's discuss further details on GitHub :)
Ir Jelle van der Linde
@Jelle007
I am still reading all documentation /source files etc..It is overwhelming and a lot of work In the mean time I build a nice case ...... Still do not know basic requirement for an Android tablet (> Android > 6 also Android 10?, Screen resolution ?) . I started a RS 232 terminal session (COM3,9800 Baud, 1 stopbit, no parity) with the board conected. I understand the firmware lissten to commands-subcommands-parameter. (three documented in an old protocol.ods document) . The command get_version (chr(11) Chr(5) or 0x0B 0x05) shoult give a response , but I only get 00 00 00 after issuing a CR/LF after the command. So that's bothering me. Broken board ? Beginners mistake ? This weekend I am not able to participate in de 5'o clock meeting. Happy to do that later on when I am more familiar with PSLAB . In the meantime any suggestions are welcome.