fossasia/susi_android

https://play.google.com/store/apps/details?id=ai.susi https://github.com/fossasia/susi_android

Amartya Mondal

@atm1504

@akshatnitd @mariobehling please have a look at the above screen cast. Is that okk?

Akshat Garg

@akshatnitd

I checked the above screencast. Only the first message should have been showed at t=0

Rest of the messages should be shown after the delay present in the payload.

Amartya Mondal

@atm1504

Okk, I will implement that

Amartya Mondal

@atm1504

I think there would be a problem, if I try to show the 2nd 3rd message after the timer sets out

Now the scheduler even works, if the app runs in the background. But, if we try to show the messages, in such a case or when another page is open in the app, then at such a case the app might get crashed

Amartya Mondal

@atm1504

@iamareebjamal can you please review fossasia/susi_android#2342 and say if the method that I implemented is going on correct or not.

Amartya Mondal

@atm1504

@akshatnitd currently we don't have any skills to reply for static plan actions like plan a joke at one minute. So shall I add some skills to implement plan actions for such queries in the app?

Mario Behling

@mariobehling

@atm1504 Yes, please. First create a skill for alarms, please.

Amartya Mondal

@atm1504

Yah sure, I will do it

Amartya Mondal

@atm1504

I have added the skill https://susi.ai/Utilities/Static%20Plan%20Actions/en

Currently the skill is for telling the joke only for testing purpose in the client side. But I will extend the list as I go.

Sample queries are plan a joke at * | set alarm for a joke at ** |plan something funny * | plan a joke | set alarm for a joke

Amartya Mondal

@atm1504

@mariobehling the plan action to play music is working perfectly. Its even working when the app is in the background or when we are using some other features in the app

Now I am working for the answering of plan queries. Also displaying if messages accordingly to planned actions

Amartya Mondal

@atm1504

@iamareebjamal please review the pr fossasia/susi_android#2342. I have finalized that.

@mariobehling I have implemented the planned actions. You can have a look here: https://photos.app.goo.gl/TiNCGXmjpdGr3Mey7 .
Also, I have added an apk in the PR, so you can test it. In video delay is of 5second, that was for testing purpose only

Akshat Garg

@akshatnitd

@atm1504

"actions": [
      {
        "language": "en",
        "type": "answer",
        "expression": "alarm set in one minute to play music"
      },
      {
        "type": "answer",
        "expression": "Playing Metallica - Nothing Else Matters [Official Music Video]",
        "plan_delay": 60000,
        "plan_date": "2019-08-09T14:44:22.879Z"
      },
      {
        "type": "video_play",
        "identifier_type": "youtube",
        "identifier": "tAGnKpE4NCI",
        "plan_delay": 60000,
        "plan_date": "2019-08-09T14:44:22.879Z"
      },
      {
        "expression": "starting a planned music alarm Playing Metallica - Nothing Else Matters [Official Music Video]",
        "language": "en",
        "type": "answer",
        "plan_delay": 60000,
        "plan_date": "2019-08-09T14:44:22.879Z"
      }
    ],

When you type, Set alarm in one minute. After that, only alarm set in one minute to play music should be displayed instantly. Rest of the messages should be displayed after the plan_delay as mentioned in the response.

Amartya Mondal

@atm1504

Okk. I will do that

Amartya Mondal

@atm1504

@akshatnitd please have a look at it now.

Alok Kumar

@alok760

@atm1504 from where do i download the latest APK

The APKs from the APK branch are not working for me

Amartya Mondal

@atm1504

For this feature, I will update the apk in the comment section.

The apks with name should be the apk of the development branch susiai-dev-playStore-debug.apk

Alok Kumar

@alok760

@atm1504 thanks, but i just want to test the app and not this feature particularly.
I just want to see if the smart speaker setup procedure is working or not

Amartya Mondal

@atm1504

Cool : )

Akshat Garg

@akshatnitd

@akshatnitd please have a look at it now.

@atm1504 The functionality in the GIF, looks great :)

Not sure, about the implementation

Amartya Mondal

@atm1504

The app is even working properly when it is in background. I will add the test apk, so that you all can test it out

Amartya Mondal

@atm1504

@Orbiter I hope that the response for the query set alarm in one minute has changed a lot. Now, we don’t receive the video url in response

Amartya Mondal

@atm1504

@alok760 please tell a detail about the feature add wifi. Also, what would be the probable step to implement it.

Michael Christen

@Orbiter

@Orbiter I hope that the response for the query set alarm in one minute has changed a lot. Now, we don’t receive the video url in response

you hope that it changed a lot? So what do you expect?

Amartya Mondal

@atm1504

Actually, the response that we had till yesterday was different from the one that I received today morning. The app was framed to work in the way we received responses earlier.

But no problem, I will re frame it. And it will work properly now

Areeb Jamal

@iamareebjamal

So, you hope that it hasn't changed a lot?

Amartya Mondal

@atm1504

earlier responses were of the form 0th index states alarm set in one minute and after that the task. Now we have another option. Also some new skills have been added, which needs to be handled properly in the app side. We had a discussion regarding this in the meeting. Similar changes will be made both in the smart speaker and in the android client.

Amartya Mondal

@atm1504

@akshatnitd @mariobehling @iamareebjamal the planned actions has been implemented successfully. Few bugs and cases are present that needs to be handled. I will fix them soon and finalize the PR.

Amartya Mondal

@atm1504

Stop action has been implemented

Also, a beep sound comes when command like set alarm in one minute sounds up at0 the time of action, to show that alarm has executed

Ali Hasan

@Zyro9922

@atm1504 Please provide more description about fossasia/susi_android#2364.

Amartya Mondal

@atm1504

Yyah sure. I will udate the comment with all necessary informations and images. You can use them

Ali Hasan

@Zyro9922

@atm1504 I have updated the Readme accordingly

Amartya Mondal

@atm1504

@Zyro9922 there are few more changes that needs to be updated. It was discussed yesterday in the meeting. I will give you all the details, please do that accordingly.

Ali Hasan

@Zyro9922

Okay 👍🏻

Ali Hasan

@Zyro9922

I'll close this PR and wait for details.

Areeb Jamal

@iamareebjamal

Then we'll close the new PR and wait for changes in the old PR

https://blog.fossasia.org/open-source-developer-guide-and-best-practices-at-fossasia/

Harshit Khandelwal

@liveHarshit

https://blog.fossasia.org/open-source-developer-guide-and-best-practices-at-fossasia/

@Zyro9922 Please follow the guidelines.

Where communities thrive

People

Repo info

Activity