fossasia/susi_hardware

@stealthanthrax @norbusan
In order to implement planned actions correctly, a list of all actions from the server response needs to be sent to the busy state, so that actions which are planned for later execution can be sent to the scheduler and actions which doesn't have any plan_delay or plan_date are executed instantly.

For example:
skill to set alarm in one minute has the following two actions -

• First

    {
        "language": "en",
        "type": "answer",
        "expression": "alarm set for in one minute"
      },

• Second

      {
        "expression": "ALARM",
        "language": "en",
        "type": "answer",
        "plan_delay": 60004,
        "plan_date": "2019-08-12T23:45:39.729Z"
      }

here the first action needs to be executed immediately and the second action needs to be sent to the scheduler.

but currently what susi_python does is, it takes the list of actions, parse each action into an object, then go through the objects' attributes and create a result dictionary.
the result dictionary just contains the keys which are to be executed and doesn't have distinguished actions.

So I have a few questions

• why dont we send the list of action directly to the busy state ?
• what are the advantages of making objects and creating a result dictionary?

I see two ways of implementing planned actions now-

• Use the current infrastructure of susi_python and add the plan_delay and plan_date attributes to all the different action type objects and return a list of these objects
• Just return the list of actions as it is sent by the susi_server

what do you suggest ?
Thank you