checking
it does work @Orbiter
let me just give the versions of java and gradle that I am using
Gradle 6.0.1
root@sid:/home/susi_server# java --version
openjdk 11.0.5 2019-10-15
OpenJDK Runtime Environment (build 11.0.5+10-post-Ubuntu-0ubuntu1.118.04)
OpenJDK 64-Bit Server VM (build 11.0.5+10-post-Ubuntu-0ubuntu1.118.04, mixed mode, sharing)
Great! Now users will have access to delete their skills after merging fossasia/susi.ai#3462 in the webclient
@Orbiter there has been an issue in storing user's bots as drafts fossasia/susi_server#1457. It kept giving server error
object parser error: Unterminated string at 313 [character 314 line 1]
FOSSASIA Confirms Summit from March 19-21 + #DevSprints on March 22 at Lifelong Learning Institute #Singapore after meetings about measures ensuring health and safety https://twitter.com/fossasiasg/status/1229692817867325440
Hello everyone I am Aman Singh Rajput 3rd Year Electrical engineering from IIT BHU VARANASI . I want to get started for GSOC 2020 So i want to contribute to your organisation. I have experience in Core JAVA and Software Development in JAVA. So anyone please help me to get started .
FOSSASIA isn't participating in GsoC 2020, feel free to go through ReadMe and best practices if you still want to contribute.
@/all Dear friends, despite challenges we are happy to work with the community to share live streams from the FOSSASIA Summit "social distancing event" and include remote speakers and participation. An overview of streams is here: https://www.youtube.com/fossasiaorg
The complete schedule of the event is here: https://summit.fossasia.org/event/schedule.html
The complete schedule of the event is here: https://summit.fossasia.org/event/schedule.html
java.lang.AssertionError: does not exist: /home/ashwani/Documents/github/susi_server_https/data/generic_skills/media_discovery
at ai.susi.mind.SusiMind$Layer.<init>(SusiMind.java:83)
at ai.susi.DAO.init(DAO.java:381)
at ai.susi.mind.SusiTutorialTest.test(SusiTutorialTest.java:86)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
Am I missing something?
I see some issues on github,should i start with that?
is there anyone here help to have a kickbot for nukers?
@iamareebjamal There was a discussion about you recent merged PR. There are a lot of files changed. And, it is unclear if all changes are relevant to the issue. With so many file changes, the reviews will take more time. So, I dont know. Maybe the PR needs to be reverted and go back into a review stage? @norbusan @Orbiter What are the next steps?
The changes are relevant to reduce duplication and reduce a security issue to a single function and mitigate that. If reverted, the code will be vulnerable again, and the number of file changes were necessary because the same vulnerable chunk of code was copied in every file. For instance, there were 120 references of the security issue solved in the PR, work on which is going on since 10th March(since 2 months ago)
@iamareebjamal First of all thanks for your work on that issue!!! Nobody doubts the usefulness and importance of the changes, but think in maintainance terms - if something is broken now, we can hardly find the reason for it in a specific commit (that is no git bisect etc) due to lumping too many things together. git commits are best when they have a clear target, and only the necessary changes. Reformatting without function changes can be put into a separate commit.
Hi, I can't recall where I reformatted the files without function changes, and I have already put in unit tests to prove that not only my changes don't break the current system, but even that they are working correctly with previous behavior as there were no unit tests before which tested the skill loading and metadata, so in a way, we could conclude that there was no way previously to know if the system works without manually checking it, but now we do as now I have written tests for DAOFileAccess, SkillQueryParser, SkillQuery and every class I have added. If someone can show me the changes where I have just changed the formatting without functional changes and have not added tests for the function, I would be happy to oblige and either add tests for the same or revert it. I follow the rule of no reformatting without necessary changes quite strictly myself and have made as minimal as possible changes to ensure that the vulnerability is removed and system remains testable. The only changes I made which weren't related to the vulnerability were which broke the system on testing, for example, in SusiUtterance, the server crashed with error 500 when parsing a skill with just a "?" with IndexOutofBoundException because it didn't test for string being empty before accessing the first character, I fixed that and also added a test to ensure it parses such files correctly, so I am confident that more bugs are even fixed in the commits and tests have been added to prove that. However, I have split the changes into multiple atomic commits so it remains easy to git bisect and find where the bug is and if there are some changes someone feels unrelated to the PR or entirely cosmetic, I will be more than happy to add tests to prove they don't break and maybe even fix the system, or revert them :)
Thanks
Thanks
This design requires software AEC/DOA unfortunately which might load RPi CPU significantly in particular if you want DOA with neural networks. On one side it is more flexible, on other side given you run speech recognition will have problems with compute.
When we play with vosk(https://github.com/alphacep/vosk-api) on RPi it loads RPi3 almost 90%, so offloading AEC and DOA is a big gain. So Respeaker core 2 design with XMOS is somewhat more preferable.
Right now I started doing some stuff on with reference to Automating the boring stuff with python and motivated to contribute in open source. So please help me to understand and let me know how to start from scratch because I am a beginner never contributed before this. with the provided instruction I will move forward to set up my environment.
Right now I started doing some stuff on with reference to Automating the boring stuff with python and motivated to contribute in open source. So please help me to understand and let me know how to start from scratch because I am a beginner never contributed before this. with the provided instruction I will move forward to set up my environment.
Clone code from github and implement something like fossasia/susi_server#969