These are chat archives for foundersandcoders/street-flowers

30th
Jun 2015
Natalia Baltazar
@NataliaLKB
Jun 30 2015 08:05 UTC
Have the scrum without me!! I need to pick something up today. Will be back later. Deployments still unsuccessful :(.
*later meaning 1/2 an hour
benjamin Lees
@benjaminlees
Jun 30 2015 11:21 UTC
@Neats29 im heading in, forgot subhan was coming to fac
Anita
@Neats29
Jun 30 2015 12:13 UTC
hows it going?
Natalia Baltazar
@NataliaLKB
Jun 30 2015 12:32 UTC
Business meeting just ended :)
Anita
@Neats29
Jun 30 2015 12:33 UTC
oh ok, been working on the pin but for some reason it wont show up not sure what I’m doing wrong
Anita
@Neats29
Jun 30 2015 12:42 UTC
let me know if you guys want to skype before we skype them, probably be a good idea
let me know if you guys want to skype before we skype them, probably be a good ide
Natalia Baltazar
@NataliaLKB
Jun 30 2015 12:55 UTC
Benji just arrived so in 10 min?
Anita
@Neats29
Jun 30 2015 13:06 UTC
cool
Anita
@Neats29
Jun 30 2015 13:57 UTC
so I dont need to deploy then do i?
Natalia Baltazar
@NataliaLKB
Jun 30 2015 13:59 UTC
Nope!
Woohoo!
Anita
@Neats29
Jun 30 2015 14:22 UTC
:)
Natalia Baltazar
@NataliaLKB
Jun 30 2015 14:23 UTC
Are you going to keep working on the pins?
Anita
@Neats29
Jun 30 2015 14:24 UTC
im gonna push it up as I dont think theres any point spending more time on it before I get this bit to work first so I will push up to a branch
Natalia Baltazar
@NataliaLKB
Jun 30 2015 14:26 UTC
Okay cool :)
Anita
@Neats29
Jun 30 2015 14:33 UTC
ok pushed
Natalia Baltazar
@NataliaLKB
Jun 30 2015 14:40 UTC
Hey What are you expecting the pins to look like right now?
I have pulled down your branch, and I see a red square
Natalia Baltazar
@NataliaLKB
Jun 30 2015 14:59 UTC
@Neats29 This wasn't done : tableflip/streetflowers#19
Shall I take it on?
Anita
@Neats29
Jun 30 2015 15:01 UTC
U can see the red square??
That's what I couldn't see
Natalia Baltazar
@NataliaLKB
Jun 30 2015 15:01 UTC
Yep. Are you npm sass:watching ?
Anita
@Neats29
Jun 30 2015 15:01 UTC
That's odd, did u have to change anything
Natalia Baltazar
@NataliaLKB
Jun 30 2015 15:01 UTC
There was an error in the sass when I just pulled down
I fixed the error (it was a missing } on line 42 of _form.scss)
Anita
@Neats29
Jun 30 2015 15:02 UTC
I did npm run sass
Natalia Baltazar
@NataliaLKB
Jun 30 2015 15:02 UTC
But that error should throw if you did npm run sass
That particular error will also be fixed when you merge with master (as I remember that error from a while ago)
Anita
@Neats29
Jun 30 2015 15:05 UTC
Oh ok yeah I didn't merge with master
I thought the error was about the name for the search input text
Btw #19 is done I just forgot to close it
Natalia Baltazar
@NataliaLKB
Jun 30 2015 15:06 UTC
Don't have a pr with master, but definitely merge with master so you are up to date. Right now this branch is missing a lot of changes
Not founders and coders # 19, but tableflip/streetflowers#19
Anita
@Neats29
Jun 30 2015 15:07 UTC
Oh think the minify bit missing
Natalia Baltazar
@NataliaLKB
Jun 30 2015 15:07 UTC
And I just reopened it
on github we have no js in the src dir so nothing compiles to public.
There shouldn't be any (or almost any) js in the public dir in github
I am happy to do these tasks if you want :)
Natalia Baltazar
@NataliaLKB
Jun 30 2015 15:18 UTC
So do let me know if:
  • you can see the red square now
  • you want me to work on tableflip/streetflowers#19 or you would rather finish it
Anita
@Neats29
Jun 30 2015 15:21 UTC
Just come out to get some food so happy for you to do it if you need it but if you rather do something else then I'm happy to finish it. Sorry realised its not complete.
Natalia Baltazar
@NataliaLKB
Jun 30 2015 15:29 UTC
No problem! Can you see the red square now?
Anita
@Neats29
Jun 30 2015 15:30 UTC
Just come out to get some food so happy for you to do it if you need it but if you rather do something else then I'm happy to finish it. Sorry just realised its not complete.
Anita
@Neats29
Jun 30 2015 21:30 UTC
I’m going to a job screening test tomorrow morning but should be in by 12 or 1
only found out about it today
sorry ive been so busy this week
Natalia Baltazar
@NataliaLKB
Jun 30 2015 21:46 UTC
No worries! We have been busy too. Good luck with the test!!
Anita
@Neats29
Jun 30 2015 21:47 UTC
oh i think its just html and css, just going to get a feel of whats out there
Anita
@Neats29
Jun 30 2015 21:55 UTC
do we have git hooks? its not letting me merge with master coz the tests are failing, but they would pass once I merge...
pre-commit hooks