FW/1 - Framework One - is a lightweight, convention over configuration, MVC application framework for ColdFusion / CFML.
[jtreher, cfml] Instead of getBeanFactory()
[jtreher, cfml] And calling applicationStop()
[jtreher, cfml] and, all of our addBean stuff now only happens on the main DI instance unlike when it used to happen for all of them in 3.0
[jtreher, cfml] Previously, each subsystem instance would have had the loadListener firing (something we maybe were taking advantage of?)
[Sean Corfield, cfml] That sounds related to subsystems still being initialized on demand when the first request for an action within it comes in.
[jtreher, cfml] I think so. And every request is in a subsystem now, right?
[Sean Corfield, cfml] No.
[jtreher, cfml] Dang
[Sean Corfield, cfml] You’re using “legacy subsystems” still?
[jtreher, cfml] Yes.
[jtreher, cfml] That only applies to the "new" then, eh?
[Sean Corfield, cfml] The issue is just that subsystem initialization is on demand and thus could fall foul of thread safety issues if heavy load hits an uninitialized subsystem. The plan was to add an “eager initialization” option to the new subsystems stuff to get around that.
[clockworkrebel, cfml] The method doesn't seem to be called for me, but it's entirely possible I've just got something set up wrong.
[clockworkrebel, cfml] So I'm wondering if those methods are expected to be called (and therefore I should keep looking at what I screwed up) or if those methods wouldn't be called even if all my stuff was functioning at 100%
[Sean Corfield, cfml] The default (if you omit it) is for FW/1 to let DI/1 manage both controllers and the model, but if you override that it and don't tell it to manage the controllers...
[Sean Corfield, cfml] Also, which version of FW/1 are you using?
[clockworkrebel, cfml] Thank you for pointing me in the right direction on that
[clockworkrebel, cfml] Well, turns out I did not have
diLocations set, but for the time being I got it to work by explicitly setting diLocations. Perhaps it's because the controller classes in question are in a subsystem? I had to add the controller directory for the subsystem before it worked (which makes sense).
[clockworkrebel, cfml] Yep
[clockworkrebel, cfml] It seems that there's something strange going on with the bean factory in each subsystem. Or maybe it's that it's somehow using the parent bean factory
[clockworkrebel, cfml] I'm new to this framework and so my understanding of how this is supposed to work is probably not quite right
[Sean Corfield, cfml] @jtreher I was looking over the handful of open issues in the FW/1 GitHub repo and noticed this which sounds a lot like your issue framework-one/fw1#423
[Ross, cfml] what’s the approved method of accessing the subsystem bean within my other one?
[Ross, cfml] (the answer can be ’do what you’re doing in a service, if need be)
[Ross, cfml] the scenario is that I have a client bean where I’m calculating an ‘age class’, e.g. ‘18-25’, based on the client’s DOB
[Ross, cfml] the list of age classes are a list in my lookups table, so lookup bean
[Ross, cfml] (lookups is a subsystem)
[jtreher, cfml] I'm just reporting back that we have not been able to resolve our issues with reloading the application under load. We are currently reverting everything and are going to try to upgrade just DI/1 to see how it fares there to help isolate the issue. It totally seems related to the legacy subsystems.
[Ross, cfml] @aliaspooryorik no
[Ross, cfml] at least, that’s not an option in this instance
[Ross, cfml] If I dip down to the application yes, but id rather not do that obviously
[Carl Von Stetten, cfml] Can you pass
fw as a property into the "client" bean?
[Carl Von Stetten, cfml] Admittedly, this would feel really dirty, so the service approach would probably be better.
[Carl Von Stetten, cfml] I've done this in some controllers where I need to grab a bean from another subsystem.
[Sean Corfield, cfml] @jtreher One thing you might try is preloading the subsystems in
setupApplication(): for ( s in ["list", "of", "subsystems"] ) setupSubsystem( s ); That should solve the lazy-loading under load issue (you may need an application scope lock around that tho').
[Sean Corfield, cfml] Kinda brute force but worth a try.
[Sean Corfield, cfml] @salted If one of your subsystems has a dependency on a bean in another subsystem, that's definitely something you need to correct -- by moving the bean to the parent (main) app context. Cross-subsystem dependencies indicate a broken design, sorry.
[Ross, cfml] We use our subsystems as modules essentially so it's not an option in this case, but thanks for the pointer I will bring that up
[Kevin Miller, cfml] this may have already been covered but what about a main service that can marshal requests for beans generically to act as a bridge for all areas of the app to leverage