by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 15 18:33
    johnclittle commented #148
  • Apr 15 17:18
    johnclittle commented #148
  • Feb 28 18:27
    mib32 commented #148
  • Oct 24 2019 10:04
    wrozka opened #159
  • Oct 09 2019 03:24
    pwim commented #129
  • Oct 09 2019 03:22
    pwim opened #158
  • Sep 16 2019 01:20
    matiasgarciaisaia commented #129
  • Sep 13 2019 13:06
    umerebryx commented #129
  • Sep 12 2019 15:26
    matiasgarciaisaia commented #129
  • Sep 12 2019 11:42
    umerebryx commented #129
  • Aug 28 2019 17:49
    matiasgarciaisaia commented #129
  • Aug 28 2019 07:09
    umerebryx commented #129
  • Aug 27 2019 12:36
    umerebryx commented #129
  • Jul 01 2019 12:58
    bmedici opened #157
  • Jun 27 2019 04:34
    ndorfin closed #153
  • Apr 27 2019 19:44
    bkazez commented #138
  • Oct 07 2018 04:02
    ikuwow opened #156
  • Oct 02 2018 14:15
    hobodave commented #154
  • Aug 19 2018 13:55
    TheSmartnik opened #155
  • Jul 25 2018 13:40
    lacostej opened #154
Frederic Jean
@fredjean
I'll cherry-pick your changes into master as needed.
Matias Garcia Isaia
@mgarciaisaia
I think I'm pretty much done - it's just that I don't have permission for the S3 bucket I'm testing on
Frederic Jean
@fredjean
Details... ;)
Matias Garcia Isaia
@mgarciaisaia
Yeap.
I've been kind-of-testing, but then there's the permissions issue. So I've tried every path that doesn't work, only the right one is left :P
Frederic Jean
@fredjean
It's progress :)
Matias Garcia Isaia
@mgarciaisaia
If you want to try it, I think it's ready: https://github.com/matiasgarciaisaia/middleman-s3_sync/tree/custom-error-document
I'll make the PR over 3.3.x tomorrow after testing it actually works - but the new release should be v3.4.0, I think, as the new features won't work in older versions of the extension.
The same commit should work if cherry-picked on master, I think.
Frederic Jean
@fredjean
I would argue that making the default index.html and 404.html would make sense...
ah, you are setting the default index document setting further down...
I'll have a deeper look at it tomorrow morning. I'm about to crash...
Matias Garcia Isaia
@mgarciaisaia

Yeah - the default is not to do anything. If you want to change any of both, you must set the Index Document - ie, only the Error Document is optional. That's why they default to nil - to tell when you actually want the index to be index.html apart from when you aren't specifying it.
As the index.html thing is not an AWS default, you can't compare config.index_suffix with "index.html" to distinguish those situations.

But that would be tomorrow's issues. Now it's bed time!

Matias Garcia Isaia
@mgarciaisaia
So I've tested the changes and it worked OK - so there you have #107, ready to be merged :)
Alessandro Prioni
@alessandroprioni
hi guys
I'm having this problem when I try to sync my s3:
...middleman-s3_sync-3.0.47/lib/middleman/s3_sync/resource.rb:209:in `content_type': uninitialized constant Middleman::S3Sync::Resource::MIME (NameError)
(sorry if I'm writing here, but it's pretty urgent)
Alessandro Prioni
@alessandroprioni
solved! I had to add the gem mime-types to my bundle :)
Frederic Jean
@fredjean
@alessandroprioni v3.3.5 added mime-types as a dependency. This is unfortunately a breaking change with fog. The issue has been raised with the fog project.
Patrick Rogers
@pixelchef
Any chance middleman v4 support is coming soon?
Matias Garcia Isaia
@mgarciaisaia
@pixelchef isn't it already there? AFAIK, there was a 4.x branch, besides the 3.x one
And it was working/being maintained
Have you tried the extension with MM4 and it failed? Maybe it's just declaring compatibility with a RC version, because 4 wasn't stable at the time of the last release
Patrick Rogers
@pixelchef
Yeah I had to manually specify the version number in the gemfile
Now im getting a load error rickrogers$ AWS_ACCESS_KEY=XXX AWS_ACCESS_SECRET=XXX middleman build
/usr/bin/middleman:23:in load': cannot load such file -- /Library/Ruby/Gems/2.0.0/gems/middleman-core-4.0.0/bin/middleman (LoadError) from /usr/bin/middleman:23:in<main>'
Patrick Rogers
@pixelchef
nvm forgot bundle exec :smile:
This message was deleted
Patrick Rogers
@pixelchef
Pro:website patrickrogers$ bundle exec AWS_ACCESS_KEY=key AWS_ACCESS_SECRET=key middleman build bundler: command not found: AWS_ACCESS_KEY=key Install missing gem executables with `bundle install` Pro:website patrickrogers$
(keys are correct) I get an error in bundler due to the env not being a gem
did I miss a simply step in config?
Matias Garcia Isaia
@mgarciaisaia
You're writing an invalid command - you should specify the environment variables before bundle exec
Patrick Rogers
@pixelchef
My mistake. The gem appears to be working but I am getting errors with fog http://pastebin.com/jFaaB9k7
Matias Garcia Isaia
@mgarciaisaia
@pixelchef you're hitting this bug: fog/fog-core#171
FWIU the workaround is to manually require 'mime/types' before calling the bugged method - but I have no guarrantee.
Frederic Jean
@fredjean
@pixelchef There is a pre-release version on RubyGems (4.0.1.rc.3). I haven't had the chance to test it on my own site since some of the extensions I use do not appear to work with MM4.
Frederic Jean
@fredjean
I got my blog to (mostly) work under MM4. Testing MM4 support...
Frederic Jean
@fredjean
v4.0.1 (no more rc) has been released. Fixes #105, #114, and #115 .
v3.3.8 has also been released and address #115 on the v3.3.x stream.
Matias Garcia Isaia
@mgarciaisaia
:clap:
Matias Garcia Isaia
@mgarciaisaia
Has anyone tried middleman-s3_sync with the sitemap extension? sitemap adds a sitemap.xml file to the build, but not to the actual Middleman sitemap object - so s3_sync won't upload it :/
Do you have any idea about this? What would the best solution be, and/or the best workaround?
Frederic Jean
@fredjean
There's an open issue to address this. Right now s3_sync is only aware of what is in the Middleman sitemap.
Matias Garcia Isaia
@mgarciaisaia
:+1: Thanks. I'll check with sitemap if there's any reason they don't hook into MM's sitemap, or see how to work around this.
Frederic Jean
@fredjean
I'm thinking that being a sitemap processor might be the reason why some files are falling through the cracks. I'll have to ponder this one for a bit...
Matias Garcia Isaia
@mgarciaisaia
If anyone cares, we worked around the sitemap issue by manually creating the sitemap.xm using a .xml.builder file - it was really simple, and avoided having to fiddle with the middleman-sitemap extension that didn't look that nice
I do think it's OK for s3_sync to only care about what's in middleman's sitemap - I consider a bug that the sitemap extension doesn't get added there
If there are much extensions doing that, maybe adding a wishlist to middleman in which to put an array of globs to sync could be a workaround
Greg Dutcher
@syntactical
I'm trying to push to s3 for the first time and middleman s3_sync keeps hanging
I get this line and then it just stops: == External: Dropping unreachable code [./~/style-loader/addStyles.js:25,0]
Greg Dutcher
@syntactical
I just realized this is a webpack problem, but has anyone run into this?
Frederic Jean
@fredjean
I haven't seen that.