Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 07 00:48
    eloquence commented #354
  • Dec 07 00:47
    eloquence synchronize #354
  • Dec 07 00:47

    eloquence on update-securedrop-logo-to-match-sd-v1

    Use logo version w/o wordmark, … (compare)

  • Dec 06 22:40
    rocodes commented #4191
  • Dec 06 20:28
    emkll commented #5066
  • Dec 06 20:22
    zenmonkeykstop commented #5065
  • Dec 06 19:59
    eloquence commented #285
  • Dec 06 19:51
    zenmonkeykstop commented #5065
  • Dec 06 19:48
    eloquence milestoned #361
  • Dec 06 19:48
    eloquence labeled #361
  • Dec 06 19:48
    eloquence opened #361
  • Dec 06 18:44

    emkll on 300-whonix-15

    (compare)

  • Dec 06 18:44
    emkll closed #304
  • Dec 06 18:44
    emkll commented #304
  • Dec 06 18:38
    emkll opened #360
  • Dec 06 16:40
    zenmonkeykstop review_requested #5067
  • Dec 06 16:40
    zenmonkeykstop review_requested #5067
  • Dec 06 16:40
    zenmonkeykstop opened #5067
  • Dec 06 16:13
    zenmonkeykstop synchronize #4988
  • Dec 06 07:57
    eloquence reopened #282
Erik Moeller
@eloquence
As a reminder, no GMeet standup on Fridays, but quick updates to https://pad.riseup.net/p/SecureDropDailyStandup are appreciated :)
Erik Moeller
@eloquence

Hello everyone! Our standup is in 5 minutes at the usual location:

https://meet.google.com/ekb-kkhf-mrk

Anyone is welcome to participate! Notes are taken on an Etherpad and will be moved to the GitHub wiki by the end of the day.

Erik Moeller
@eloquence
^ same procedure :)
Kevin O'Gorman
@zenmonkeykstop
the curse of libvirt returns
Erik Moeller
@eloquence

Hello everyone! Our standup is in 3 minutes at the usual location:

https://meet.google.com/ekb-kkhf-mrk

Anyone is welcome to participate! Notes are taken on an Etherpad and will be moved to the GitHub wiki by the end of the day.

Conor Schaefer
@conorsch
:heart:
Erik Moeller
@eloquence
Hi folks -- just a heads up that there will be no UX meeting tomorrow (or next week, due to the FPF all-staff). We'll pick up the regular schedule in a couple of weeks.
Erik Moeller
@eloquence

Hello everyone! Our standup is in 5 minutes at the usual location:

https://meet.google.com/ekb-kkhf-mrk

Anyone is welcome to participate! Notes are taken on an Etherpad and will be moved to the GitHub wiki by the end of the day.

mickael e.
@emkll
bringing down apt-test.freedom.press for a brief moment
Kevin O'Gorman
@zenmonkeykstop
looknig at fixing #4387 - would it make more sense to just not start the GUI updater if the amnesia user doesn't have a password set?
upside is it doesn't present the user with something they can't use, downside is that if they never log in with a password set, they never see the gui updater
Erik Moeller
@eloquence
@zenmonkeykstop if we're able to detect that, I think it'd be best to show an error message after the user clicks on "Update Now", and to not set the flag in that case
Kevin O'Gorman
@zenmonkeykstop
yup that's pretty much what I settled on, writing a test now
Erik Moeller
@eloquence
@rmol @zenmonkeykstop are either of you planning to poke at the securedrop-admin py3 changes today? freedomofpress/securedrop#4867
It's basically the last day we have before QA
Kevin O'Gorman
@zenmonkeykstop
to be precise: updater appears -> user clicks update now -> message dialog shown -> update now button deactivated
rmol
@rmol
@eloquence Am planning on it. Still stuck trying to devise a test for the securedrop-app-code dependencies on fresh install.
Kevin O'Gorman
@zenmonkeykstop
I was not. but I can take a look in a bit if noone else is available
Erik Moeller
@eloquence
@rmol would you like to chat with conor or other team members about the dependency testing problem you're stuck on?
Conor Schaefer
@conorsch
@rmol the app code dependencies are installed via ansible. it'd be a bit cleaner and more predictable if we allowed apt to resolve the package dependencies. I suspect we added the ansible install tasks, that essentially duplicate the app-code dependencies, in order to support the install-from-local-packages logic in staging. if we're using dpkg for the deb install, which does not handle Depends on packages, perhaps we could use aptitude instead
i haven't actually confirmed that aptitude will intelligently handle dependencies, but worth a look. that'll allow us to verify that the deps are what's determining the packages pulled in, not the ansible logic (which is seldom run)
Erik Moeller
@eloquence
@zenmonkeykstop your updater strategy sounds good! if you do reach a good stopping point, would appreciate if you could still get some review on #4867 in. if a merge is at all realistic today it's only going to be if both you and John have a chance to test it. If it looks good, Conor can potentially stamp it later.
Conor Schaefer
@conorsch
(also happy to hop on a call to rubberduck with ya, @rmol)
Erik Moeller
@eloquence
@conorsch the other change that would be great to land today is freedomofpress/securedrop#4865
Conor Schaefer
@conorsch
diff review, huzzah! sure, i'll take that one today. :coffee:
Erik Moeller
@eloquence
@emkll the PR body still says "WIP" but I believe it's ready, correct?
Kevin O'Gorman
@zenmonkeykstop
also #4872 :)
Erik Moeller
@eloquence
yes, I've not forgotten about it -- but relatively lower priority IMO
Conor Schaefer
@conorsch
hmm, dependencies change in #4865, as well as #4867. there'll likely be conflicts
mickael e.
@emkll
@eloquence yes, thanks it's ready for review. I've updated the description
Erik Moeller
@eloquence
@conorsch are all the requirements changes in #4867 just a result of the prompt_toolkit update?
Conor Schaefer
@conorsch
that's my understanding, yes. i haven't checked for a submitted diff review on that front yet
Erik Moeller
@eloquence
@conorsch any preferred order of operations for merge? my sense would be that #4865 should go in first so the simpler operation (updating prompt_toolkit) can be applied on the new base
mickael e.
@emkll
(not biased at all) but i think we should aim to merge #4865 first. This will make it easier to open a PR for ansible to 2.7 (i have a local branch). If we can merge #4865, I can open a PR for the Ansible 2.7 change
Erik Moeller
@eloquence
:)
rmol
@rmol
Was still planning on reviewing #4865 too.
Erik Moeller
@eloquence
I think a single review would be sufficient -- @conorsch do you agree? if so I would prefer to have maximum attention from John and Kev on the securedrop-admin changes
since those were authored by conor/kushal and need to get independent testing and review
Conor Schaefer
@conorsch
definitely agree, @eloquence! @rmol if you're able to jump on #4867, i'll start on #4865 pronto. if we can get that one to green, we're good to go.
effectively the diff review has already been performed by @emkll on #4865, so my +1 means two thorough reviews.
Kevin O'Gorman
@zenmonkeykstop
ok am done with the gui updater fix (slightly hampered by the fact that the tests dump core on my system maybe 70% of the time?
will grab some lunch and then take a swing at #4867
Erik Moeller
@eloquence
\o/
rmol
@rmol
Ditto.
Conor Schaefer
@conorsch
coming down the home stretch on #4865, let's make sure to rebase #4867 as soon as that's in
Conor Schaefer
@conorsch
#4865 is in
Kevin O'Gorman
@zenmonkeykstop
#4867 is passing its test plan, @conorsch if you're happy with it after rebase I vote to merge
Erik Moeller
@eloquence

Hello everyone! Our standup is in 5 minutes at the usual location:

https://meet.google.com/ekb-kkhf-mrk

Anyone is welcome to participate! Notes are taken on an Etherpad and will be moved to the GitHub wiki by the end of the day.

[Expecting low attendance given post all staff PTO, but let's still touch base for those of us who can make it]
Conor Schaefer
@conorsch
Starting review of #4876 (will take some time)