Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 07:56
    eloquence demilestoned #292
  • 02:06
    conorsch commented #406
  • 02:02
    conorsch commented #406
  • Jan 26 18:49
    pierwill synchronize #389
  • Jan 26 16:58
    DrGFreeman commented #5105
  • Jan 26 14:25
    DrGFreeman commented #5105
  • Jan 26 00:44
    DrGFreeman synchronize #5096
  • Jan 26 00:27
    DrGFreeman opened #5105
  • Jan 25 05:04
    pierwill synchronize #389
  • Jan 25 04:23
    pierwill synchronize #389
  • Jan 25 02:13
    conorsch commented #406
  • Jan 25 02:08
    conorsch edited #432
  • Jan 25 02:08
    conorsch review_requested #432
  • Jan 25 02:08
    conorsch review_requested #432
  • Jan 25 02:08
    conorsch opened #432
  • Jan 25 01:59
    eloquence synchronize #389
  • Jan 25 01:57
    eloquence edited #389
  • Jan 25 01:55
    eloquence commented #389
  • Jan 25 01:48

    conorsch on 406-prod-make-targets

    Apply conditional logic for yum… Removes "test" from yum repo fi… Adds script to set "environment… and 2 more (compare)

  • Jan 25 01:47
    eloquence synchronize #389
Erik Moeller
@eloquence
@emkll the PR body still says "WIP" but I believe it's ready, correct?
Kevin O'Gorman
@zenmonkeykstop
also #4872 :)
Erik Moeller
@eloquence
yes, I've not forgotten about it -- but relatively lower priority IMO
Conor Schaefer
@conorsch
hmm, dependencies change in #4865, as well as #4867. there'll likely be conflicts
mickael e.
@emkll
@eloquence yes, thanks it's ready for review. I've updated the description
Erik Moeller
@eloquence
@conorsch are all the requirements changes in #4867 just a result of the prompt_toolkit update?
Conor Schaefer
@conorsch
that's my understanding, yes. i haven't checked for a submitted diff review on that front yet
Erik Moeller
@eloquence
@conorsch any preferred order of operations for merge? my sense would be that #4865 should go in first so the simpler operation (updating prompt_toolkit) can be applied on the new base
mickael e.
@emkll
(not biased at all) but i think we should aim to merge #4865 first. This will make it easier to open a PR for ansible to 2.7 (i have a local branch). If we can merge #4865, I can open a PR for the Ansible 2.7 change
Erik Moeller
@eloquence
:)
rmol
@rmol
Was still planning on reviewing #4865 too.
Erik Moeller
@eloquence
I think a single review would be sufficient -- @conorsch do you agree? if so I would prefer to have maximum attention from John and Kev on the securedrop-admin changes
since those were authored by conor/kushal and need to get independent testing and review
Conor Schaefer
@conorsch
definitely agree, @eloquence! @rmol if you're able to jump on #4867, i'll start on #4865 pronto. if we can get that one to green, we're good to go.
effectively the diff review has already been performed by @emkll on #4865, so my +1 means two thorough reviews.
Kevin O'Gorman
@zenmonkeykstop
ok am done with the gui updater fix (slightly hampered by the fact that the tests dump core on my system maybe 70% of the time?
will grab some lunch and then take a swing at #4867
Erik Moeller
@eloquence
\o/
rmol
@rmol
Ditto.
Conor Schaefer
@conorsch
coming down the home stretch on #4865, let's make sure to rebase #4867 as soon as that's in
Conor Schaefer
@conorsch
#4865 is in
Kevin O'Gorman
@zenmonkeykstop
#4867 is passing its test plan, @conorsch if you're happy with it after rebase I vote to merge
Erik Moeller
@eloquence

Hello everyone! Our standup is in 5 minutes at the usual location:

https://meet.google.com/ekb-kkhf-mrk

Anyone is welcome to participate! Notes are taken on an Etherpad and will be moved to the GitHub wiki by the end of the day.

[Expecting low attendance given post all staff PTO, but let's still touch base for those of us who can make it]
Conor Schaefer
@conorsch
Starting review of #4876 (will take some time)
Kevin O'Gorman
@zenmonkeykstop
hey all @emkll raised a good point about the upgrade path for workstations for 1.1.0 - it looks like admins will have to run ./securedrop-admin setup as part of the update? Is there any way around this?
Conor Schaefer
@conorsch
that runs as part of the gui updater, doesn't it?
we still need to be careful about run order... hopefully we don't need to stagger the upgrade over two releases
Erik Moeller
@eloquence
As previously mentioned, I've tentatively split the backlogs on our project board into SD Core and SD Workstation, to make it easier to find issues without scrolling. The SD Workstation backlog is very long -- help nominating issues that can be deferred until after early demos or even pilot deployments is appreciated.
Conor Schaefer
@conorsch
Did not get through the sd-export logging PR (freedomofpress/securedrop-export#17), will cycle my USB export settings and give it another go tomorrow
redshiftzero
@redshiftzero
here are some proposed rotations:
  • string review/comment point person (the idea here being this is the person who makes sure translation suggestions make their way into PRs - 1 week term, the other approach is to have the LM for the upcoming release do this task, i'm kind of on the fence but do think it would be useful for more people to do this task),
  • CI build monitor (makes sure failed nightly/weekly builds get attention - as simple as filing issues for attention - 1 week term),
  • community review/response person (1 week term, they can pull in whoever needed but are responsible for making sure community people get help/feedback, makes sure dev env setup issues get attention)
rmol
@rmol
@1000101 We are finally getting around to appointing reviewers for Slovak, so we can get the translation into 1.1.0. Are you still interested?
Erik Moeller
@eloquence

Hello everyone! Our standup is in 5 minutes at the usual location:

https://meet.google.com/ekb-kkhf-mrk

Anyone is welcome to participate! Notes are taken on an Etherpad and will be moved to the GitHub wiki by the end of the day.

redshiftzero
@redshiftzero
basically the task for CI build monitor is to check on https://circleci.com/gh/freedomofpress/workflows/securedrop/tree/develop:
  1. each morning when you come in and determine - did the nightly jobs fail (shown in that list as develop/nightly)? if yes at minimum file a ticket or note on an existing flake ticket (better would be investigating a bit the breakage or figuring out who might know the answer and pinging them)
  2. and the same on mondays after the weekly jobs run on sunday
redshiftzero
@redshiftzero
hey @emkll regarding the test plan on freedomofpress/securedrop#4884 - did you do a test install from tails when proposing this PR? what do you think about merging relying on CI (since full QA for 1.1.0 will test all the ansible playbooks including e.g. backup/restore)?
redshiftzero
@redshiftzero
ok i went ahead and did that (emkll out for the night) - that's now included in release/1.1.0 (branch protection enabled) which i just made so we're in a good place for cutting rc1 tomorrow. and it's OK if the supported language changes come in during the QA period since they are small changes
pierwill
@pierwill
Hi all! :wave:
I prettified the main repo's README.md a little bit with some light rewording. Not a huge priority admittedly, but it pleased me to do it.
freedomofpress/securedrop#4886
(feel free to decline if the note about pre-RTD links is important!)
Erik Moeller
@eloquence
@pierwill awesome, we were just talking about how this needs to be cleaned up a bit :)
pierwill
@pierwill
:smile:
Erik Moeller
@eloquence

Hello all! Our sprint planning meeting begins in 5 minutes. All materials can be found here:

https://pad.riseup.net/p/SecureDropSprint39

Same GMeet link as always:

https://meet.google.com/ekb-kkhf-mrk

Erik Moeller
@eloquence
At the risk of column overload, added a "Discussion Points" column for standup/engineering meeting discussions (rightmost to keep the main board flow uninterrupted)
Feel free to add cards there anytime, and we'll prioritize those as we go
Conor Schaefer
@conorsch
need moar widescreen monitors. thanks, i like the Discussion Points list. it's easy to jot a thought down for group discussion later, without the threat of burial by scrollback
Erik Moeller
@eloquence
(I'll try to keep it at column length, so may bump stuff to backlog liberally)
Conor Schaefer
@conorsch
:+1:
Erik Moeller
@eloquence
do we need to line up backports for freedomofpress/securedrop#4890 and freedomofpress/securedrop#4889 ?
Nina Eleanor Alter
@ninavizz
Holla fine folx! Reminder: Tomorrow AM = UX meeting!! Planning to discuss Personas + User Profiles, and to dig into how exactly I came up with what was presented at the retreat. Agenda w/ links, forthcoming...
Erik Moeller
@eloquence
Project board and planning spreadsheet should be in sync; notes from sprint planning can be found on the wiki as well. :)