Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 25 10:14

    joostdecock on master

    chore: Updated github tags (compare)

  • Oct 25 10:14

    joostdecock on develop

    chore: Updated github tags (compare)

  • Oct 25 09:59

    joostdecock on master

    chore: Updated issue templates Update issue templates chore: Fixed incorrect dir name and 5 more (compare)

  • Oct 24 23:27

    dependabot-preview[bot] on npm_and_yarn

    (compare)

  • Oct 24 23:27
    dependabot-preview[bot] closed #585
  • Oct 24 23:27
    dependabot-preview[bot] commented #585
  • Oct 24 23:27
    dependabot-preview[bot] labeled #595
  • Oct 24 23:27
    dependabot-preview[bot] opened #595
  • Oct 24 23:27

    dependabot-preview[bot] on npm_and_yarn

    chore(deps): Bump gatsby from 2… (compare)

  • Oct 24 22:31

    dependabot-preview[bot] on npm_and_yarn

    (compare)

  • Oct 24 22:30
    dependabot-preview[bot] closed #287
  • Oct 24 22:30
    dependabot-preview[bot] commented #287
  • Oct 24 22:30
    dependabot-preview[bot] labeled #297
  • Oct 24 22:30
    dependabot-preview[bot] opened #297
  • Oct 24 22:30

    dependabot-preview[bot] on npm_and_yarn

    chore(deps): bump mongoose from… (compare)

  • Oct 24 17:30

    joostdecock on master

    refactor: Removed unused commun… (compare)

  • Oct 24 17:25

    joostdecock on develop

    chore: Updated contributor guid… fix: Link in contributing guide… (compare)

  • Oct 24 07:34
    joostdecock commented #1070
  • Oct 24 07:33

    joostdecock on develop

    Fix small typo in hashtag Merge pull request #1070 from j… (compare)

  • Oct 24 07:33
    joostdecock closed #1070
Patrick Forringer
@destos
Will have a preliminary draft PR up soon to look at
Joost De Cock
@joostdecock
Looks great @destos
Patrick Forringer
@destos
@joostdecock did you want the mirror macro in a new plugin, or in an existing macro plugin?
Joost De Cock
@joostdecock
New plugin. And I think we should called it reflect rather than mirror. In many drawing programs, to mirror does not do what this does, but rather... you know, mirrors.
Patrick Forringer
@destos
:thumbsup:
Joost De Cock
@joostdecock
IMG_20200510_184039.jpg
Pardon my crummy handwriting and drawing skills :see_no_evil: but this is what I mean by reflect vs mirror
Patrick Forringer
@destos
Ok, the line I’m using to reflect is perpendicular to the line you drew
I don’t have the line shown in my screenshot
Joost De Cock
@joostdecock
No worried
s
@devanshkain You mean in the dev environment v2.6.0, right?
Patrick Forringer
@destos
Screen Shot 2020-05-10 at 11.32.21 AM.png
Alright, will have something up to look at soon, not fully featured, but working
Joost De Cock
@joostdecock
Ok. Now that I would call mirror If you were using the red dotted line that goes upward, I would call that reflect
So I guess it is mirror after all
Great, because I think that's more common than reflecting things
Patrick Forringer
@destos
Yeah, wanted to make sure it was clear.
Joost De Cock
@joostdecock
Thanks for that :thumbsup:
Patrick Forringer
@destos
@AlfaLyr @joostdecock PR pushed if you want to take a look: freesewing/freesewing#407
Joost De Cock
@joostdecock
:clap: :clap: :clap: I won't have time to look at this tonight, but I will asap. Saw your remark about the tests, seems I have overlooked to properly configure plugin tests since migrating to Lerna. Created freesewing/freesewing#408 for that. I will look after that.
Patrick Forringer
@destos
Cool, a piece I still have to work on is attaching points to the part’s points property, will use the nameFormat function with fallback method you suggested the other day.
devanshkain
@devanshkain
@joostdecock Yeah the latest one.
Juona-France
@Juona-France
Hello, a suggestion from an obstinate one who like to repeat the project if she is not satisfied with the realisation and learn from her mistakes : it could be useful to print on the first page of the pattern the user's measurements and values of options selected. Would the community like to comment on that ?
Joost De Cock
@joostdecock

I doubt people will argue the point that it could be useful. Unfortunately, it is surprisingly non-trivial given how patterns are tiled (split into pages).

The SVG output is sent to the backend where it is run through Inkscape in cli mode to turn it into PostScript.
Then, our custom fork of a 21-year old C-program turns that into tiled PostScript.

Adding any sort of text to the coverpage involves writing C code that in turn outputs PostScript code. In addition, PostScript (like SVG) does not handle flowed text. So you have to determine where lines should break/wrap and so on.

It seems a lot of work for limited benefits. Not to mention that you have to program in C, which is not the typical profile of people who contribute to FreeSewing
Your best bet is to convince @woutervdub who has contributed to the tiler before
There's also been talk about generating PDFs on the client-side. In the long run, that might give us more options.
Wouter van Wageningen
@woutervdub
It's an option I have requested myself way back when. But as you explained, it's not trivial at all. Since the tiler doesn't get any information except for the file, there isn't much that can be done at that point. I guess we could put that kind of data into the metadata of a PDF file, if our PDF generating step allows for that (which I doubt).
Joost De Cock
@joostdecock
I could look at passing the data somehow if you are if the opinion that's a blocking factor.
We already pass the language I see to remember, but passing a 2 character string as a command line option doesn't really compare to passing measurements and options
Wouter van Wageningen
@woutervdub
I'd have to take a more thorough look at the code of the Tiler, and what would be involved with all the measurements and options (which can be quite significant)
Let's take Simon. That would be a lot of measurements and options to fit somewhere on the page...
It could be on a separate/additional page maybe?
Florent GIRAUD
@Rufus31415
@Juona-France I have a proof of concept here : https://hautlesfils.fr/le-haut/
It is a pure client JavaScript pdf render. I had on the first page a preview, the measurements and option values
saurabhank
@saurabhank

Hey Joost! I added options and optionGroups.
Which is as below.

optionGroups: {
armholeoptions:
[
"shoulderslopedepth","armholecenter","armbottomwidth",
{armholecp: ["topcpspread","midcp2spread","midcp1spread","bottomcpspread"]},
{armtopshiftup:["armtopshift"]},
{armholedart:["armholedartlength","armholedartwidth","frontdart","afterdartcurvefactor"]}
],
neckoptions:
[
{neckcpspread: ["neckcprightspread","neckcpbottomspread"]},
{neckcpangle: ["neckcprightangle","neckcpbottomangle"]},
{neckdimensions: ["neckwidth","neckdepth"]}
],
waistdart: ["waistdartwidth", "waistdartlength"]
},
options: {
//Importing from arm hole
bottomcpspread: { pct: 18, min: 0, max: 100 },
midcp1spread: { pct: 10, min: 0, max: 100 },
midcp2spread: { pct: 9, min: 0, max: 100 },
topcpspread: { pct: 20, min: 0, max: 100 },
shoulderslopedepth: { mm: 19.05, min: 0, max: 25.4},
armtopshift: { mm: 0, min: 0, max: 177.8},
armholecenter: { mm: 0, min: 0, max: 50},
armbottomwidth: { mm: 0, min: 0, max: 12.7},

//armholedartoptions
armholedartlength: { mm: 0, min: 0, max: 76.2},
armholedartwidth: { mm: 25.4, min: 0, max: 12.7},

//neck hole
neckwidth: { mm: 127, min: 0, max: 177.8},
neckdepth: { mm: 76.2, min: 0, max: 177.8},
neckcprightspread: { pct: 50, min: 0, max: 100},
neckcpbottomspread: { pct: 50, min: 0, max:100},
neckcprightangle: { deg: 0, min: -90, max: 90},
neckcpbottomangle: { deg: 0, min: -90, max: 90},
frontdart: {
  list: ['no', 'yes'],
  dflt: 'no'
},
afterdartcurvefactor: { mm:0.15 , min: 0 , max:0.5},

//waist dart
waistdartwidth: { mm: 50.8, min: 0, max: 50.8 },
waistdartlength: { mm: 0, min: -101.6, max: 12.7}

}

In browser console it is giving this kind of error.
[React Intl] Cannot format message: "options.neck.armholedartwidth.description", using message id as fallback. index.js:1

[React Intl] Missing message: "options.neck.armholedartwidth.description" for locale: "en"
And The slider to change the value is not worknig. It was working in previous versions.
Joost De Cock
@joostdecock
There's an issue with the sliders in the dev environment in 2.6.0, it's on my todo-list :see_no_evil:
saurabhank
@saurabhank
Okay Joost! Thanks.
Kieran Klaassen
@kieranklaassen
I like how vibrant the dev chat is lately! New faces
Juona-France
@Juona-France
@saurabhank @saurabhank
@saurabhank
Juona-France
@Juona-France
About suggestion to print somewhere measurements and values of options : not being a developer, I did not understand technical explanations. Just to let members know, Rufus’s proposal meets needs perfectly on my opinion. And @woutervdub : yes if it's on a separate/additional page it would be great too :-)
Joost De Cock
@joostdecock
Yes, I think Rufus is on to something :)
Roopin Bhadri
@Roopin619
Hi Joost! I was trying to add my custom measurements in the models/src/measurements.js and utils/neckstimate/index.js file but after running yarn kickstart to build the project, all the changes made in the utils/neckstimate/index.js file were lost and the file was just as it was before running. Can you please tell me why this is happpening?
Joost De Cock
@joostdecock
yarn kickstart installs all dependencies. It does not build the project. You can run yarn build in the package repo, or lerna run build for that
Joost De Cock
@joostdecock

Hey @joostdecock ,as per my last request the options are now accessible but the sliders aren't working (I cross checked my work in your previous packages and it worked there). Please look into it.

@devanshkain I had a look at the sliders issue, but I can't seem to reproduce it. Looks fine to me on v2.6.0.

devanshkain
@devanshkain
I rechecked and the issue is just with mm values, pct and list works fine.