fs2-http/Lobby

Anthony Cerruti

@srnb_gitlab

So does that mean every event handler needs to be fed an IO with some sort of callback?

I don't understand how that helps event handlers to send things to the WS

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab Sending to WS and processing messages from WS is usually done via queues. That way you can direct the data where ever you want.

Anthony Cerruti

@srnb_gitlab

Apparently the websocket docs are way out of date; Stream#mergeDrainL no longer exists meaning I can't follow what those docs do

Luciano

@lJoublanc

I think this can be replaced with concurrently without probs.

(you may have to swap the arguments possibly).

Anthony Cerruti

@srnb_gitlab

Well, I'm not getting errors

case class EventSocket[F[_]](myShard: Int, maxShards: Int, queue: Queue[F, Event])(implicit concurrent: Concurrent[F]) {

  def wsPipe(matcher: EventMatcher, handler: PartialFunction[Event, Option[Event]]): Pipe[F, Frame[String], Frame[String]] = { inbound =>
    val output = queue.dequeue.map(e => Frame.Text(e.asJson.noSpaces))
    output.concurrently(inbound.flatMap { in =>
      val json: Json = parse(in.a).right.toOption.get
      val matched: Stream[F, Option[Event]] = matcher[F](json)
      val handeled: Stream[F, Option[Event]] = matched.map(_.flatMap(handler))
      val queued: Stream[F, Unit] = handeled.flatMap(_.fold[Stream[F, Unit]](Stream.empty)(e => Stream.eval(queue.enqueue1(e))))
      queued
    })
  }

}

Am I doing this correctly?

Luciano

@lJoublanc

Just check the concurrently signature in the scaladoc; make sure it matches mergeDrainL i.e. the Nothing has to be on the correct side.

Anthony Cerruti

@srnb_gitlab

Any ADT to represent Websocket URIs?

Huh, URI can do wss but WebSocketRequest can't do URI

Anthony Cerruti

@srnb_gitlab

I just made my own match case for now

Media Type must be text, but is DefaultMediaType(application,json,true,true,WrappedArray(json))

How do I fix this? I'm using circe, should I just do bodyAs[Json] instead?

Anthony Cerruti

@srnb_gitlab

java.lang.Throwable: Failed to decode value: cannot acquire 16526844176 bits from a vector that contains 728 bits, content: ByteVector(95 bytes, 0x7b2274223a6e756c6c2c2273223a6e756c6c2c226f70223a31302c2264223a7b226865617274626561745f696e74657276616c223a34313235302c225f7472616365223a5b22676174657761792d7072642d6d61696e2d6b673677225d7d7d)

Why does fs2-http want 2GB

Anthony Cerruti

@srnb_gitlab

The first issue is an issue with normal requests, and the second is an issue with websockets, by the way

Anthony Cerruti

@srnb_gitlab

Should I make an issue on GitHub or is there something I need to fix on my end?

Pavel Chlupacek

@pchlupacek

@srnb_gitlab please feel free open issue. Even when this will be on your end, it us easier for us to respond, hence we will see you source code. I likely say that it is the case, hence both ws and http are used in production.

Anthony Cerruti

@srnb_gitlab

@pchlupacek #32 #33 #34

Pavel Chlupacek

@pchlupacek

@srnb_gitlab thanks, will reply you back. On the documentation/sample could do you have some free time to perhaps suggest P/R to fix that?

Anthony Cerruti

@srnb_gitlab

Yep, I can do that

#35

Anthony Cerruti

@srnb_gitlab

I need a plain text value option for the Authorization header

Adam Chlupacek

@AdamChlupacek

Hello @srnb_gitlab what do you mean plain text value? is the BasicHttpCredentials not enough?

Anthony Cerruti

@srnb_gitlab

@AdamChlupacek I didn't see a BasicHttpCredentials. I just recently had to move from DigestHttpCredentials to OAuthToken due to some sort of java error (But the only reason I can use OAuth token is because the token has a space in it)

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab yeah no problem

Anthony Cerruti

@srnb_gitlab

How do I tell a websocket to close with some sort of code?

I need to exit the application at some point.

Pavel Chlupacek

@pchlupacek

easiest way is to terminate stream that is piped to websocket. That will in turn close websocket

Anthony Cerruti

@srnb_gitlab

Is there a way to close with a code though? Not just terminate the connection?

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab Currently there is no way to do that, it should not be hard to extend the frames so that once of the frames in the websocket pipe will be close, and afterwards everything will clean up.

Anthony Cerruti

@srnb_gitlab

@AdamChlupacek BasicHttpCredentials is not enough

I need straight up plaintext

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab could you please provide how the header should look like? I am not entirely sure what you mean by plain text

Anthony Cerruti

@srnb_gitlab

s"Authorization: ${mpPlaintextCredentials.text}" @AdamChlupacek

case class PlaintextCredentials(text: String)

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab such format is sadly not RFC compliant according to https://tools.ietf.org/html/rfc7235#section-4.2, however you coud use our HttpCredentials.DigestHttpCredentials header in form of DigestHttpCredentials(mpPlaintextCredentials.text, Map.empty) this should be encoded into the form you require.

Anthony Cerruti

@srnb_gitlab

@AdamChlupacek Ah, but that gives an error that it's not an instance of OAuthCredentials

Adam Chlupacek

@AdamChlupacek

OAuthCredentials? That does not seem to be a concept in fs2-http? is that response that you get from the server where you are trying to connect?

@srnb_gitlab actually, what version of protocols are you using currently?

Anthony Cerruti

@srnb_gitlab

@AdamChlupacek What do you mean?

https://gitlab.com/dscala/discocat/blob/master/src/main/scala/org/discordscala/discocat/util/RequestUtil.scala#L14 OAuthToken, my bad

But that forces me to put Bot before the thing

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab well basically, fs2-http is dependent on spinoco/protocols where are all headers defined, it is possible that in your version of protocols the authorisation header does not yet support the multiple types of authorisation, thats why I was asking on what version of protocols are you. Anyhow in this encoding i think if you put your token instead od the bot, and left the field where you have the token now as empty string, it should be fine

Anthony Cerruti

@srnb_gitlab

@AdamChlupacek Nope. Then it throws an error about a trailing space.

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab thats weird, i am quite sure that we do not do these checks

I am also confused with the previous error as I could not find the “OAuthCredentials” error anywhere in the code

Anthony Cerruti

@srnb_gitlab

OAuthToken, not OAuthCredentials

It's in the same file as the other credentials

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab yeah, you seem to be using some outdated versions, could you please ensure that you are using "com.spinoco" %% "protocol-http" % "0.3.17" atleast, or "0.3.18-SNAPSHOT" for the newest one. Also please use the up to date fs2-http "0.4.1"

Anthony Cerruti

@srnb_gitlab

@AdamChlupacek

Where communities thrive

People

Repo info

Activity