hi everyone,
I am trying to transform the stream response to an effect response like below
httpClient.request(request).compile.lastOrErrorI am trying to keep the http responses as effect if possible. I want to use fs2-http for websocket as well, that's why even though in some places i need to lift it to stream it makes more sense to me to keep it as effect first. But when I do that I am having the exception below on any http request.
java.nio.channels.ClosedChannelException: null
at java.base/sun.nio.ch.AsynchronousSocketChannelImpl.read(AsynchronousSocketChannelImpl.java:234)
at java.base/sun.nio.ch.AsynchronousSocketChannelImpl.read(AsynchronousSocketChannelImpl.java:298)
at fs2.io.tcp.Socket$.$anonfun$apply$3(Socket.scala:283)
at fs2.io.tcp.Socket$.$anonfun$apply$3$adapted(Socket.scala:276)maybe it is not intended to evaluate that way, is it possible to use this way?
I have that same problem with FS2's sockets
You want to ask here
@TheMover Its not public, its in our production, we wanted to test it there before we put it into fs2-http, but it is similar how we have multipart done for email (https://github.com/Spinoco/fs2-mail/blob/series/0.4/src/main/scala/spinoco/fs2/mail/mime/MIMEPart.scala)
I was checking client side web sockets. I can see there is a parameter for pinging in server function but it is not exposed in client side
WebSocket:112
case None => (body through impl.webSocketOf(pipe, Duration.Undefined, maxFrameSize, client2Server = true) through socket.writes(None)).drain ++ emit(None)Is there a way I am missing?
I'll ask in scala/scala because I might be able to
publishLocal it for 2.13
I'll send you what I've done if it works
@srnb_gitlab I have tried it, and sadly it seems its not currently that straight forward, we are using some flags which seem not to be supported in 2.13 anymore. We already have a contributor in protocols trying to get it working for 2.13, I will ask him to make sure that everything other than kafka is working and at that point I will make a snapshot from the branch.
@lJoublanc I've been learning about HTTP/2 and QUIC and I kinda want to make a contribution to fs2-http with them
@AdamChlupacek I see htt4s has support - I wonder how they manage it without the JVM version restriction.
Do not take me 100% on this here, but basically, if you have your own SSL stack then you can do what ever, we however are using the fs2-crypto, which for the ease of things is using the java SSLEngine to provide SSL/TLS, which in java 8 sadly does not support the extension. To which, as I mentioned, I saw somewhere some patches to get the extension support there, but to me it is a bit weird to override the default classes, it makes a mess of the dependencies.
Quick look at http4s they are using this jetty thing as well
And here you go, https://github.com/http4s/blaze/blob/master/examples/src/main/scala/org/http4s/blaze/examples/http2/H2ClientExample.scala from http4s which says that the user has to modify their boot path so that the jetty overried is included
How would you feel about a dependency on the JDK 9 incubator httpclient? Do you think that would work?
My understanding is that it's currently an external dependency, not distributed with Java SE, but eventually would become part of the SE in a future JVM release.
I would be kinda against to use this client as an replacement for our implementation, it will be harder to reason about resources like that, fs2-http is meant to implement the whole stack. Also, I am quite sure that this dependency requires java 9, and at that point it can be implemented easy in our current stack
Or is the whole http implementation written from scratch?