fs2-http/Lobby

Soren

@srnb_gitlab

You want to ask here

Sait Sami Kocataş

@Deliganli

thanks, I am moving it now

Seth Lasky

@TheMover

Hey guys, how can I send an SSL cert along with a request?

Seth Lasky

@TheMover

Also(sorry for rapid fire questions) is there a good way to post multipart data?

Seth Lasky

@TheMover

Figured out the ssl context, now it's only one question

Adam Chlupacek

@AdamChlupacek

Hello @TheMover , sadly currently we do not have any support for multipart data. I have some preliminary support in one of my project, I could polish it over the weekend and get it into snapshot.

Seth Lasky

@TheMover

That would be sweet, could I take a look at it?

Adam Chlupacek

@AdamChlupacek

@TheMover Its not public, its in our production, we wanted to test it there before we put it into fs2-http, but it is similar how we have multipart done for email (https://github.com/Spinoco/fs2-mail/blob/series/0.4/src/main/scala/spinoco/fs2/mail/mime/MIMEPart.scala)

Sait Sami Kocataş

@Deliganli

I was checking client side web sockets. I can see there is a parameter for pinging in server function but it is not exposed in client side

WebSocket:112

case None => (body through impl.webSocketOf(pipe, Duration.Undefined, maxFrameSize, client2Server = true) through socket.writes(None)).drain ++ emit(None)

Is there a way I am missing?

Adam Chlupacek

@AdamChlupacek

@Deliganli This seems to be an oversight. I think there is no reason why client should not allow to send ping.

Adam Chlupacek

@AdamChlupacek

@TheMover Hey there, I have not managed to get the whole thing ported yet, but there is now PR into protocols which is required to enable to port the multipart support over to the fs2-http. So progress is there but slow :/

Soren

@srnb_gitlab

What's blocking fs2-http from 2.13 at the moment?

Adam Chlupacek

@AdamChlupacek

Hey @srnb_gitlab we are waiting for protocols to get their 2.13 version, they are however blocked on kafka, which should get 2.13 build in the 2.4.0 release, until then we are stuck :/

Soren

@srnb_gitlab

@AdamChlupacek Any chance you can hack a 2.13 build of protocols-http out? (Add a crossScalaVersions += "2.13.0" to it and publish?)

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab I can try have a look at it over the weekend, but i guess snapshot will be the best we can hope for at the moment

Soren

@srnb_gitlab

:ok_hand:

I'll ask in scala/scala because I might be able to publishLocal it for 2.13

I'll send you what I've done if it works

Soren

@srnb_gitlab

@AdamChlupacek You should be able to add crossScalaVersions += "2.13.0" to the http module's .settings( and then sbt ++2.13.0 http/publish?

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab I will try to get this together tomorrow, thank you for the how to

Soren

@srnb_gitlab

:+1:

Luciano

@lJoublanc

Hey guys fs2-http doesn't have support for HTTP/2, does it?

Adam Chlupacek

@AdamChlupacek

Yeah it currently does not

Adam Chlupacek

@AdamChlupacek

@srnb_gitlab I have tried it, and sadly it seems its not currently that straight forward, we are using some flags which seem not to be supported in 2.13 anymore. We already have a contributor in protocols trying to get it working for 2.13, I will ask him to make sure that everything other than kafka is working and at that point I will make a snapshot from the branch.

Soren

@srnb_gitlab

Alright

@lJoublanc I've been learning about HTTP/2 and QUIC and I kinda want to make a contribution to fs2-http with them

Adam Chlupacek

@AdamChlupacek

With http/2 there could be major issue with java8 i have been looking into it in the past, and basically the sslEngine provided by java does not support application protocol extension, which is one of the main ways how connection gets into http/2 :/

Luciano

@lJoublanc

My personal interest is from google protocolbuffers/gRPC . Just messing around with that and it uses HTTP/2 for transport.

@AdamChlupacek I see htt4s has support - I wonder how they manage it without the JVM version restriction.

Soren

@srnb_gitlab

http4s runs through fs2-io sockets to do HTTP as far as I know @lJoublanc

Adam Chlupacek

@AdamChlupacek

As far as I know there is a path that basically overrides the default classes so that it supports this feature

Do not take me 100% on this here, but basically, if you have your own SSL stack then you can do what ever, we however are using the fs2-crypto, which for the ease of things is using the java SSLEngine to provide SSL/TLS, which in java 8 sadly does not support the extension. To which, as I mentioned, I saw somewhere some patches to get the extension support there, but to me it is a bit weird to override the default classes, it makes a mess of the dependencies.

Adam Chlupacek

@AdamChlupacek

Yeah here it goes: https://stackoverflow.com/questions/39856972/http-2-java-8-jetty-and-alpn

Quick look at http4s they are using this jetty thing as well

And here you go, https://github.com/http4s/blaze/blob/master/examples/src/main/scala/org/http4s/blaze/examples/http2/H2ClientExample.scala from http4s which says that the user has to modify their boot path so that the jetty overried is included

Luciano

@lJoublanc

How would you feel about a dependency on the JDK 9 incubator httpclient? Do you think that would work?

Adam Chlupacek

@AdamChlupacek

Well depends what will it bring us and what it will mean in terms of dependencies for us?

Luciano

@lJoublanc

I suppose as it provides http 1.1 as well it would replace the legacy java.net interface. I'm going to have a look to see how difficult it would be to patch it in, and maybe spend a day to see if it's possible.

My understanding is that it's currently an external dependency, not distributed with Java SE, but eventually would become part of the SE in a future JVM release.

Adam Chlupacek

@AdamChlupacek

I would be kinda against to use this client as an replacement for our implementation, it will be harder to reason about resources like that, fs2-http is meant to implement the whole stack. Also, I am quite sure that this dependency requires java 9, and at that point it can be implemented easy in our current stack

Luciano

@lJoublanc

I am quite sure that this dependency requires java 9

correct

it will be harder to reason about resources like that, fs2-http is meant to implement the whole stack.

I am not sure I understand. Don't yo ucurrently use java.net for connectivity, with fs2 just providing concurrency?

Or is the whole http implementation written from scratch?

Luciano

@lJoublanc

Ah, I think I understand now; you've built the http transport from scratch, but you use TLS from JDK, and that's the blocker?

Adam Chlupacek

@AdamChlupacek

Yes exactly, http transport if from scratch build upon the fs2 sockets. And yeah http2 requires TLS to support the ALPN, which is only supported from java 9.

Luciano

@lJoublanc

:confounded: ugh just reading over the HTTP/2 spec, and it's not straight forward ... needs new codecs for the compressed HPACK headers, as well as implementing flow control, multiplexing, and a state machine. May have to stick to http4s for time being :frowning:

Adam Chlupacek

@AdamChlupacek

Yeah, it is quite complex.

Soren

@srnb_gitlab

@AdamChlupacek You're still on sbt 0.13 for protocols :grimacing:

Soren

@srnb_gitlab

Also, I got http to publishLocal for 2.13

Soren

@srnb_gitlab

twothirteensupport.patch

Please, do not commit this

Where communities thrive

People

Repo info

Activity