Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 11 21:26
    vbfox closed #2392
  • Sep 11 21:26
    vbfox commented #2392
  • Sep 11 21:26
    vbfox closed #2394
  • Sep 11 21:26
    vbfox commented #2394
  • Sep 11 20:28
    vbfox synchronize #2394
  • Sep 11 20:22
    vbfox synchronize #2394
  • Sep 11 20:18
    vbfox commented #2394
  • Sep 11 19:57
    vbfox commented #2394
  • Sep 11 16:42
    matthid commented #2394
  • Sep 11 16:32
    matthid commented #2394
  • Sep 11 16:24
    matthid commented #2394
  • Sep 11 16:19
    matthid commented #2394
  • Sep 11 15:37
    forki commented #2394
  • Sep 11 15:24
    vbfox commented #2394
  • Sep 11 14:44
    vbfox opened #2394
  • Sep 11 11:58
    vbfox opened #2393
  • Sep 10 22:47
    matthid commented #2392
  • Sep 10 21:26
    vbfox commented #2392
  • Sep 10 18:24
    vbfox commented #2392
  • Sep 10 15:54
    matthid commented #2392
Mike Clark
@mclark1129
I'm trying to figure out why my Team City build is reporting success, despite the fact that the Octo task I am running is failing (and reporting that in the logs)
I'm performing a DeployRelease where one of the steps fail. In the logs I see [13:55:38][Step 1/1] Finished (Failed) 'Octo ' in 00:00:01.3062711 [13:55:38][Step 1/1] Finished (Success) 'DeployRelease' in 00:00:01.3940246
Where DeployRelease is the target running Octo.deployRelease
Is there something I need to do explicitly in order to fail the build target? This just happens automatically if I perform something like DotNet.build
Matthias Dittrich
@matthid
@mclark1129 I think I'd need a minimal sample to say for sure but usually when something fails an exception is thrown and it should bubble up and fail the build. Maybe in your situation it is catched somewhere (or no exception is thrown)
Peter Finn
@mastion
I tried to use the slack webhook integration in Fake 5. It works but when I modified the From field it didn't change the slack username. I looked at the node-slack-sdk and I think the field to modify that is username. Looking at the code I didn't see a transform function but might be missing something. Has anyone been successful changing the posters name using the Fake 5 api?
Matthias Dittrich
@matthid
@mastion I don't think that particular module is heavily used and I don't know any specific people I could ping for this (I'm not using it either). On the other hand it looks like the module is just calling some APIs and doing a jsonconvert on the record types. So just renaming the field in the record should do.
I think you can just copy the SlackNotification.fs to your project and #load it. Once it works just send a PR back :)
Peter Finn
@mastion
Will do. Thanks
Andreas Vilinski
@vilinski
Guys, do you know how to use Fake.Core.Vault? Here is an example how to read encrypted variables http://fake.build/core-vault.html, but not how to save them. What I need is a global replacement for dotnet user-secrets. And Vault.createKey creates some key file, but I don't get how to use them.
Matthias Dittrich
@matthid
@vilinski The idea of the Vault is to have two input methods (like File and Environment Variable) and you need both in order to read the variables. As you pointed out there is currently no good public API to create Vaults in the package as we expect the Vault to be created by other systems, like in the Azure DevOps integration (https://github.com/isaacabraham/vsts-fsharp/blob/master/Common/fake5.ts#L18 and https://github.com/isaacabraham/vsts-fsharp/blob/master/Common/myvault.ts#L32 for example).
But there are some public APIs I have used for testing like createKey and encryptVariable https://github.com/fsharp/FAKE/blob/release/next/src/app/Fake.Core.Vault/Vault.fs#L111
With these and a Newtonsoft.Json Serialize call it should be quite straightforward to build some json
Tomas Jansson
@mastoj
I'm trying to build a dotnet core 3 preview project on Azure Devops, but for some reason it fails when I run fake build. Here is the actual output from azure devops: https://tomasjansson.visualstudio.com/heiconv/_build/results?buildId=12 The azure pipelines is defined here: https://github.com/mastoj/heiconv/blob/master/azure-pipelines.yml
The error is that I 'Microsoft.NETCore.App', version '2.1.0' is missing, but why do I need that? Shouldn't it be enough to install dotnet core 3?
Shmew
@Shmew
@mastoj
I think your task version is wrong
or rather I think you could get it with something like this
- task: UseDotNet@2
  displayName: 'Install .NET Core'
  inputs:
    packageType: sdk
    version: 3.0.100-preview7-012821
    installationPath: $(Agent.ToolsDirectory)/dotnet
Tomas Jansson
@mastoj
@Shmew I’ll try that tonight. New to azure devops, so I don’t have the full understanding of the config yet.
Tomas Jansson
@mastoj
@Shmew I still have the same problem as seen in this build: https://tomasjansson.visualstudio.com/heiconv/_build/results?buildId=13&view=logs
Tomas Jansson
@mastoj
I needed to add both the 3.0 preview of dotnet core and 2.1 to get it working
- task: UseDotNet@2
  displayName: 'Install .NET Core'
  inputs:
    packageType: sdk
    version: 3.0.100-preview7-012821
    installationPath: $(Agent.ToolsDirectory)/dotnet
- task: UseDotNet@2
  displayName: 'Install .NET Core 2.1'
  inputs:
    packageType: sdk
    version: 2.1.x
    installationPath: $(Agent.ToolsDirectory)/dotnet
Shmew
@Shmew
I had that issue on my desktop funny enough, it's related to one of the packages specifying that it needs that sdk version rather than the pipeline itself if I remember correctly. @mastoj
Tomas Jansson
@mastoj
I guess we will get rid of that “nonsense” when fake is updated to dot net core 3 since we then can build a single executable. Or is that the wrong way to go?
Shmew
@Shmew
I don't see why that wouldn't work, but I'm no expert
Matthias Dittrich
@matthid
@mastoj Any reason you are not installing and using the official fake tasks in your azure devops instance? But yes indeed you currently need a latest stable installed to get fake running
Tomas Jansson
@mastoj
@matthid , the reason is that I didn’t know about it. Last night was the first time I played around with azure devops :)
Tomas Jansson
@mastoj
@matthid I changed to use it now, but what is it that I gain by using it (except for one step less)?
Looks like the build fails when using the official fake tasks, https://tomasjansson.visualstudio.com/heiconv/_build/results?buildId=16. I try to build a dotnet core 3 preview console app. Works fine when installing fake manually as seen here: https://tomasjansson.visualstudio.com/heiconv/_build/results?buildId=17
Matthias Dittrich
@matthid
@mastoj It looks like fake is running but the version is too old for it to support netcoreapp3.0 (Caching tool: fake 5.4.1 x64)
All you need at this point is setup a newer fake version in the task itself
The idea is to manage fake version via a shared variable in azure devops for example
Tomas Jansson
@mastoj
Got it, I’ll try that @matthid
Lucas Peixoto
@OshoNot
Hey guys
Have anyone been able to have intelisense into visconde + FAKE 5?
Mac OS machines?
Florian Verdonck
@nojaf
I usually add an empty target, run that so the packages are restored and restart the IDE.
Matthias Dittrich
@matthid
@OshoNot You mean vscode?
Lucas Peixoto
@OshoNot
Yep. I got it running. Followed @nojaf tip. Thanks guys
Florian Verdonck
@nojaf
Hey, could someone point me to the source code where fake will resolve dependencies? The #r "paket: ... part.
Florian Verdonck
@nojaf
@matthid or @forki maybe?
Matthias Dittrich
@matthid
@nojaf You mean the implementation?
Matthias Dittrich
@matthid
https://github.com/fsharp/FAKE/blob/452895d8e273eb70388857b8eac32299bfe81fd6/src/app/Fake.Runtime/FakeHeader.fs#L78-L145 This is the please where we read the paket: string and then we just call a paket.core function (which is available via nuget)
There is some fiddling with creating the temporary directory, forwarding the assemblies into the proper places (compiler call and runtime resolution) but most of the info is just returned by paket
Florian Verdonck
@nojaf
Thanks, that is indeed what I'm looking for.]
Sergey Tihon
@sergey-tihon
@matthid can you please suggest the way to get process PID starting it using CreateProcess API (to be able kill exactly this process later from final Target)? https://fake.build/apidocs/v5/fake-core-createprocess.html#CreateProcess
Sergey Tihon
@sergey-tihon
or any other idea, how to start WebAPI aspnetcore server, run integration tests and then stop server\process
https://github.com/fsprojects/SwaggerProvider/blob/openapi/build.fsx#L90-L108
Matthias Dittrich
@matthid
You can use something similar to https://github.com/fsharp/FAKE/blob/master/src/app/Fake.Core.Process/CreateProcess.fs#L593-L603 but really fake should already kill processes for you (which is opt-out if I recall correctly). For aspnetcore my suggestion would be to properly shutdown (by redirecting stdin and sending "Enter" for example) and waiting for the process to exit.
Sergey Tihon
@sergey-tihon
For some reason FAKE leaves dotnet process that host my webApi (at least on macOS) =(
But you suggestion about stdin redirect seems working. thank you @matthid
https://github.com/fsprojects/SwaggerProvider/pull/117/commits/85ce80803e36b853509e8d1c2b0fcf85ec4f61ec
Matthias Dittrich
@matthid
I think reporting a bug/issue for the scenario where fake is not closing its processes would be the next step. I need an easy way to reproduce :)