Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 13 19:16

    sovelten on master

    Fix typo in cats/monad/state.cl… Update CHANGELOG.md, bump versi… Merge pull request #233 from kl… (compare)

  • Nov 13 19:16
    sovelten closed #233
  • Oct 16 10:38
    klausharbo commented #233
  • Oct 16 10:37
    klausharbo synchronize #233
  • Oct 02 20:18
    ericvm commented #233
  • Oct 02 07:18
    klausharbo opened #233
  • May 17 22:58
    mwelt commented #232
  • May 17 17:15
    mwelt commented #232
  • May 16 07:33
    alexanderjamesking commented #232
  • May 14 22:47
    mwelt opened #232
  • Apr 06 13:54

    ericvm on master

    Update fn name in docstrings: "… Merge pull request #231 from sp… (compare)

  • Apr 06 13:54
    ericvm closed #231
  • Apr 04 15:07
    spellman opened #231
  • Mar 21 17:38

    ericvm on master

    Update content.adoc Add some m… Merge pull request #228 from 57… (compare)

  • Mar 21 17:38
    ericvm closed #228
  • Mar 08 15:10
    khardenstine opened #230
  • Feb 25 11:28
    573 commented #229
  • Feb 25 11:25
    573 commented #229
  • Feb 25 11:25
    573 commented #229
  • Feb 25 10:03
    573 opened #229
Eric Bailey
@yurrriq
Even though notifications can get buried, I think it's safe to assume that at least one of us could say at least that.
It lets the contributor know that there are humans on the other end and that their contribution is not being ignored, even if it can't be properly reviewed right away.
Alejandro Gómez
@dialelo
definitely, i'll make sure to at least acknowledge when someone opens an issue or PR
Eric Bailey
@yurrriq
I feel bad that this experience has discouraged future contributions from Atamert.
But I guess all we can do is learn from it and be better in the future.
Another comment was that the delays on this PR were in stark contrast to the last several PRs.
Which maybe made it feel personal or something.
Alejandro Gómez
@dialelo
oh, sorry to read that
in my case when i make a contribution to a library is more like "fire and forget"; usually don't expect people to answer immediately
but i can relate and understand the frustration
Eric Bailey
@yurrriq
N.B. He didn't say he took it personally.
Yeah, I often feel as you do.
I still feel bad that I contributed to a bad experience though.
Alejandro Gómez
@dialelo
yeah me too, lesson learned
Eric Bailey
@yurrriq
I've had almost exclusively great experiences in OSS on the whole, and I'd love nothing more than ensure that for everyone else.
Hey, I'm curious. How far apart are we in timezones? It's nearly 4am here.
7 hours apart!
Eric Bailey
@yurrriq
Good thing I rarely sleep :)
Re: funcool/cats#148
(defn just
  "A Just type constructor.

  Without arguments it returns a Just instance
  with nil as wrapped value."
  ([]  (Just. nil))
  ([v] (Just. v)))
should (just) return #<Nothing>instead?
or should we do away with the nullary clause entirely?
Alejandro Gómez
@dialelo
i thik we should :fire: the arity 0 version, returning nothing from a Just constructor doesn't make sense to me
Eric Bailey
@yurrriq
agreed
Alejandro Gómez
@dialelo
and add a precondition to the arity 1 with the nil check, what do you think?
Eric Bailey
@yurrriq
:thumbsup:
I'm doing that now actually
Alejandro Gómez
@dialelo
awesome \o/
tests failed
ERROR in (filter-tests) (Error:NaN:NaN)
It can filter Maybe monadic values
expected: (= (maybe/just 6) (m/filter bigger-than-4 (maybe/just 6)))
  actual: #object[Error Error: Assert failed: (some? v)]
https://travis-ci.org/funcool/cats/jobs/109563622
Eric Bailey
@yurrriq
(defn guard
  [b]
  (if b
    (return nil)
    (mzero)))
With the some? precondition in maybe/just, the (return nil) in m/guard fails..
Eric Bailey
@yurrriq
maybe add a clause in Maybe's mreturn that returns #<Nothing> if (nil? v) ?
That at least makes the test fail instead of error
This message was deleted
Eric Bailey
@yurrriq
I got the tests to pass locally.
It involves rewriting #'cats.core/guard as follows:
(defn guard
  [b]
  (if b
    (return b)
    (mzero)))
i.e. (return b) instead of (return nil)
Which might be a bad idea for reason I can't think of now..
Eric Bailey
@yurrriq
I’ve made a PR (funcool/cats#149) but have to try to get some sleep now. :zzz:
Here’s to shorter response times on future issues and pull requests.
Alejandro Gómez
@dialelo
nice, i commented that we better (return true) from guard
the problem is that people may use nil-punning in b
for the record, guard is used internally by mlet's :when clauses
techla
@tech__la_twitter
?
last message from févr. 16 2016 11:49
updated now !
techla
@tech__la_twitter
any ressources for diving into category theory ?
I’m on bartosz courses but some other perspective would be great