Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 15:01
    tggreene opened #243
  • Nov 04 2020 17:34

    sovelten on master

    fix bug in implementation of for Merge pull request #242 from dc… (compare)

  • Nov 04 2020 17:34
    sovelten closed #242
  • Nov 04 2020 17:03
    dchelimsky opened #242
  • Nov 03 2020 17:28

    sovelten on master

    add cats.core/for macro bump version and update CHANGEL… Merge pull request #241 from dc… (compare)

  • Nov 03 2020 17:28
    sovelten closed #241
  • Nov 03 2020 17:05
    dchelimsky synchronize #241
  • Nov 03 2020 17:04
    dchelimsky commented #241
  • Nov 03 2020 16:29
    sovelten commented #241
  • Oct 29 2020 19:08
    dchelimsky synchronize #241
  • Oct 29 2020 19:07
    dchelimsky synchronize #241
  • Oct 29 2020 19:06
    dchelimsky synchronize #241
  • Oct 29 2020 19:01
    dchelimsky opened #241
  • Aug 15 2020 01:36
    decafbad commented #214
  • Apr 30 2020 15:07
    sovelten closed #230
  • Apr 23 2020 22:58
    piotr-yuxuan closed #239
  • Apr 23 2020 22:58
    piotr-yuxuan commented #239
  • Apr 18 2020 18:00
    piotr-yuxuan commented #239
  • Apr 18 2020 17:57
    piotr-yuxuan opened #240
  • Apr 17 2020 22:43
    piotr-yuxuan edited #239
Eric Bailey
@yurrriq
It lets the contributor know that there are humans on the other end and that their contribution is not being ignored, even if it can't be properly reviewed right away.
Alejandro Gómez
@dialelo
definitely, i'll make sure to at least acknowledge when someone opens an issue or PR
Eric Bailey
@yurrriq
I feel bad that this experience has discouraged future contributions from Atamert.
But I guess all we can do is learn from it and be better in the future.
Another comment was that the delays on this PR were in stark contrast to the last several PRs.
Which maybe made it feel personal or something.
Alejandro Gómez
@dialelo
oh, sorry to read that
in my case when i make a contribution to a library is more like "fire and forget"; usually don't expect people to answer immediately
but i can relate and understand the frustration
Eric Bailey
@yurrriq
N.B. He didn't say he took it personally.
Yeah, I often feel as you do.
I still feel bad that I contributed to a bad experience though.
Alejandro Gómez
@dialelo
yeah me too, lesson learned
Eric Bailey
@yurrriq
I've had almost exclusively great experiences in OSS on the whole, and I'd love nothing more than ensure that for everyone else.
Hey, I'm curious. How far apart are we in timezones? It's nearly 4am here.
7 hours apart!
Eric Bailey
@yurrriq
Good thing I rarely sleep :)
Re: funcool/cats#148
(defn just
  "A Just type constructor.

  Without arguments it returns a Just instance
  with nil as wrapped value."
  ([]  (Just. nil))
  ([v] (Just. v)))
should (just) return #<Nothing>instead?
or should we do away with the nullary clause entirely?
Alejandro Gómez
@dialelo
i thik we should :fire: the arity 0 version, returning nothing from a Just constructor doesn't make sense to me
Eric Bailey
@yurrriq
agreed
Alejandro Gómez
@dialelo
and add a precondition to the arity 1 with the nil check, what do you think?
Eric Bailey
@yurrriq
:thumbsup:
I'm doing that now actually
Alejandro Gómez
@dialelo
awesome \o/
tests failed
ERROR in (filter-tests) (Error:NaN:NaN)
It can filter Maybe monadic values
expected: (= (maybe/just 6) (m/filter bigger-than-4 (maybe/just 6)))
  actual: #object[Error Error: Assert failed: (some? v)]
https://travis-ci.org/funcool/cats/jobs/109563622
Eric Bailey
@yurrriq
(defn guard
  [b]
  (if b
    (return nil)
    (mzero)))
With the some? precondition in maybe/just, the (return nil) in m/guard fails..
Eric Bailey
@yurrriq
maybe add a clause in Maybe's mreturn that returns #<Nothing> if (nil? v) ?
That at least makes the test fail instead of error
This message was deleted
Eric Bailey
@yurrriq
I got the tests to pass locally.
It involves rewriting #'cats.core/guard as follows:
(defn guard
  [b]
  (if b
    (return b)
    (mzero)))
i.e. (return b) instead of (return nil)
Which might be a bad idea for reason I can't think of now..
Eric Bailey
@yurrriq
I’ve made a PR (funcool/cats#149) but have to try to get some sleep now. :zzz:
Here’s to shorter response times on future issues and pull requests.
Alejandro Gómez
@dialelo
nice, i commented that we better (return true) from guard
the problem is that people may use nil-punning in b
for the record, guard is used internally by mlet's :when clauses
techla
@tech__la_twitter
?
last message from févr. 16 2016 11:49
updated now !
techla
@tech__la_twitter
any ressources for diving into category theory ?
I’m on bartosz courses but some other perspective would be great
farismn
@farismn
Are there any projects that heavily uses this library?