Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 18:11
    vegarringdal synchronize #1588
  • 18:06
    vegarringdal synchronize #1588
  • 17:53
    vegarringdal opened #1588
  • 15:40
    codecov[bot] commented #1488
  • 15:40
    codecov[bot] commented #1488
  • 15:38
    codecov[bot] commented #1488
  • 15:38
    codecov[bot] commented #1488
  • 15:38
    nchanged synchronize #1488
  • 15:38

    nchanged on v4

    feat: updated meriyah@1.6.10 (compare)

  • 15:29
    codecov[bot] commented #1488
  • 15:29
    codecov[bot] commented #1488
  • 15:27
    codecov[bot] commented #1488
  • 15:27
    codecov[bot] commented #1488
  • 15:26
    nchanged synchronize #1488
  • 15:26

    nchanged on v4

    feat: dependencies ignore 4.0.0… (compare)

  • 01:45
    kyr0 opened #1587
  • Aug 21 19:40
    CHNB128 starred fuse-box/fuse-box
  • Aug 21 19:04
    codecov[bot] commented #1488
  • Aug 21 19:04
    codecov[bot] commented #1488
  • Aug 21 18:59
    codecov[bot] commented #1488
nchanged
@nchanged
otherwise it's confusing
Vegar Ringdal
@vegarringdal
yes, but looks that isnt happending, is there any logging I can activate to see where its trying to get resource ?
nchanged
@nchanged
can you check out the playground?
just copy the files
it's working fine there
Vegar Ringdal
@vegarringdal
yes, Ill do that tomorrow and add more folders etc, so I get what Im trying to do, then you can tell me what Im doing wrong :-)
Vegar Ringdal
@vegarringdal
hmm, not to my slef for later
{

    "compilerOptions": {
        "rootDir": "./src",
        "baseUrl": "./",
        "paths": {
            "@lit-html-free*": ["../../packages"]
        }
    },
    "include": ["src"]
}
nchanged
@nchanged
rootDir has not effect
Vegar Ringdal
@vegarringdal
that part works..
hmm, maybe Im getting tricked by cache
nchanged
@nchanged
That too )
disable it
Vegar Ringdal
@vegarringdal

just did, and deleted folder

fails

{
    "extends": "../../tsconfig.json",
    "compilerOptions": {
        "baseUrl": "./",
        "paths": {
            "@lit-html-free*": ["../../packages"]
        }
    }
}

works:

{
    "compilerOptions": {
        "baseUrl": "./",
        "paths": {
            "@lit-html-free*": ["../../packages"]
        }
    }
}

its like the extends messes up with it path, but not cloned fusebox, so cant really check in a good way

this works.., might be how it uses the extended
{
    "extends": "./tsconfig copy.json",
    "compilerOptions": {
        "baseUrl": "./",
        "paths": {
            "@lit-html-free*": ["../../packages"]
        }
    }
}
will be easier to test in fusebox source tomorrow
Vegar Ringdal
@vegarringdal

https://github.com/fuse-box/fuse-box/blob/v4/src/tsconfig/configParser.ts#L94
https://github.com/fuse-box/fuse-box/blob/v4/src/tsconfig/configParser.ts#L128

These will mess up I think
say we have c:/root with tsconfig with just compiler option/ no baseurl/paths
Then in c:/root/project we have a new tsconfig with baseUrl ./ that extends ../tsconfig
then baseURL: path.resolve(basePath, userOptions.baseUrl),``will set base url toc:/and notC:/root`

just tried this, and it works
{
    "extends": "../../tsconfig.json",
    "compilerOptions": {
        "baseUrl": "./samples/realworld-sample",
        "paths": {
            "@lit-html-free*": ["../../packages"]
        }
    }
}
well, time for bed..
Aron Homberg
@kyr0
@vegarringdal btw, w3c/webcomponents#829, let's see...
Aron Homberg
@kyr0

@nchanged Regarding ICT, we're using strings everywhere (e.g sync('bundle_resolve_module'). They are typed as K extends keyof T (InterceptorEvents) but eventually they are strings.

There is a way to use an enum in combination with interfaces to get rid of strings here:

export enum InterceptorLifecycleEvents {

    /**
      * Some description about the runtime behaviour (when does this happen, how often etc.)
      */
    bundle_resolve_module = 'bundle_resolve_module'
}

export interface InterceptorEvents {

    ....
     [InterceptorLifecycleEvents.bundle_resolve_module]: { module: Module };
    ...
}

So the code in plugins would look like:

ctx.ict.on(InterceptorLifecycleEvents.bundle_resolve_module, ...)

And in the core maybe:

 .sync(InterceptorLifecycleEvents.bundle_resolve_module, ...) 

as well.

So we'd get rid of many duplicated definitions of implicit strings in the code and could provide inline documentation for each event that can be shown by the IDE too.

Aron Homberg
@kyr0
@nchanged Also, https://github.com/fuse-box/fuse-box/blob/v4/src/interceptor/interceptor.ts#L26
These functions are this-context free. Can they be defined as fat arrow functions? Also, https://github.com/fuse-box/fuse-box/blob/v4/src/interceptor/interceptor.ts#L15 could lead to a re-declaration of the function by the JIT each time createInterceptor() gets called. Could we move this function out by providing subscriptions as the third argument by reference?
In case you'd like this, I can PR
Aron Homberg
@kyr0
@nchanged https://github.com/fuse-box/fuse-box/blob/v4/src/transform/tsTransform.ts#L42 Could we make two transformers? One for replacements, one for webworkers? I think we could get rid of the extra complexity and have a more clear separation of concerns that way?
Patrick Michalina
@patrickmichalina
@nchanged does dependencies: { ignore: [] } work?
I am getting a bundling error on the node side
assemble package domino:2.1.3ParseError [SyntaxError]: [10:9]: Strict mode code may not include a with statement at report (/Code/fuse-alpha/node_modules/meriyah/dist/meriyah.umd.js:352:13)
Aron Homberg
@kyr0
@patrickmichalina I have no clue, but probably the generated code contains "use strict" somewhere. I would check the config and fuse-box source code for "use strict" to track down where this origins
Patrick Michalina
@patrickmichalina
Ideally this would NOT be bundled
ignore: [] mightnot be working tho
Josh Pike
@jpike88
@nchanged latest fusebox is dumping a tsconfig object to console as it builds
also, tomorrow, me and my devs will help do some documentation
Josh Pike
@jpike88
also, source maps got broken
I upgraded from 61 to 75
downgrading to 61 for now
or should I fix my source map resolution
?
nchanged
@nchanged
@patrickmichalina ignore doesn't work yet, sorry
@kyr0 wow, thanks!
@jpike88 how are they broken? the only thing was changed is the veritual path of the sourcemaps
nchanged
@nchanged
@jpike88 could you reproduce it?
@patrickmichalina I will get it fixed soon. Sorry way too many things in the pipeline
@kyr0 I agree, it could be done this way too
nchanged
@nchanged
ict.gif
But VSCode has no issues suggesting it ;-) just type in ""
Vegar Ringdal
@vegarringdal

@vegarringdal btw, w3c/webcomponents#829, let's see...

@kyr0 :thumbsup:

Patrick Michalina
@patrickmichalina
@nchanged ok awesome thanks.
nchanged
@nchanged
@patrickmichalina fuse-box@4.0.0-alpha.76
nchanged
@nchanged
@kyr0 and regarding the transformers I agree, could be split. More over I think we need to have only one function tsTransform that is used in both dev and prod