These are chat archives for gabrielbull/php-ups-api

25th
Sep 2015
Stefan Doorn
@stefandoorn
Sep 25 2015 10:12
I did some local testing, looks good. If @gabrielbull agrees, we can tag a new version I think as it has quite some changes by now
Eduard Sukharev
@eduard-sukharev
Sep 25 2015 11:20
sounds good
Gabriel Bull
@gabrielbull
Sep 25 2015 13:56
:+1: you guys are doing awesome work!
Stefan Doorn
@stefandoorn
Sep 25 2015 14:17
@eduard-sukharev did you see my comment at #58 ?
Eduard Sukharev
@eduard-sukharev
Sep 25 2015 16:41
@stefandoorn yes, I did. my only concern was about "reusing" the request object when one may just replace shipFrom field with null value
otoh, it seems that you're right
let me fix it
and since it's already a weekend, the absinth is speaking here, so please, be careful to reread the PR after fix :)
Eduard Sukharev
@eduard-sukharev
Sep 25 2015 16:49
ok, done fixing. please, review carefully. even though it's about really minor fix, i can't trust myself now