These are chat archives for gabrielbull/php-ups-api

27th
Oct 2015
Eduard Sukharev
@eduard-sukharev
Oct 27 2015 08:56
@stefandoorn i believe @rafacuest used some other solution, not php-ups-api library. But yes, it'd be great if he contributed hist code as PR :)
Stefan Doorn
@stefandoorn
Oct 27 2015 10:39
I see a pull request, but the tests are failing at the moment
Rafa
@rafacuest
Oct 27 2015 11:54
Sorry guys I am not able to pass the validations, i'm not used to work with Travis
Eduard Sukharev
@eduard-sukharev
Oct 27 2015 11:55
there seem to be last CI error, at least
and as noted by @stefandoorn - use "Detail" link for more information on how to resolve the issue. And try to run phpunit tests locally on your dev environment
Stefan Doorn
@stefandoorn
Oct 27 2015 12:59
@rafacuest That aint a problem. What it mainly shows is that something in the current implementation got broken by a change. The current implementation should stay working unchanged, the new function can be next to it and should not result in an error as there are also no tests for it. Would be best ofcourse to write also a test for it, but thats second thing.