Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jan 31 2019 17:58
    jorgemachucav starred galaxyproject/tools-iuc
  • Jan 31 2019 17:45
    bebatut opened #2270
  • Jan 31 2019 16:18
    cpreviti synchronize #2267
  • Jan 31 2019 14:15
    cpreviti synchronize #2267
  • Jan 31 2019 12:42
    bernt-matthias review_requested #2269
  • Jan 31 2019 12:42
    bernt-matthias edited #2269
  • Jan 31 2019 12:41
    bernt-matthias edited #2269
  • Jan 31 2019 12:40
    bernt-matthias synchronize #2269
  • Jan 31 2019 12:13
    cpreviti commented #2267
  • Jan 31 2019 12:07
    nsoranzo commented #2267
  • Jan 31 2019 12:01
    cpreviti synchronize #2267
  • Jan 31 2019 11:21
    cpreviti synchronize #2267
  • Jan 31 2019 09:47
    cpreviti synchronize #2267
  • Jan 31 2019 09:27
    cpreviti synchronize #2267
  • Jan 30 2019 20:38
    bernt-matthias commented #2131
  • Jan 30 2019 20:19
    hepcat72 commented #2239
  • Jan 30 2019 19:50
    lparsons commented #2239
  • Jan 30 2019 18:36
    bgruening commented #2268
  • Jan 30 2019 15:23
    nsoranzo commented #2268
  • Jan 30 2019 15:23
    nsoranzo commented #2267
M Bernt
@bernt-matthias
@bwlang do you have the path to the tool? is this bedtools?
Brad Langhorst
@bwlang
@bernt-matthias yeah bedtools… new versions just work on bam files and don’t seem to care about this. The version I’m working with needed a “genome file” which seems to trigger by magic a requirement that the genome be specified on the bam.
M Bernt
@bernt-matthias
this was apparently changed here: galaxyproject/tools-iuc#884 ... before the input had a validator for a genome build which seemingly never has been used.

https://github.com/nsoranzo/tools-iuc/blob/04359a78f47f695575b3a06379a5e1ed031fa045/tools/bedtools/genomeCoverageBed.xml#L46

so if you want to stick to this tool version I guess you need to set the build. But for this tool any value should be OK.

Nicola Soranzo
@nsoranzo
So did I fix it or break it? :laughing:
M Bernt
@bernt-matthias
You fixed it :)
Nicola Soranzo
@nsoranzo
Good!
Brad Langhorst
@bwlang
@bernt-matthias i just upgraded the tool.. .not sure how this ever worked. Thanks!
Brad Langhorst
@bwlang
Anybody else seeing workflows hiding failing steps? Is this a new feature ?
Marius van den Beek
@mvdbeek
for mapped over datasets in a collection ?
if datasets are in a collection we don't unhide each individual member anymore, that's new, yes
Brad Langhorst
@bwlang
@mvdbeek it’s not so great that a history looks all green if there are hidden failed steps. Should I open an issue about this?
Marius van den Beek
@mvdbeek
Sure
M Bernt
@bernt-matthias
hi all. data manager question here: few data managers allow to integrate data from the file system (e.g data_manager_manual and data_manager_mothur ... I'm working on the later). Wondering how to test this, or if we should force the admins to go the detour over the library?
M Bernt
@bernt-matthias

another one: apparently nowadays 3 columns should be available in a tool data table: value, path, and name. For older tools (e.g. mothur again) this seems sometimes not to be the case. For mothur I have now 3 columns id, path, type (last one just added). What would be the best strategy to update the tool?

  • do I need to add tool_data_table_conf.xml.oldlocstyle?
  • is it possible to test this?

Furthermore, what would be the best strategy to add a column (for mothur aligndb I just added the 3rd column)?

Nicola Soranzo
@nsoranzo
There is no standard set of columns for data tables, they are often tool-specific. If you need to add columns to a data table, unfortunately you need to create a new data table.
M Bernt
@bernt-matthias

@nsoranzo : thanks for the answer: I was just reading at https://galaxyproject.org/admin/tools/data-tables/ that "value, path, and name should all be included". Also: Why do I need to create a new data table? Can't I just add a column?

Also wondering why this https://github.com/galaxyproject/tools-iuc/blob/60e2302cfac90d0c909ef61815aaaafaaad5816a/tools/mothur/align.seqs.xml#L17 works. I would have expected something like reference.fields.... in the case of cached reference data.

Nicola Soranzo
@nsoranzo
If you add a column, how would new versions of the tool work on old table entries missing the new required column? There is no migration path for existing data tables.
M Bernt
@bernt-matthias
True. But, it seems that the tool still has data tables of the old style ... maybe they should be upgraded anyway .. procedures could be described
Dan Fornika
@dfornika
There seem to be a few remaining issues with the snippy tool that prevent asnippy -> snippy-core pipeline from working. I've filed an issue here: galaxyproject/tools-iuc#2451
...and I'm working on a fix here: galaxyproject/tools-iuc#2452
M Bernt
@bernt-matthias
I guess stacks2 is ready for review: galaxyproject/tools-iuc#2085
Yvan Le Bras
@yvanlebras
Thank you Mathias!
Jennifer Hillman-Jackson
@jennaj
gentle ping for IUC & annotatemyids tool. Know most are very busy with GCC prep. but any help/feedback, even if just some type of acknowledgement (a tool update ticket?), would be nice. https://help.galaxyproject.org/t/annotating-gene-ids-local-deseq2-rats-annotatemyids/1327/9
@bgruening you replied to that ^^ originally and updated EU server to test out addition of the rat id lookup. am sure you are personally swamped. though maybe someone else could help out...
If you want me to make a ticket, lmk, can do that and give it back to the user. But I wouldn't know how to help them update outside of the MTS... would need someone else to help with that part (assume is possible :)
Alex Ostrovsky
@astrovsky01
Does anyone know why, on a text input that is optional with a default value, leaving the box blank results in the interpreter reading '' as the text instead of the default?
Nicola Soranzo
@nsoranzo
If there is a default, the box should not be empty when the tool is loaded. If you delete the value, then obviously "" is what gets submitted.
mblue9
@mblue9
@jennaj I've replied in that thread
Alex Ostrovsky
@astrovsky01
@nsoranzo the default isn't loading in the box. I restarted both the tool screen and galaxy, and it remains empty
<param name="name" type="text" optional="true" default="galaxy_seurat" label="Optional name of the experiment for Seurat" help="Default name is galaxy_seurat"/>
Alex Ostrovsky
@astrovsky01
I caught it, "value" vs "default"
Nicola Soranzo
@nsoranzo
@astrovsky01 Yep, that's it
John Chilton
@jmchilton
http://images.galaxyproject.org/planemo/latest.ova I published what I think will become the GCC image for the tool dev workshop. I don't know how realistic VMs are in an hour and half long training though
I'll make sure these land up on USB sticks
Dan Fornika
@dfornika
@pvanheus Could you take a look at my proposed fix for galaxyproject/tools-iuc#2451 when you have a chance? Pull request is here: galaxyproject/tools-iuc#2452
Dan Fornika
@dfornika
pvanheus
@pvanheus
@dfornika I'm trying to understand the error - in the current design snippy-core takes zip input but it should take tar.gz input? and then you have simplified the mapping from tar.gz to directories?
Dan Fornika
@dfornika
I think I may have misunderstood the error when I started working on my fix, so I've probably changed a bit more than strictly necessary. If you look at the command-line generated for snippy-corethat I've included in the issue, the arguments for snippy-core aren't quoted (except for the --ref file).
mkdir 'snippy on data 2, data 1, and data 8 dir for snippy core' && 
tar -xf '/export/galaxy-central/database/files/000/dataset_587.dat' -C 'snippy on data 2, data 1, and data 8 dir for snippy core' --strip-components=1 &&
mkdir 'snippy on data 5, data 3, and data 8 dir for snippy core' && 
tar -xf '/export/galaxy-central/database/files/000/dataset_590.dat' -C 'snippy on data 5, data 3, and data 8 dir for snippy core' --strip-components=1 && 
mkdir 'snippy on data 4, data 6, and data 8 dir for snippy core' && 
tar -xf '/export/galaxy-central/database/files/000/dataset_593.dat' -C 'snippy on data 4, data 6, and data 8 dir for snippy core' --strip-components=1 && 
snippy-core --ref '/export/galaxy-central/database/files/000/dataset_563.dat' snippy on data 2, data 1, and data 8 dir for snippy core snippy on data 5, data 3, and data 8 dir for snippy core snippy on data 4, data 6, and data 8 dir for snippy core
...so I think that was the cause of the error, because the error message is:
Fatal error: Exit code 2 ()
This is snippy-core 4.3.6
Obtained from http://github.com/tseemann/snippy
Enabling bundled tools.
Found any2fasta - /export/tool_deps/_conda/envs/__snippy@4.3.6/binaries/noarch/any2fasta
Found samtools - /export/tool_deps/_conda/envs/__snippy@4.3.6/bin/samtools
Found minimap2 - /export/tool_deps/_conda/envs/__snippy@4.3.6/bin/minimap2
Found bedtools - /export/tool_deps/_conda/envs/__snippy@4.3.6/bin/bedtools
Found snp-sites - /export/tool_deps/_conda/envs/__snippy@4.3.6/bin/snp-sites
Saving reference FASTA: core.ref.fa
This is any2fasta 0.4.2
Opening '/export/galaxy-central/database/files/000/dataset_563.dat'
Detected FASTA format
Read 20520 lines from '/export/galaxy-central/database/files/000/dataset_563.dat'
Wrote 1 sequences from FASTA file.
Processed 1 files.
Done.
Loaded 1 sequences totalling 1641481 bp.
Will mask 0 regions totalling 0 bp ~ 0.00%
ERROR: Sample 'snippy' is not a folder, seems to be a file?
Dan Fornika
@dfornika
But it seems a bit strange to be creating those directories called 'snippy on data 2, data 1, and data 8 dir for snippy core' etc. I noticed that the snippy tool already creates a .tar.gz file that contains a snippy results directory that is named with the sample name. So it seems to me that we just need to extract those into the working directory and pass them to snippy-core. It seems unnecessary to create new directories in the snippy-core tool to extract into.
pvanheus
@pvanheus
ah I understand now.
Dan Fornika
@dfornika
I'm not completely certain how snippy-core gets the sample ID, but I wanted to find a way that the sample IDs would get passed into the snippy-core output appropriately. This method seems to work because the extracted snippy output directories are named with the sample ID.
I think the issue with the snippy-core input directories not being quoted is still unresolved in PR: https://github.com/galaxyproject/tools-iuc/pull/2452/files#r296449599
pvanheus
@pvanheus
@dfornika yes it is and I cannot quite understand how to resolve it. I'm experimenting a bit my side, but my version of snippy creates ZIP files not TAR files.
Lance Parsons
@lparsons
Does anyone know why the Salmon option is commented out in the MultiQC tool? I'm assuming something doesn't work, but curious if anyone knows more as I'd like to get this working. https://github.com/galaxyproject/tools-iuc/blob/master/tools/multiqc/multiqc.xml#L540
Dan Fornika
@dfornika
@pvanheus The .tar.gz files that I was referring to are created by the snippy tool wrapper here: https://github.com/galaxyproject/tools-iuc/blob/6afb87d2f226ac2fb61255b89dd9c36940b482c9/tools/snippy/snippy.xml#L66
pvanheus
@pvanheus
@dfornika and yet it is labelled format="zip". ah, there is no ".tar.gz" type. Anyway I made a comment on the PR.
Slugger70
@Slugger70
@dfornika I made a different PR that will add quotes to the names of the directories. I think this is what the problem was. Torsten's software doesn't like spaces in file names and it sends up a warning now but runs. Have a look and see what you think.