Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Nicola Soranzo
    @nsoranzo
    @mvdbeek I've added a comment on the PR, I can rebase with your changes if you agree
    Marius van den Beek
    @mvdbeek
    I think the ToolTestDescription is being used in the ToolTestBuilder, so maybe we should keep it there ?
    I think it's also part of the API
    there's no such thing as ToolTestBuilder, that just looked like a class in https://github.com/galaxyproject/galaxy/blob/418f1220c8f6b21bcf3b4ddcf9d19f29bdb2c373/lib/galaxy/tools/test.py#L24 ...
    Nicola Soranzo
    @nsoranzo
    Just fixed that locally after you mentioned it!
    ToolTestDescription is not used in planemo, anything else we should care about?
    Marius van den Beek
    @mvdbeek
    https://github.com/galaxyproject/galaxy/blob/2b6c0d6b300f3dbbff99401c7ff30972c1290021/lib/galaxy/webapps/galaxy/api/tools.py#L214 -- though the description says it's unstable and dev, so I guess we could do that
    do you know how the tool describing tours work, do they consume maxseconds ? probably not
    it's also part of the xsd:
        <xs:attribute name="maxseconds" type="xs:integer">
      <xs:annotation>
        <xs:documentation xml:lang="en">Maximum amount of time to let test run.</xs:documentation>
      </xs:annotation>
    hmm, now I'm less certain we should ignore it ...
    just seems weird to even annotate a test with this
    Nicola Soranzo
    @nsoranzo
    It comes from galaxyproject/galaxy@d210212
    So leave it as in my last commit?
    Marius van den Beek
    @mvdbeek
    :+1:
    ok, so ... how do we get this into a galaxy-lib pypi release now ? :laughing:
    is it still the old way ?
    Nicola Soranzo
    @nsoranzo
    I think @jmchilton 's idea is to have a galaxy_tool_util package out soon, and use that for the next Planemo release
    John Chilton
    @jmchilton
    Pulsar is already on dev releases of galaxy-tool-util - Planemo could probably head that directon
    I think I've basically decided to dev releases of 19.9 packages until we actually branch 19.09 and then do a real release. The dev releases don't seem to have any downsides though
    Nicola Soranzo
    @nsoranzo
    Merging galaxy dev branch into galaxy-lib is going to be very messy, probably not worth the effort.
    Marius van den Beek
    @mvdbeek
    for that PR it should be straightforward, it was targeting 19.05
    Nate Coraor
    @natefoo
    Anyone else seeing https://gist.github.com/natefoo/c45406e96c2f882ccb58adf4f664da04 on dev with py3?
    Nate Coraor
    @natefoo
    compiled templates, duh
    Nicola Soranzo
    @nsoranzo
    Forgot to clean them?
    Jennifer Hillman-Jackson
    @jennaj
    This user at Galaxy help really needs help. Would someone please assist? https://help.galaxyproject.org/t/galaxy-19-01-apache-proxy-problem-each-action-leads-to-the-welcome-page/1394
    Nate Coraor
    @natefoo
    @nsoranzo yeah
    Nicola Soranzo
    @nsoranzo
    Cool, one bug less!
    Nate Coraor
    @natefoo
    Yep :smile:
    Mason
    @Nerdinacan
    Is there a handy guide to debugging practices for the server side code somewhere? You guys use pdb? or have an IDE that makes breakpoints easy to set?
    Marius van den Beek
    @mvdbeek
    Both pycharm and visual studio code are great for debugging purposes
    You can run the server or whatever test you entirely in there
    only caveat is that I haven't figured out how to use this with galaxy.yml yet, so you need the old galaxy.ini for that
    Mason
    @Nerdinacan
    Ok I’ll try wiring that up, thanks
    Marius van den Beek
    @mvdbeek
    https://github.com/galaxyproject/galaxy/issues/8052#issuecomment-496934392 is the core of the settings for pycharm
    Nicola Soranzo
    @nsoranzo
    @Nerdinacan Thanks for volunteering, you can then place it in https://github.com/galaxyproject/galaxy/tree/dev/doc/source/dev
    I still have to try with VS Code
    Marius van den Beek
    @mvdbeek
    I had the VS code settings at one point, but can't find em anymore :(
    Mason
    @Nerdinacan
    Heh. I’m the wrong guy to provide advice on this issue. I haven’t worked in python for years.
    I’m still rusty
    Marius van den Beek
    @mvdbeek
    wasn't hard though, the default debugger was too slow so at the time I used an epxerimental debugger
    Nicola Soranzo
    @nsoranzo

    This is what I saved from previous conversations:

    Debugging Galaxy in PyCharm: Add a new configuration in pycharm, select scripts/paster.py as script, add the python interpreter in galaxy's venv and use "serve galaxy.ini" as script parameters.

    Debugging Galaxy in vscode: to debug API tests, add something like

            {
            "name": "Galaxy debug API tests",
            "type": "pythonExperimental",
            "request": "launch",
            "program": "${workspaceFolder}/.venv/bin/pytest",
            "args": ["-v", "test/api", "-k", "test_workflow_rerun_with_use_cached_job"],
            "envFile": "${workspaceFolder}/env_vars.txt",
            "console": "integratedTerminal"
        },

    to launch.json

    Marius van den Beek
    @mvdbeek
    yep
    that's it, thanks @nsoranzo
    Mason
    @Nerdinacan
    Thanks @nsoranzo I’ll see if I can get that flying
    Nicola Soranzo
    @nsoranzo
    What are you using as IDE?
    Mason
    @Nerdinacan
    I got vs code, but I’m not against installing a new one if it means I don’t have to start/stop the server
    Nicola Soranzo
    @nsoranzo
    VS Code works pretty well for me (and I'm not an IDE person)
    Marius van den Beek
    @mvdbeek
    I think there's no way around start/stop or full reload on code change
    Mason
    @Nerdinacan
    I guess I said that poorly. I’ll do anything that doesn’t make me rely on print statements and give me an actual breakpoint. :)
    Marius van den Beek
    @mvdbeek
    oh yeah, both will do :D