Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Marius
    @mvdbeek:matrix.org
    [m]
    Seems to be an error already ?
    dannon
    @dannon:matrix.org
    [m]
    Oh, duh. Yeah, we're good to go then.
    Anyone against me swapping it for attr order, since it's easily automatable and fixable? Might as well just catch these on the way in.
    Marius
    @mvdbeek:matrix.org
    [m]
    Ah, there is a legit one in workflow-graph.vue, but I think this might be a clash between a ref and a component
    /Users/mvandenb/src/workflow_editor/client/src/components/Workflow/Editor/WorkflowGraph.vue
       10:35  warning  Attribute "id" should go before "ref"         vue/attributes-order
       23:25  warning  Attribute ':activeNodeId' must be hyphenated  vue/attribute-hyphenation
       52:8   error    'D3Zoom' is defined but never used            no-unused-vars
       56:7   error    'props' is assigned a value but never used    no-unused-vars
      116:10  error    'onDeactivate' is defined but never used      no-unused-vars
    d3-zoom is used in the template, but there's also a d3Zoom ref
    yep, renaming the ref fixed it
    Sam
    @guerler:matrix.org
    [m]
    Ran into: error ts-jest@29.0.3: The engine "node" is incompatible with this module. Expected version "^14.15.0 || ^16.10.0 || >=18.0.0". Got "17.0.0"
    dannon
    @dannon:matrix.org
    [m]
    How did you get a node 17?
    Sam
    @guerler:matrix.org
    [m]
    I will upgrade it, maybe its just outdated.
    davel0pez
    @davel0pez:matrix.org
    [m]
    What is the recommended/easiest way of simulating an error in a collection? I'm asking for galaxyproject/galaxy#14980
    should be loaded from test/functional/tools/samples_tool_conf.xml
    set failbool to true
    davelopez (David López)
    @davel0pez:matrix.org
    [m]
    cool! Thank you Marius!
    both should have an option to see the job details page
    Marius
    @mvdbeek:matrix.org
    [m]

    Does CHANGE_ORIGIN=true GALAXY_URL="http://localhost:8000/" yarn run serve work correctly on dev ? Getting:

    [webpack-dev-server] [HPM] Error occurred while proxying request 127.0.0.1:8081/history/current_history_json?since=2022-11-20T14:17:21.654368 to http://localhost:8000/ [ECONNREFUSED] (https://nodejs.org/api/errors.html#errors_common_system_errors)

    and it's not obvious why that request would fail, http://localhost:8000/ works fine in the browser

    John Davis
    @ic4f:matrix.org
    [m]
    i see the same error. yarn run serve
    Marius
    @mvdbeek:matrix.org
    [m]
    is it possible that you can only drag elements that have the :active css class / that dragging is prevented when another element has :active ?
    1 reply
    I haven't read anything confirming or denying it, but the workflow editor sets this programmatically, and I need to set it on every node if I want to be able to drag the output without clicking on the node first
    Marius
    @mvdbeek:matrix.org
    [m]
    I know the classes I'm dealing with, it's just that the dragstart handler in the source and the dragenter on the target don't fire if active is not set on the source
    which seems weird, but maybe we're not supposed to set active ourselves?
    Sam
    @guerler:matrix.org
    [m]
    Generally, i would assume that we should be able to condition the drag and drop if we want to and have a clear concept.
    Marius
    @mvdbeek:matrix.org
    [m]
    ok, getting closer, the z-index on the node needs to be higher than 100 to be a able to drag ...
    I assume the fix in that commit was to decreae the z-index from 1500, which interfered with the dropdown, so I guess this won't be breaking anything ?
    Marius
    @mvdbeek:matrix.org
    [m]
    Alright, I managed to get the webpack devserver to work again ... there's a bug with dns resolution in node 18, where it returns the ipv6 address first, and the default uvicorn setup only exposes ipv4
    so, change the bind to :: instead of localhost and uvicorn will accept both ipv4 and ipv6 connections
    if it's not a bug in node it's certainly a major breaking change, and the error message is quite bad too, if it included the resolved address it would have been super obvious what happened
    John Davis
    @ic4f:matrix.org
    [m]
    another client linting error (in case no one has spotted it already). https://app.circleci.com/pipelines/github/galaxyproject/galaxy/27558/workflows/9592a394-a7ef-4e65-8835-938ee59a23ce/jobs/184395?invite=true#step-104-160 Caused by this galaxyproject/galaxy#15040 : the code refers to backboneRoute in History/Content/ContentItem.vue; the import is present in the PR branch; however in dev that import was removed in July (see galaxyproject/galaxy#13984).
    Nicola Soranzo
    @nsoranzo:matrix.org
    [m]
    Ouch, that's probably me merging it forward, sorry!
    I did test on my fork, but CircleCI tests are not run on branches, only PRs.
    Should we move these to GitHub workflows as well?
    dannon
    @dannon:matrix.org
    [m]
    Yeah no big deal. Definitely just the merge forward and we have slightly more restrictive linting in dev now
    martenson
    @martenson:matrix.org
    [m]
    can I get review :eyes: on galaxyproject/galaxy#14865 please?
    Marius
    @mvdbeek:matrix.org
    [m]
    Is it a known gotcha that https://pinia.vuejs.org/core-concepts/getters.html#passing-arguments-to-getters loses reactivity (at least when used in setup) ? Doing the same with mapState works just fine
        setup(props) {
            const connectionStore = useConnectionStore();
            return {getOutputTerminalsForInputTerminal: store.getOutputTerminalsForInputTerminal}
        },
    would be the minimal case ... seems like that should just work?!
    Michelle Savage
    @michellesavage:matrix.org
    [m]
    Hello, I will miss today's ui/ux meeting due to scheduling conflict. My update as follows: reviewing comments on my PRs today to: change or request more info for Reviewers. Please feel free to assign me any relevant tickets.
    dannon
    @dannon:matrix.org
    [m]
    sec
    Sam
    @guerler:matrix.org
    [m]
    Can we reduce the icon bundles to a subset?
    Laila Los
    @electronic_blueberry:matrix.org
    [m]
    the compressed svg paths are ~2mb in size for all the bundles. the otf files ~1.7mb.
    I'm not sure which of those the scss imports use, but the size should roughly be around that.
    dannon
    @dannon:matrix.org
    [m]
    Probably the otfs, which we'd like to eliminate shipping completely.
    Sam
    @guerler:matrix.org
    [m]
    Thanks for the discussion on the side panel topic today. I’ll summarize it and comment on the draft later.
    Sam
    @guerler:matrix.org
    [m]
    Is the blue highlighting of the dataset intentional?