These are chat archives for gantry/gantry4

31st
Mar 2016
Walt Sorensen
@photodude
Mar 31 2016 16:44
@mahagr Versions is handled in the checkBrowser() method. Since that method is pulling from the user agent it should not be effecting the browser version detection.
The changes I suggested for the checkBrowser() method adds detection for Edge and fixes some issues like links coming from Office documents.
Walt Sorensen
@photodude
Mar 31 2016 16:52
@mahagr here is a gist with all the suggestions for the gantrybrowser.class.php file.
https://gist.github.com/photodude/a218a8018cb2e576336468c602441c79
Matias Griese
@mahagr
Mar 31 2016 17:17
i've already made updates for what you posted before
there's one change in your stuff, tho, it made ipod separate from iphone
which is probably ok
looking if you have additional changes to what i already applied.. sec
Matias Griese
@mahagr
Mar 31 2016 17:23
@photodude there's some bad code in your file, namely line 178 and 197
missing explode i think...
also 158
Matias Griese
@mahagr
Mar 31 2016 17:29
yeah, that stuff doesn't work
will let you to fix it ;)
Walt Sorensen
@photodude
Mar 31 2016 17:37
Fixed as suggested... I don't think I've ever seen anything actually hit those elseif items (not that, that is any excuse for overlooking a needed $version = explode(' ', $result[1]);)
Matias Griese
@mahagr
Mar 31 2016 17:39
cool, taking another look
you have this in live site?
Walt Sorensen
@photodude
Mar 31 2016 17:41
Several
Matias Griese
@mahagr
Mar 31 2016 17:41
well, maybe i'll just trust your changes enough to commit them.. just a quick look
yea, cannot see anything else obvious
if you have some other changes which you would like to share, be free :)
we are going to release new version in few days
Walt Sorensen
@photodude
Mar 31 2016 17:43
here is a live demo that's still in development
http://research-oem.jtechmedical.com/paradigm/
Matias Griese
@mahagr
Mar 31 2016 17:54
cool
have you tried gantry5 yet?
btw, i just committed your change for next version
Walt Sorensen
@photodude
Mar 31 2016 17:57
Thanks @mahagr
Looking at some past suggestions, There is an issue needing to be addressed relating to Undefined index: HTTP_USER_AGENT I'll update the gist with the fix I suggested in 2014
$this->user_agent = isset($_SERVER['HTTP_USER_AGENT']) ? $_SERVER['HTTP_USER_AGENT'] : "undefined";
Matias Griese
@mahagr
Mar 31 2016 17:58
good point
Walt Sorensen
@photodude
Mar 31 2016 17:58
Updated
Matias Griese
@mahagr
Mar 31 2016 18:00
changed that to unknown
Matias Griese
@mahagr
Mar 31 2016 18:06
updated that too
Walt Sorensen
@photodude
Mar 31 2016 18:10
@mahagr I've got one site running G5, I still prefer G4 and the G4 template designs. Personally I would love to see G5 equivalents to a few older designs (Clarion, Paradigm, Anacron, Lexicon, Alerion, Chapelco, Graffito, Ximenia, and Halcyon). Right now my G5 preferences are Photon, or Callisto.
Walt Sorensen
@photodude
Mar 31 2016 18:22
@mahagr Thanks so much for updating all of those items for G4. I look forward to the next update.
The only thing I have left on my list was related to the 2015 Google bot change to start indexing css and JS which were blocked by Joomla's default robots.txt file since they were not located in the media folder,
Basically asset files should be located in the /media/[your library or extension] folder within Joomla after install.
I've been ignoring that issue since I added lines to allow googlebot to index the asset folders located in the wrong locations (according to Joomla's 3rd party developer standards).
But for someone who hasn't made that change, google is penalizing them and reducing their SEO score.
Everything else I have outstanding is related to RokSprocket.
Matias Griese
@mahagr
Mar 31 2016 18:23
we have some plans to get a bit more traditional templates
Walt Sorensen
@photodude
Mar 31 2016 18:24
Sweet, I look forward to seeing the "a bit more traditional templates" for G5
Matias Griese
@mahagr
Mar 31 2016 18:25
btw, you get your name into changelog
if you don't mind, we'll use your github username
Walt Sorensen
@photodude
Mar 31 2016 18:30
Thank you, I appreciate the mention. The Github username is just fine for the mention.
Michael Koontz
@N8Solutions
Mar 31 2016 20:31

@photodude could you please elaborate a little further about this

The only thing I have left on my list was related to the 2015 Google bot change to start indexing css and JS which were blocked by Joomla's default robots.txt file since they were not located in the media folder,
Basically asset files should be located in the /media/[your library or extension] folder within Joomla after install.
I've been ignoring that issue since I added lines to allow googlebot to index the asset folders located in the wrong locations (according to Joomla's 3rd party developer standards).
But for someone who hasn't made that change, google is penalizing them and reducing their SEO score.

Michael Koontz
@N8Solutions
Mar 31 2016 20:37
I thought Joomla addressed this in the new versions of Joomla and that the older versions just had to remove certain lines from the default robots.txt file, is that not the case?
Walt Sorensen
@photodude
Mar 31 2016 21:31

@N8Solutions the PR for any changes related to this in Joomla that I knew of was killed to quote the closing statement "Closing this issue as the solution is basically in place, we should use the media folder for media."
In otherwords any component or library that doesn't follow the Joomla Development Best Practices Will still have this issue.

That is unless the site owner using those extensions have modified their robots.txt file to allow each and every exception for when a developer did not use the media folder.

Exceptions for gantry in the robots.txt were

Allow: /libraries/gantry/css/
Allow: /libraries/gantry/js/
Allow: /libraries/gantry/assets/jui/fonts/font-awesome4/

I saw a 3 line change for the robots.txt file which supposedly would allow for all .js and .css files, but I would still get errors in google webmaster tools using that supposed fix. I've found two solutions that are consistent in fixing this issue. Either Site owners have to use exceptions route listed above, or developers need to follow the Joomla Development Best Practices and place their assets in the media folder.