Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 02 2018 23:31
    sirgatez starred garrettw/pierce
  • Jul 31 2015 22:01
    Jamonek starred garrettw/pierce
  • May 04 2015 05:22

    garrettw on master

    completed StdEvent onRplWelcome… (compare)

  • May 04 2015 05:08

    garrettw on master

    bad variable name in User class (compare)

  • May 04 2015 05:03

    garrettw on master

    and now it joins channels, plus… (compare)

  • Apr 30 2015 03:43

    garrettw on master

    lots of things. it finally conn… (compare)

  • Apr 26 2015 06:45

    garrettw on master

    moved some code out to Numerics… (compare)

  • Apr 26 2015 04:51

    garrettw on master

    double->single backslashes, now… (compare)

  • Jan 27 2015 05:40

    garrettw on master

    updated deps, code quality, and… (compare)

  • Jan 27 2015 05:40
    garrettw closed #2
  • Jan 27 2015 05:34
    garrettw commented #2
  • Jan 26 2015 02:56
    DavidRockin opened #2
  • Jan 26 2015 00:16

    garrettw on master

    bug and code quality fixes (compare)

  • Jan 25 2015 03:24

    garrettw on master

    update to finally make composer… (compare)

  • Jan 25 2015 02:24

    garrettw on master

    example, Client, and StdEvents … (compare)

  • Jan 24 2015 04:02

    garrettw on master

    simplified lots of code and add… (compare)

  • Jan 23 2015 08:24

    garrettw on master

    added more to StdEvents (compare)

  • Jan 19 2015 14:10

    garrettw on master

    more simplification of ns usage (compare)

  • Jan 19 2015 14:07

    garrettw on master

    guess I should be consistent wi… (compare)

  • Jan 19 2015 13:57

    garrettw on master

    oops, bugfix! (compare)

David
@DavidRockin
Nice..
Garrett W.
@garrettw
yeah gitter is pretty cool I think. The other day I had an argument in freenode/##php about whether something like this even had a point... i was alone. everybody thought IRC was good enough but... phooey on them. lol
David
@DavidRockin
@garrettw Haha, nice. Gitter seems pretty cool.
Lacks the spammy colours in irc :crying_cat_face:
David
@DavidRockin
Hey, Garret? Just wondering, did you even test pierce? :P
Getting a slew of errors.
Also, not sure if you forgot to commit the files in Connection directory
Garrett W.
@garrettw
oh no it's not even ready for a test run yet
it depends on my Dice and Noair packages which I haven't even released on packagist yet, so composer can't grab them
well dice should work but the other won't
Garrett W.
@garrettw
and no, the Connection files have no content yet
David
@DavidRockin
Ah, makes sense. I thought you forgot to submit them to packagist.
David
@DavidRockin
Oh and in the Ircu class, there are two duplicates for constants. I'm wasn't sure which one was the correct one.
Pierce\Numerics\Ircu::RPL_STATSDLINE
Garrett W.
@garrettw
ah, thanks! fixed it.
Garrett W.
@garrettw
so i've fixed most of the errors but one remains that I can't figure out.
David
@DavidRockin
What error?
@garrettw poke
David
@DavidRockin
Oh and you didn't finish the composer setup
You have to submit your package to packagist
Garrett W.
@garrettw
Oh I know. Once the MVP is working, I'll do that. It should work fine without that, though.
The error stems from $client->noair not being initialized -- $client->subscribe($noair) never gets called, but every other sub-class of \Noair\Listener gets it called like it's supposed to. Makes no sense.
David
@DavidRockin
Why not make it define using construct
function __construct(\Noair\Noair $noair)
{
  $this->noair = $noair;
}
Garrett W.
@garrettw
Hmm... Originally because Listeners won't necessarily also publish events, so it may not need that
Garrett W.
@garrettw
Wait, yeah, that should be fine. But it doesn't fix the problem of $listener->subscribe() not getting called, which has to happen either way. And I'm not sure that the subscribe() code should really go in the constructor..
David
@DavidRockin
Forgot about this, haha.
How goes pierce?
Garrett W.
@garrettw
Actually I just fixed all the errors I'd been having. It can successfully negotiate a connection now. Next step: make it join a channel.
Garrett W.
@garrettw
...and done! Next, gotta handle some server replies.