Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Luiz Irber
    @luizirber
    for #1053 @ctb used consume_string, which is not OpenMP-enabled
    so I wanted to return to consume_fasta (and this is #1177)
    Jake Fenton
    @bocajnotnef
    Ahh
    And why can't I merge it into #1176 before I merge #1176 into master?
    Luiz Irber
    @luizirber
    but, due to --stream-out, I had to move the write_record to C++ land
    well, you can. I just wanted to keep things separated to guarantee I was keeping the previous behavior
    Jake Fenton
    @bocajnotnef
    Ahh
    so now that unique-kmers has a pile of tests that I can check against I can merge in the streaming, verify there isn't a behaviour change and then go about life
    Luiz Irber
    @luizirber
    or just work on #1176 to have it merged on master, and later we merge #1177 on master
    Jake Fenton
    @bocajnotnef
    I also like that plan
    Luiz Irber
    @luizirber
    I think #1176 is way more important
    Jake Fenton
    @bocajnotnef
    agreed
    will go hammer on that
    though, looks like there isn't much else to do
    Luiz Irber
    @luizirber
    #1177 is useful for the paper I'm writing, but it's just a refactor, shouldn't change other things needed for the promotion of unique-kmers.py
    I'm pretty sure the docstrings need fixing
    still pointing to sandbox
    Jake Fenton
    @bocajnotnef
    hmm. diff-cover seems to think a line that is covered is not.
    strange
    Michael R. Crusoe
    @mr-c
    Let it go :-)
    diff-cover makes many mistakes
    as all code does; it is currently still useful enough
    Jake Fenton
    @bocajnotnef
    heh. True.
    well wouldja lookit that. the steaming out test broke.
    which is extra strange 'cause it wasn't before I pulled master in....
    Luiz Irber
    @luizirber
    is your virtualenv clean?
    I rebased on master and it worked fine (on 3.4)
    what was the error?
    Jake Fenton
    @bocajnotnef
    ======================================================================
    FAIL: tests.test_scripts.test_unique_kmers_stream_out
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/bocajnotnef/git/env/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
        self.test(*self.arg)
      File "/home/bocajnotnef/git/khmer/tests/test_scripts.py", line 3298, in test_unique_kmers_stream_out
        assert 'Writing to stdout' in err, err
    AssertionError: 
    || This is the script 'unique-kmers.py' in khmer.
    || You are running khmer version 2.0-rc1+119.gf55bd1f
    || You are also using screed version 0.9
    ||
    || If you use this script in a publication, please cite EACH of the following:
    ||
    ||   * MR Crusoe et al., 2014. http://dx.doi.org/10.6084/m9.figshare.979190
    ||   * A. D\xf6ring et al. http://dx.doi.org:80/10.1186/1471-2105-9-11
    ||   * Irber and Brown, unpublished
    ||
    || Please see http://khmer.readthedocs.org/en/latest/citations.html for details.
    
    Estimated number of unique 20-mers in -: 3950
    Total estimated number of unique 20-mers: 3950
    
    -------------------- >> begin captured stdout << ---------------------
    running: unique-kmers.py in: /tmp/khmertest_rpcL1J
    arguments cat /tmp/khmertest_rpcL1J/random-20-a.fa | python /home/bocajnotnef/git/khmer/tests/../scripts/unique-kmers.py -k 20 -e 0.01 --stream-out -
    
    --------------------- >> end captured stdout << ----------------------
    
    ----------------------------------------------------------------------
    Ran 572 tests in 32.963s
    
    FAILED (failures=1)
    Makefile:226: recipe for target 'test' failed
    make: *** [test] Error 1
    it's failing in a clean env for me
    Luiz Irber
    @luizirber
    assert 'Writing to stdout' in err, err
    Did you add this assertion?
    Jake Fenton
    @bocajnotnef
    sigh
    yes.
    Luiz Irber
    @luizirber
    and, well, the test is correct, I don't see this in the output =]
    bocajnotnef @bocajnotnef headdesks
    Jake Fenton
    @bocajnotnef
    wait, no, that's not... in mine...
    ....
    whaaat the nuts
    Luiz Irber
    @luizirber
    remove any .pyc files
    find . -iname "*.pyc" -delete
    Jake Fenton
    @bocajnotnef
    Huzzah!
    Thanks!
    Luiz Irber
    @luizirber
    yw
    I'll go home, be I'll be online later
    cya
    Jake Fenton
    @bocajnotnef
    Cheers!
    Jake Fenton
    @bocajnotnef
    @mr-c neither make test, ./setup.py develop nor make install make pylint behave
    Jake Fenton
    @bocajnotnef
    @mr-c You about?
    Michael R. Crusoe
    @mr-c
    Yes