Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 14 2020 15:28
    AshuSingh07 commented #102
  • Feb 14 2020 13:58
    ChristopheBoucaut commented #102
  • Feb 12 2020 23:03
    AshuSingh07 commented #102
  • Feb 12 2020 15:06
    ChristopheBoucaut commented #102
  • Feb 11 2020 17:56
    AshuSingh07 opened #102
  • Jul 26 2018 09:36

    ChristopheBoucaut on v1.0.1

    (compare)

  • Jul 26 2018 09:36

    ChristopheBoucaut on v1.0.1

    (compare)

  • Jul 26 2018 09:05

    ChristopheBoucaut on master

    Add description to use camera a… (compare)

  • Jul 25 2018 13:23

    ChristopheBoucaut on v1.0.1

    (compare)

  • Jul 25 2018 13:07

    ChristopheBoucaut on master

    Add description to use camera a… (compare)

  • Jul 25 2018 10:08

    ChristopheBoucaut on master

    Add description to use camera a… (compare)

  • Jul 11 2018 15:15

    ChristopheBoucaut on v1.0.0

    (compare)

  • Jul 10 2018 08:55

    ChristopheBoucaut on master

    Add package.json for Cordova 8. (compare)

  • Jul 10 2018 08:48

    ChristopheBoucaut on master

    Update cordova's paths in the h… (compare)

  • Jul 10 2018 08:38

    ChristopheBoucaut on master

    Remove cordova-plugin-compat to… (compare)

  • Feb 01 2017 09:53

    ChristopheBoucaut on v0.2.1

    (compare)

  • Feb 01 2017 09:52
    ChristopheBoucaut closed #100
  • Feb 01 2017 09:52

    ChristopheBoucaut on add-permissions-camera

    (compare)

  • Feb 01 2017 09:52

    ChristopheBoucaut on master

    Request permissions to start th… Add error code 4 to permissions… Merge pull request #101 from ge… (compare)

  • Feb 01 2017 09:52
    ChristopheBoucaut closed #101
Sean McDonnell
@seanconormcdonnell
This plug in looks sweet, is there a way to save the picture with the overlay on the image?
Christophe Boucaut
@ChristopheBoucaut
No, the image is just present during the capture. I'll search if we can implement this functionality easily. Nice proposition :)
Christophe Boucaut
@ChristopheBoucaut
@seanconormcdonnell , i added the #79 issue. Waiting for it, i'll try to develop a javascript function to generate a base64 with the picture and the overlay.
Christophe Boucaut
@ChristopheBoucaut
@seanconormcdonnell , here is an alternative at your issue but with Javascript. It's not perfect but i think you can use it in wait of the implementation in android.
Dazziola's Trunk
@dazziola
Hey all, great plugin really saved me a lot of time on a prototype I'm working on, thanks so much for that!
is there a way to rotate/scale the overlay image in real-time with gestures like pinch?
Christophe Boucaut
@ChristopheBoucaut
hi @dazziola :smile:
I don't envisage to implement the possibility to rotate/scale the overlay image in real-time with gestures like pinch because we use already the pinch for the zoom (for now, it isn't totally functional). I can replace the zoom by this feature and the user uses only the bar to zoom with the camera. Unfortunately, I don't have the time to implement it and I haven't skills to implement it on iOS. So, maybe later, I will implement it (because your feature is fun) but if you need the feature quickly, i can't promise that the plugin will provide it. Sorry and I thank you for the feedback.
Dazziola's Trunk
@dazziola
@ChristopheBoucaut Don't apologise Christophe, you have made an awesome plugin! I might fork it and make some changes to it, but thanks so much again!
Christophe Boucaut
@ChristopheBoucaut
np =)
Dazziola's Trunk
@dazziola
Hi Christophe, the plugin seems to mess with platforms in ionic. Are you aware of this? It breaks the Android build and platforms have to be readded to work again. I'm my case the plugin made extra changes to strings.xml every time android build was run. Just something to flag!
Christophe Boucaut
@ChristopheBoucaut
I never used ionic. With cordova, when I change the package name for a new name never used, I need to execute twice cordova build android because the plugin try to write in a file which is not create the first time.
Dazziola's Trunk
@dazziola
Hey Christophe, it seems the bug I mentioned previously about the plugin breaking the build everytime after the first build remains true for both Ionic and Cordova
I created a sample Cordova application to test this, and it is the same as the Ionic environment
```
* What went wrong:
Execution failed for task ':mergeDebugResources'.
> Error: Found item String/zoomMin more than one time
It seems as though the plugin keeps trying to create the same values that already exist in strings.xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<resources>
  <string name="app_name">HelloWorld</string>
  <string name="launcher_name">@string/app_name</string>
  <string name="activity_name">@string/launcher_name</string>
  <string name="zoomMin">-</string>
  <string name="zoomMax">+</string>
  <string name="zoomMin">-</string>
  <string name="zoomMax">+</string>
</resources>
Christophe Boucaut
@ChristopheBoucaut
Hi @dazziola. Can you give me your Cordova version, please ? I get never this bug. I will try to fix it and I will tell you when it's done for that you test.
Christophe Boucaut
@ChristopheBoucaut
I just saw in my project the same result in the strings.xml generated but my cordova doesn't fail to finish the build ^^. I push a fix in a few minutes. Can you try it and tell me if the bug is resolved, please ?
Dazziola's Trunk
@dazziola
I'm in work at the moment Christophe so I don't have my Cordova version right now, but it's good to see it's not just a problem with my build!
I will try as soon as I am home this evening and let you know. Have you a PayPal account? I'd like to send you money for beer as a symbol of thanks!
Christophe Boucaut
@ChristopheBoucaut
Okey :) To try the fix, use this command, to install the plugin: cordova plugin add https://github.com/geneanet/customCamera#3e7d04a39d94073e800ed054e4fb3288be489326 :). When you've confirmed that the bug is resolved, I will merge in the master branch.
Thank for your proposition but you help me to improve this plugin with your feedbacks and it is already in itself a thank :)
Dazziola's Trunk
@dazziola
It's the least I could do! The plugin is great and it is unique, no other Cordova plugin allows flexibility with the Camera API
Christophe Boucaut
@ChristopheBoucaut
I hope my plugin will inspire other plugins in the same way :), like for you.
Dazziola's Trunk
@dazziola
You are a hero!
Christophe Boucaut
@ChristopheBoucaut
XD thank :sparkles:
Dazziola's Trunk
@dazziola
Hi Christophe
I tried to add the plugin from the above GitHub link, however it couldn't seem to find that branch?!
Anyway, I forked the repository, and merged the branches myself on my GitHub as it seems to require master branch to add a plugin...and, it works perfectly!
Thanks again for all the help man
Christophe Boucaut
@ChristopheBoucaut
Thank for your feedback :) i will merge this fix in my master branch tomorrow. Good luck for your project :)
Dazziola's Trunk
@dazziola
Just so you know it works great with Ionic as well, you should promote it for that as well!
Christophe Boucaut
@ChristopheBoucaut
Okey :) I will try to find time to up the plugin in npm (for cordova 5) and after i will look Ionic (I never look it). Thank for the advice. Tomorrow, I will add a list of supports tested on the project github. Thanks to you that I will add Ionic :)