geneanet/customCamera

Cordova plugin to start a customizable camera

Dazziola's Trunk

@dazziola

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<resources>
  <string name="app_name">HelloWorld</string>
  <string name="launcher_name">@string/app_name</string>
  <string name="activity_name">@string/launcher_name</string>
  <string name="zoomMin">-</string>
  <string name="zoomMax">+</string>
  <string name="zoomMin">-</string>
  <string name="zoomMax">+</string>
</resources>

Christophe Boucaut

@ChristopheBoucaut

Hi @dazziola. Can you give me your Cordova version, please ? I get never this bug. I will try to fix it and I will tell you when it's done for that you test.

Christophe Boucaut

@ChristopheBoucaut

I just saw in my project the same result in the strings.xml generated but my cordova doesn't fail to finish the build ^^. I push a fix in a few minutes. Can you try it and tell me if the bug is resolved, please ?

Dazziola's Trunk

@dazziola

I'm in work at the moment Christophe so I don't have my Cordova version right now, but it's good to see it's not just a problem with my build!

I will try as soon as I am home this evening and let you know. Have you a PayPal account? I'd like to send you money for beer as a symbol of thanks!

Christophe Boucaut

@ChristopheBoucaut

Okey :) To try the fix, use this command, to install the plugin: cordova plugin add https://github.com/geneanet/customCamera#3e7d04a39d94073e800ed054e4fb3288be489326 :). When you've confirmed that the bug is resolved, I will merge in the master branch.

Thank for your proposition but you help me to improve this plugin with your feedbacks and it is already in itself a thank :)

Dazziola's Trunk

@dazziola

It's the least I could do! The plugin is great and it is unique, no other Cordova plugin allows flexibility with the Camera API

Christophe Boucaut

@ChristopheBoucaut

I hope my plugin will inspire other plugins in the same way :), like for you.

Dazziola's Trunk

@dazziola

You are a hero!

Christophe Boucaut

@ChristopheBoucaut

XD thank :sparkles:

Dazziola's Trunk

@dazziola

Hi Christophe

I tried to add the plugin from the above GitHub link, however it couldn't seem to find that branch?!

Anyway, I forked the repository, and merged the branches myself on my GitHub as it seems to require master branch to add a plugin...and, it works perfectly!

Thanks again for all the help man

Christophe Boucaut

@ChristopheBoucaut

Thank for your feedback :) i will merge this fix in my master branch tomorrow. Good luck for your project :)

Dazziola's Trunk

@dazziola

Just so you know it works great with Ionic as well, you should promote it for that as well!

Christophe Boucaut

@ChristopheBoucaut

Okey :) I will try to find time to up the plugin in npm (for cordova 5) and after i will look Ionic (I never look it). Thank for the advice. Tomorrow, I will add a list of supports tested on the project github. Thanks to you that I will add Ionic :)

Can you tell me your Ionic version, please ?

Dazziola's Trunk

@dazziola

1.6.4

Christophe Boucaut

@ChristopheBoucaut

Thank :)

Dazziola's Trunk

@dazziola

What IDE do you use to create Cordova Android Plugins?

I would like to customise the activity_camera_view.xml with Design View

Christophe Boucaut

@ChristopheBoucaut

I use eclipse

with android plugin

but I think that Google stopped to support the plugin ... For the next big developpement, I will try to migrate on Android Studio.

Dazziola's Trunk

@dazziola

Interesting, I'll look at both!

Christophe Boucaut

@ChristopheBoucaut

I think Android Studio needs to change the project because it uses maven and other services which need configurations files in addition.

Dazziola's Trunk

@dazziola

Yea like the plugin doesnt use Gradle or Maven

So Android Studio goes a bit crazy when you import

Christophe Boucaut

@ChristopheBoucaut

You can find more details for the plugin here.

Dazziola's Trunk

@dazziola

Hey Christophe, I hope you are well!

I have a couple of questions you might be able to help me with, with regards to the plugin!

Christophe Boucaut

@ChristopheBoucaut

Hi ! I'm on holidays but I can try to help you.

Dazziola's Trunk

@dazziola

Ah don't worry Christophe! I was just wondering how to remove the grey "postbox" effect of the camera preview screen

When I take a picture, the output picture always jumps, and expands out of position of the overlay

I will get an example

Dazziola's Trunk

@dazziola

http://imgur.com/a/jn6Ox

The top image is the camera preview with a layover image

the bottom is the captured image, which stretches to near screen size, with the layover image in the same position

Is it possible to lessen the amount of grey (on the right hand side of the top image) and stretch the preview to be the equivelant of the picture output?

I've messed around with the layout files and cant get it to work it seems

Any help would be great, hope you're enjoying holidays!

Christophe Boucaut

@ChristopheBoucaut

Your problem is that the image rendered hasn't same size that the preview from the camera ?

If you changed the layout, you need check here and you need check this method. After, I don't change the preview size, I believe.

Otherwise, you can also take the size of the picture and you will fixe the size for the layout and you keep the ratio. You can get picture size without opening it for limit memory consumption (see stackoverflow).

For the preview, the grey border is here to avoid a stretch of the preview. Indeed, camera resolutions don't match with the screen resolution and with a camera big resolution (for example, with the Nexus 5), the preview is stretched. I didn't find a better solution for this issue for now :/ and the officiel camera on Nexus 5 does the same.

Dazziola's Trunk

@dazziola

Cool, thanks Christophe. I understand the reasoning of not stretching the preview but as you can see in the first image (I've messed about with the layout a little bit so try to ignore the positioning etc!) the Camera Preview section is squashed down in size which distorts the image

Christophe Boucaut

@ChristopheBoucaut

You can check the resolution used and the size set on the layout. Check if the ratio is conserved.

zleal

@zleal

hello guys, i need some help with cordova custom camera or crop image... can anyone help me with that?

my email > agenciazear@gmail.com
for contact and for help me...

Ashu Singh

@AshuSingh07

hello, I tried adding custom camera plugin to my project in dependency file:"cordovacustomcamera": "git+https://github.com/geneanet/customCamera.git" and "org.geneanet.customCamera": "https://github.com/geneanet/customCamera.git". This works fine in my local machine but git repo is not being allowed from enterprise nexus artifacts. They want me to add plugin in package.json similar to "cordova-sqlite-storage": "2.6.0". Please let me know how to add it my package.json file so that npm can install it from enterprise nexus artifact. My jenkin build is failing. your help is highly appreciated.

Ashu Singh

@AshuSingh07

cordova plugin add org.geneanet.customCamera
(node:14016) UnhandledPromiseRejectionWarning: Error: cmd: Command failed with exit code 1 Error output:
npm ERR! code E404
npm ERR! 404 'org.geneanet.customCamera' is not in the npm registry.

Where communities thrive

People

Repo info

Activity