Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • May 24 11:28

    tinesoft on master

    chore(sponsorship): activate gi… (compare)

  • Mar 19 20:13
    tinesoft commented #171
  • Mar 19 19:29
    michaeldoye closed #171
  • Mar 19 15:03
    michaeldoye opened #171
  • Feb 12 09:52
    ShaileshInfyom commented #170
  • Feb 12 09:51
    ShaileshInfyom closed #170
  • Feb 12 09:51
    ShaileshInfyom commented #170
  • Feb 11 13:08
    ShaileshInfyom edited #170
  • Feb 11 13:07
    ShaileshInfyom edited #170
  • Feb 11 13:05
    ShaileshInfyom edited #170
  • Feb 11 13:05
    ShaileshInfyom edited #170
  • Feb 11 13:04
    ShaileshInfyom edited #170
  • Feb 11 12:56
    ShaileshInfyom edited #170
  • Feb 11 12:54
    ShaileshInfyom opened #170
  • Oct 31 2018 10:46

    tinesoft on master

    feat(demo): move to HttpClientM… (compare)

  • Oct 31 2018 10:46
    tinesoft closed #169
  • Oct 31 2018 10:46
    tinesoft closed #165
  • Oct 31 2018 09:16
    gc23 commented #169
  • Oct 31 2018 09:14
    gc23 synchronize #169
  • Oct 31 2018 08:02
    tinesoft commented #169
Tine Kondo
@tinesoft
Ok, good to know...
Tine Kondo
@tinesoft
hi @edetec i can confirm the issue you mentioned "demo app ui not refreshing on gulp build:watch".
for the moment, i cannot find out why... can you file an issue on github? so i can keep track of this, and maybe have people involved in solving it. thanks!
Eder Lima Soares
@edetec
hi @tinesoft , thank you for your help, the issue has filed.
Anthony Nahas
@AnthonyNahas
@tinesoft can you add my project to the readme ? :smile: https://www.npmjs.com/package/ngx-auth-firebaseui https://github.com/AnthonyNahas/ngx-auth-firebaseui thank yoooooo
u
Tine Kondo
@tinesoft
Hi Anthony. For sure! I noticed your library yesterday. Great job :+1:
Anthony Nahas
@AnthonyNahas
Thank you yours too :facepunch:
Tine Kondo
@tinesoft
I'm glad it helps! Feel free to hit me if you think about an useful missing feature :smile:
Anthony Nahas
@AnthonyNahas
Yes I have
:satellite:
ngx-auth-firebaseui has a assets of svg files (i18n in the future for translations). Per default they will be not copied, optimized and so on...
That's why I updated gulpjs locally in order to support assets optimizing
should I post here that changes or do you prefer a PR on github? or do you think assets are not important ?
Tine Kondo
@tinesoft
I've been asked that question some time ago(see #138 ):
The thing is this is to specific to be automatically included in the generator...
Instead I'm thinking about writing a recipe in the docs, or better, an additional step in the prompt where you could tell which additional assets you'd like to include as well
Anthony Nahas
@AnthonyNahas
cool
:+1:
Tine Kondo
@tinesoft
More generally, I'm thinking about hooks, so that you can provide additional gulp tasks to be executed during key moments in build lifecycle...
Stay tuned! :smile:
Anthony Nahas
@AnthonyNahas
I added the task „copy:assets“ to the build task as default
since I use build only for pre and releases
and build:watch_fast for development ;) #
Anthony Nahas
@AnthonyNahas
@tinesoft what do you think about an optional step while generating a new lib converning the demo app. The user could have the otpional to select his favorite css framework. You use as default bootstrap.. what about devs they use material design?
Tine Kondo
@tinesoft
hi @AnthonyNahas
i would say that's a good suggestion for your 1st PR to the project! :)
but instead of an additional step in the prompt (already too long IMHO), i would rather add it as an option when running the generator yo ngx-library my-lib --demo-theme=material
when the option is not provided, default value is bootstrap
Anthony Nahas
@AnthonyNahas
hahahhaha cooool
I am approx. angular material expert ...
I use this framework since version 0.1.0
So If i find time in the nesxt weeks, Ill try to do that ;)
Tine Kondo
@tinesoft
:+1: yeah!
Tine Kondo
@tinesoft
Hello! Just added your ngx-material-pages README. Great work :+1:
Anthony Nahas
@AnthonyNahas
haha your the bst ;)
Thank you
Tine Kondo
@tinesoft
No problemo :smile:
Anthony Nahas
@AnthonyNahas
@tinesoft I updated the ngx-materia-pages module
Tine Kondo
@tinesoft
Neat-o!
Anthony Nahas
@AnthonyNahas
@tinesoft I think it’s better to add webpack in greenkeeper ignore when this is enabled, because to upgrade a library from webpack v3 to v4 it’s not easy
...
Tine Kondo
@tinesoft
Ah?
What kind of upgrade issues are u having?
Anthony Nahas
@AnthonyNahas
I found the problem! The errors were not related to webpack, but to jasmine test framework...
I was not able to upgrade jasmine-core from 2.8.0 to 3.1.0 and karmin Jasmine html reporter from 0.2.2 to 1.0.0
I will try to run an update for these packages probably next week….
Tine Kondo
@tinesoft
Ok