Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Brendan Ward
    @brendan-ward
    @rajuthegr8 Feel free to log issues onto pgpkg to capture your ideas / findings that can be addressed in later PRs (mostly I'm thinking of these of capturing a few of the technical specifics while they are fresh). You can certainly link these into your proposal, but like @martinfleis said, your focus should be on the overall proposal and bigger picture: overall approach, goals, what is your sense of how hard it will be to go to from what is available to meet the goals for the project, etc. (I probably got overly excited by the specifics I listed off above, apologies if that was a bit of a distraction from the overall proposal)
    Brendan Ward
    @brendan-ward
    @rajuthegr8 also see the NumFOCUS (of which GeoPandas is a part) student guide: https://github.com/numfocus/gsoc/blob/master/CONTRIBUTING-students.md
    there are several useful suggestions for putting together your proposal and pre-application activities.
    froast
    @abhinav9414
    hi everyone, i am an undergraduate student at Birla Institute of Technology,Mesra. I would like to contribute to the project "Beautiful maps made simple: a static plotting project". I wanted to ask what contributions are require to make changes from static matplotlib map to a complex map in a production-quality.I am writing project proposal,What are the expectations in the project proposal.
    Martin Fleischmann
    @martinfleis
    Hi @abhinav9414, happy to see the interest! As mentioned in the project idea, part of the work should be a diagnosis of the current state and community needs, based on which we should be able to point at specific changes. A good place to start are issues labelled as "plotting" which should cover the most pressing issues. We don't have a list of changes that need to be made (yet), we hope that the initial stage of the GSoC will produce one. A project proposal template might also help with drafting.
    5 replies
    Thomas Statham
    @tastatham
    Hi Geopandas, I am interested contributing to dask-geopandas through the Google Summer of Code this year. There are a few goals listed on the wiki page and I was wondering whether there was a priority on any one of these?
    Martin Fleischmann
    @martinfleis
    Hi @tastatham, dask-geopandas is in an early stage of development so there is a lot to do. I would say that the ideal roadmap now would be 1) spatial partitioning, 2) spatial indexing, 3) overlapping computation, based on my own experience and needs (which may be biased). Maybe IO... You can check the issues https://github.com/geopandas/dask-geopandas/issues for a discussion on some of these. If you have some needs yourself, feel free to embed them in the proposal. Also note that we have submitted a workshop proposal around dask-geopandas to Dask Summit, so there may be a chance to have a good discussion on priorities during that with a wider range of people.
    Thomas Statham
    @tastatham
    thanks @martinfleis, that's really helpful. Ok, I'll consider in the proposal aspects that are important to my work too (which will probably be useful to others) but the geopandas/dask-geopandas#40 could be really useful!
    Martin Fleischmann
    @martinfleis
    @tastatham check also the initial implementation by Matt Rocklin https://github.com/mrocklin/dask-geopandas and spatialpandas, which implements some aspects of geospatial parallelization using dask - https://github.com/holoviz/spatialpandas.
    Thomas Statham
    @tastatham
    @martinfleis, I'm aware of spatialpandas but I'm not familiar with their API. I'll explore this further because they have some really nice examples.
    Martin Fleischmann
    @martinfleis
    @tastatham the API tends to mimic ours I think. What they have implemented is some form of spatial indexing (maybe only for points? Haven’t checked lately), which may be worth checking.
    Joris Van den Bossche
    @jorisvandenbossche
    @tastatham cool to see interest in dask-geopandas! ;)
    One general comment in addition to what Martin already said: it's indeed in an early stage of development, which also means that we have almost no documentation or examples, not much test coverage, etc. That are of course not "big" topics to focus on, but something that will be useful to give some time along the way.
    Joris Van den Bossche
    @jorisvandenbossche
    And related to that, what I think will be useful at some point: take an (advanced) use case (which can be something from your own work / interest, or a general one like the "NYC taxi data"), implement a full workflow with using dask-geopandas, and see all the issues that you run into / areas that can be optimized.
    Since not a lot of people already did this with their workflow (and we don't have example case studies), I think in general we will still run into quite some issues in the beginning.
    Joris Van den Bossche
    @jorisvandenbossche
    (eg I was planning to replicate the benchmark from a Scipy talk with billions of points and spatial joins from the spatialpandas people; need to look up the source again, to learn from it what we are still missing in dask-geopandas to do this efficiently)
    Thomas Statham
    @tastatham
    thanks @jorisvandenbossche for pointers, the NYC taxi dataset is a good one and there are a number of others listed on datashader that would be worth exploring too and my own work of course
    Martin Fleischmann
    @martinfleis
    Hi @tastatham, @abhinav9414, @rajuthegr8,
    Just a quick reminder that you need to register and submit your proposals (the application shouldn’t be in draft mode) on the GSoC website, summerofcode.withgoogle.com before the deadline, April 13th.
    Joris Van den Bossche
    @jorisvandenbossche
    Hi @tastatham, @abhinav9414, @rajuthegr8, another reminder for the deadline. Also, feel free to share the proposal with us here if you still want to get some feedback on it.
    froast
    @abhinav9414
    hi @martinfleis, @jorisvandenbossche, I made a proposal, but don't know what to write in the section of the coding approach part in the beautiful map and pgpkg. started late so only got a basic understanding of the project, can I get help in this?
    Martin Fleischmann
    @martinfleis
    @abhinav9414 You mean the "Approach" section in the template? It depends. I guess that for plotting project it is fairly straightforward python code based existing matplotlib functionality. In the gpkg IO, there may be some SQL, regarding technology. But it all depends on the rest of the proposal. You haven't shared the draft via GSoC so it is hard to advise. If you need some PRs in related packages it should be there etc.
    froast
    @abhinav9414
    thanku @martinfleis ill share within 2hrs.
    Raj Gupta
    @rajuthegr8
    @martinfleis @jorisvandenbossche I have submitted my draft, I would appreciate any feedback if possible. Thank you and apologies for being submitting so close to the deadline
    Joris Van den Bossche
    @jorisvandenbossche
    @rajuthegr8 I am not sure if I can see the drafts submitted on GSOC's website. Could you share it somewhere else as well? (eg copy it in a google docs or hackmd, where we can comment on it)?
    Thomas Statham
    @tastatham
    @martinfleis and @jorisvandenbossche, I have also completed my draft in Google Docs and would also appreciate some suggestions. Apologies for submitting this so close to the deadline.
    Joris Van den Bossche
    @jorisvandenbossche
    Thanks, taking a quick look at both now
    Martin Fleischmann
    @martinfleis
    @tastatham Thanks! I just checked your proposal and left few (very) minor comments. It looks great! We may end up doing less but it is fine being ambitious :).
    Martin Fleischmann
    @martinfleis
    @rajuthegr8 one comment from my side in the doc, @jorisvandenbossche covered the rest.
    Martin Fleischmann
    @martinfleis
    @abhinav9414 I didn't realise you are planning to combine two projects into a single proposal. I have left a comment regarding that in the document (and didn't review the rest in detail as a result) but I would recommend focusing on a single project.
    Thomas Statham
    @tastatham
    @martinfleis @jorisvandenbossche , thanks for taking a look at the proposal. It's much appreciated.
    Brendan Ward
    @brendan-ward
    @abhinav9414 Is your proposal shared somewhere we can provide feedback? (not seeing it here). If you are thinking of including gpkg I/O, I'd like to help provide comments too, but definitely don't let that hold you up since today is the due date.
    Just FYI, I will be (mostly) off for the rest of the day and won't be able to check any further drafts or changes before the deadline.
    Brendan Ward
    @brendan-ward
    @tastatham just provided a few minor suggestions as well; overall looks good (appreciate the level of detail!) and I'm excited to see how spatial partitioning will fit into chunking data for use in Dask.
    Brendan Ward
    @brendan-ward
    Looks like the GSoC submission deadline is coming up soon. Good luck @rajuthegr8 @abhinav9414 @tastatham and thank you for your interest in helping push GeoPandas forward!
    froast
    @abhinav9414
    thank you @brendan-ward.
    arredond
    @arredond
    Hey folks! I'd like to start contributing by tackling some open issue but not sure where to start. There are a handful of open issues tagged "good first issue" but some go as far back as 2014 and I can imagine some already being tackled. Can anybody give me any pointers?
    Martin Fleischmann
    @martinfleis
    Hi @arredond, Looking at it the list of issues, it is clear that we should do some spring cleaning. The best would be to check issues labelled bug and find some you're comfortable fixing. They require various level of expertise and some will be easier than other so you should be able to find some you're comfortable with. If you want to work on documentation, #1896 is a nice one to start with.
    arredond
    @arredond
    Sounds good, thanks for the heads up!
    and-viceversa
    @and-viceversa
    Screen Shot 2021-04-20 at 10.45.01 AM.png
    Hello all, the github contact section pointed me here. I'd like to open a feature request to build oriented minimum bounding boxes from polygons, like you can do in QGIS. Having trouble implementing it on my own. This this an appropriate issue to open?
    Martin Fleischmann
    @martinfleis
    Hi, the built-in method will likely come soon, we have just recently implemented it in pygeos. At the moment, you can get it via oriented_box = gdf.geometry.apply(lambda geom: geom.minimum_rotated_rectangle)
    and-viceversa
    @and-viceversa
    Excellent! Much appreciated.
    and-viceversa
    @and-viceversa

    Still got some testing to do, but I ended up using https://github.com/dbworth/minimum-area-bounding-rectangle/blob/master/python/min_bounding_rect.py to make follow on operations easier.

    It looks like geom.minimum_rotated_rectangle doesn't guarantee right angles? They might be trying to accomplish different things.

    Martin Fleischmann
    @martinfleis
    @and-viceversa that doesn't sound right. Can you show an example when it doesn't return right angles?
    and-viceversa
    @and-viceversa

    Short answer everything works as intended - thank you again. FWIW the github link to min_bounding_rect.py returns identical return as geom.minimum_rotated_rectangle.

    Long answer is that the KML writer enforces geographic coordinates, which I did not know. So QGIS' project on the fly visually was not showing a true rectangle versus the underlying (in my case) local UTM. I had done quick tests with min_bounding_rect.py at large scales only, and tests with minimum_rotated_rectangle at small scale only. Obviously at large scale the difference in the projection were not as noticeable so the two calls appeared to have different results. Using the same projections for minimum rectangle and the underlying in a non-KML format works as intended.

    Shirzart Enwer
    @Aniwax
    Hello everyone :) As a completely freshman to pygeos, I just have simple question on data input format when constructing a geometry in pygeos: is there other input data format possible other than string?
    I want to construct polygon, whose boundary points are returned from a list of numbers....it's quite cumbersome to convert it in the desired string format.
    Martin Fleischmann
    @martinfleis
    @Aniwax you can pass arrays of coordinates, see the docs here https://pygeos.readthedocs.io/en/latest/creation.html (for linearrings and polygons)
    Shirzart Enwer
    @Aniwax
    Thanks! @martinfleis , another dummy question: what's the difference between linearrings and polygon? If I don't need any hole in a within the boundary of my geometry, do I just need linearrings and not polygon?
    Martin Fleischmann
    @martinfleis
    Linearring is linear geometry (just that exterior line) while polygon covers an area it encloses.
    Shirzart Enwer
    @Aniwax
    Alright, got it, thanks!
    Alex Yule
    @yuletide
    Hey folks, working on a project and ran into a bunch of "illegalArgumentException: Geometry must be a Point or LineString" when exporting a dataframe to json (or passing it into rasterstats). Any idea what could cause this? The geometry seems valid and plots fine. I'm using Shapely 1.8a1 but unable to reproduce with sample data. This data is a large set of isochrones created using the Mapbox API.