by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 08 12:10

    justb4 on master

    bump version to 0.8.dev1 (compare)

  • Jul 07 14:26

    justb4 on 0.8.0

    (compare)

  • Jul 07 14:17

    justb4 on master

    LAST CHECK-IN BEFORE 0.8.0 (compare)

  • Jul 07 10:02

    justb4 on master

    docs - made upgrade info uptoda… (compare)

  • Jul 07 09:56
    justb4 milestoned #320
  • Jul 07 09:56
    justb4 demilestoned #320
  • Jul 07 09:55
    justb4 milestoned #315
  • Jul 07 09:55
    justb4 demilestoned #315
  • Jul 07 09:55
    justb4 milestoned #310
  • Jul 07 09:55
    justb4 demilestoned #310
  • Jul 07 09:54
    justb4 milestoned #9
  • Jul 07 09:54
    justb4 demilestoned #9
  • Jul 07 09:54
    justb4 commented #9
  • Jul 07 09:54
    justb4 commented #9
  • Jul 07 09:52
    justb4 demilestoned #275
  • Jul 07 09:52
    justb4 milestoned #275
  • Jul 07 09:52
    justb4 demilestoned #231
  • Jul 07 09:52
    justb4 milestoned #231
  • Jul 07 09:52
    justb4 milestoned #247
  • Jul 07 09:52
    justb4 demilestoned #247
marinevliz
@marinevliz
here is a screenshot of the issue
Rob van Loon
@borrob
Hi @marinevliz, did you build a docker image yourself, or did you take it from the docker hub?
marinevliz
@marinevliz
Hi @borrob I used the docker hub.
Just van den Broecke
@justb4
we need to see a screenshot of your "Network" tab and your networking/proxy setup. Looks like a Proxy-config or subpath issue.
Rob van Loon
@borrob
@marinevliz All the other static files (like sb-admin-2.css, font-awesome, leaflet.js, ...) work fine? Can you right-click on file in the network-tab, and choose "open in new tab". Does it load then?
marinevliz
@marinevliz
right click and open in new tab in the network tab gives met this: https://imgur.com/4dYcyE1
Here is the network tab: https://imgur.com/5iEX0Qa
Proxy settings: https://imgur.com/4vtoQOr
its weird if i refresh it works, if i refresh again it breaks again
Rob van Loon
@borrob
Well, the first screen shot shows the file is actually there and that you are able to access it. That would suggest all docker and proxy settings are fine. I don't understand the refreshing behaviour. Could that be a caching issue?
marinevliz
@marinevliz
Could be, I can only replicate it on windows 7 machines using chrome or firefox
Rob van Loon
@borrob
Sorry, I can't really help you with windows machines.
Jo Cook
@archaeogeek
Hi there, I have a question about using geohealthcheck with docker, I'm not sure if it's an issue or if my understanding is at fault. My problem is that if I pass a SCRIPT_NAME environment variable with the docker run command, whatever path I include seems to get used twice. My run command is: docker run -d --name ghc_web -p 8083:80 -e SCRIPT_NAME=foo -v ghc_sqlitedb:/GeoHealthCheck/DB geopython/geohealthcheck:latest
... but then when I load the page at http://localhost:8083/foo then all the references in the page are to http://localhost:8083/foo/foo/?lang=en
If I don't include a SCRIPT_NAME variable then it loads as expected at http://localhost:8083, but unfortunately I need it to run in a sub directory
is this a bug or have I missed something in my understanding of how this should be working?
Just van den Broecke
@justb4
Well, first of all SCRIPT_NAME is meant for the case where GHC is run behind a proxy like Apache or Traefik which you probably intend, though it should work in isolation as well. I remember this question came up before, and you contributed a nice piece of documentation for that case: https://docs.geohealthcheck.org/en/latest/install.html#running-under-a-sub-path . Is it maybe you forgot a slash i.e. /foo i.s.o. foo?
Jo Cook
@archaeogeek
@justb4 this will be run behind nginx, and that's where I first hit the problem
I can't get the nginx config to work (using my documentation from earlier :-) ) because it is creating the nested sub-directory. I have an older version (0.6 ish) working outside of docker with gunicorn and supervisord and that is working just fine and the nginx config ought to be the same
Just van den Broecke
@justb4
is nginx also running in Docker? With docker-compose? Then the Docker networking (hostnames/ports) is all internal.
Jo Cook
@archaeogeek
no, nginx is running externally (on the same server but outside of docker). It can "see" geohealthcheck and get to the index page but then the links are all broken
but... surely it should work in isolation (ignoring nginx) so adding a script name as an environment variable should not create the nested sub directory- it should just create one?
Just van den Broecke
@justb4
and you've set it to /foo? There is no directory, it is just a sub-path.
Jo Cook
@archaeogeek
If I set -e SCRIPT_NAME=foo then the URLs are of the form http://localhost:8083/foo/foo/?lang=en when they should presumably be of the form http://localhost:8083/foo/?lang=en
ah- so docker run -d --name ghc_web -p 8083:80 -e SCRIPT_NAME=/foo -v ghc_sqlitedb:/GeoHealthCheck/DB geopython/geohealthcheck:latest seems to work
I'll try that in my server environment
Jo Cook
@archaeogeek
Yes! that's working just fine. I might add that to the documentation so that others don't go round in circles like I did- thanks for your help @justb4
Just van den Broecke
@justb4
welcome!
Maxime Audet-Roberge
@audetrobergem
Good day, I recently install GeoHealthCheck and I am in the process of adding resources. I have an error when I try to add probes to a WFS resource. For example, the probe WFS GetFeature in BBOX for ALL FeatureTypes give me an ‘Error getting Probe form for GeoHealthCheck.plugins.probe.wfs.WfsGetFeatureBboxAll’. The log error message says: ‘UnboundLocalError: local variable 'feature_type_entry' referenced before assignment’ for ‘crs_list = feature_type_entry.crsOptions’. I am using 0.8.dev0. Someone has an idea why I have this message? Thanks a lot!
Just van den Broecke
@justb4
Hmm, sounds like an old bug. Have you tried the latest master version?
Maxime Audet-Roberge
@audetrobergem
I think it is the latest master version, I installed it 2 weeks ago from git.
Just van den Broecke
@justb4
Ok, I cannot reproduce on de demo.geohealthcheck.org site (runs latest master) using a public WFS from the Dutch SDI: http://geodata.nationaalgeoregister.nl/bag/wfs . But I can see where it happens in the code. There a random feature type entry is fetched but it is appearantly empty (code should be more defensive though). I see two possible causes: 1) your WFS provides different options/encodings as e.g. the one above. Or 2) a mismatch with the OWSLib version you are using. So can you give the WFS URL you are using? And the OWSLib version?
Maxime Audet-Roberge
@audetrobergem
I use OWSLib version 0.17.1. The WFS I use is password protected, there are no layers that can be accessed without being logged in. Is it possible that crs_list is done on an empty WFS (before authentication is performed)? I tried the public WFS from the Dutch SDI and it worked on my instance.
Just van den Broecke
@justb4
image.png
OWSLib 0.17.1 is ok (same as used on demo). The auth should not be the problem. All info is pared from the Capabilities doc, guess the Capabilities Probe works ok. As the public WFS URL works, there is something in the capabilities doc different. For one thing: I see that the WFS Probe fetches using WFS 1.1.0, could that be a problem (e.g. only 2.0.0 is supported). You may want to look into the Caps doc, it should read like:
Maxime Audet-Roberge
@audetrobergem
The general structure of the GetCapabilities document is the same. However, I see a difference in the CRS. There are in my file 2 x ':' between EPSG and the code when there's only one in the public WFS from the Dutch SDI Caps. For example, '<DefaultCRS>urn:ogc:def:crs:EPSG::4326</DefaultCRS>'. I use GeoServer to publish data.
Just van den Broecke
@justb4
That looks correct. Another public WFS uses same notation (double colon): https://geodata.nationaalgeoregister.nl/nationaleparken/wfs with <DefaultCRS>urn:ogc:def:crs:EPSG::28992</DefaultCRS> and works ok. Give that a try. Must be something else. Hard to figure out without the WFS url and your deployment context (Docker?, Python version, maybe lxml version). The capabilities Probe and other Resource types, w.g. WMS work ok for that GeoServer endpoint?
Hmm and https://geodata.nationaalgeoregister.nl/bag/wfs now suddenly also has double colons in CRSs.
But that is the correct notation.
Just van den Broecke
@justb4
See also: https://docs.geoserver.org/latest/en/user/services/wfs/axis_order.html urn:x-ogc:def:crs:EPSG:4326 and urn:ogc:def:crs:EPSG::4326 are equivalent.
(notice the subtle :x-ogc: vs :ogc:, 4 notations for the same thing causes headaches in many projects).
Just van den Broecke
@justb4
Forget the above, the problem (and fix) is clear to me, and already known: https://github.com/geopython/GeoHealthCheck/issues/9#issuecomment-562950148 : WfsGetFeatureBboxAll uses OWSLib WFS, which in 0.17.1 does not support auth headers. Was fixed geopython/OWSLib#613, even by me :-), in later version. There is even a geopython/GeoHealthCheck#312. (WFS Capabilities Probe works as it does not use OWSLib btw).
Maxime Audet-Roberge
@audetrobergem
All right, I will wait for the fix to add probes to my WFS. Thank you for taking the time to help me!
Just van den Broecke
@justb4
An activity for a GHC API specification has been started. In first instance geared to facilitate remote monitoring integrations and custom reporting, using the current GHC implementation. There is a broader plan to base a future GHC entirely on a full CRUD API. See work-in-progress on the Wiki: https://github.com/geopython/GeoHealthCheck/wiki/API-Specification . If you would like to comment or have suggestions, please do, best is via the related issue #325.
Astrid Emde
@astroidex
Hello all, I try to install GHC on windows without docker. Has someone good experience with it?
Just van den Broecke
@justb4
@astroidex sorry can't help you direct. Hopefully someone else here? Main thing to do is getting all dependencies installed. Understood Anaconda works well for that. Would be good to document installation steps to include in our docs.
Just van den Broecke
@justb4
Would like to bring out GHC 0.8.0 today. This is mainly the Py2->Py3 migration, no DB upgrades. Has been running stable on "demo" for about 6 months now. Several production deployments can then be upgraded (on 0.7.0). Then we can quickly move to Milestone/version 0.8.1 that has leftovers from Milestone 0.8.0. @tomkralidis I can do the release sequence ok?
Tom Kralidis
@tomkralidis
+1 thanks @justb4
Just van den Broecke
@justb4
@/all GHC release 0.8.0 is out. Main addition is the Py2->Py3 migration. Many thanks to @borrob for his efforts/patience with this! Also 0.8.0 Docker Image is available.
Tom Kralidis
@tomkralidis
thanks @justb4 !