Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 11:40
    tomkralidis closed #782
  • 11:40
    tomkralidis commented #782
  • 11:39
    tomkralidis commented #756
  • 11:10

    tomkralidis on doc-csv-table

    (compare)

  • 11:10

    tomkralidis on master

    docs: make CSV table more reada… (compare)

  • 11:01

    tomkralidis on doc-csv-table

    docs: make CSV table more reada… (compare)

  • Sep 25 11:07
    tomkralidis commented #291
  • Sep 25 11:05
    tomkralidis commented #747
  • Sep 25 11:03

    tomkralidis on master

    Add postgres provider query par… (compare)

  • Sep 25 10:48
    tomkralidis commented #783
  • Sep 25 10:48

    tomkralidis on master

    782: Replaced the literal strin… Merge branch '782_subsetting_us… Merge branch 'MetServiceDev-782… and 1 more (compare)

  • Sep 21 11:15

    tomkralidis on master

    Update pygeoapi-config.yml (compare)

  • Sep 21 10:34

    tomkralidis on master

    Update SECURITY.md (compare)

  • Sep 20 20:17
    francbartoli commented #630
  • Sep 20 12:47
    ksonda commented #690
  • Sep 20 01:01
    metmikel opened #782
  • Sep 20 01:01
    metmikel labeled #782
  • Sep 20 00:13
    tomkralidis commented #677
  • Sep 19 23:46
    tomkralidis closed #133
  • Sep 19 23:38
    tomkralidis closed #346
Sander Schaminee
@GeoSander
That could be an idea yes
paul van genuchten
@pvgenuchten
but what if pygeoapi is used outside a web-request scope
for example to render something in a desktop application
(not sure if that is possible)
the desktop app would need to mimic a web request to feed to the provider?
1 reply
Sander Schaminee
@GeoSander
Me neither :)
paul van genuchten
@pvgenuchten
to me parsing request parameters is something which should be managed in a generic module, not in a provider...
Sander Schaminee
@GeoSander
It is handled in the l10n module actually (using the get_plugin_locale function), but because the provider stores that locale property now, the provider calls that function
paul van genuchten
@pvgenuchten
but it makes sense to have some base-parameters wrapped in an object, which is send with every provider-call
Francesco Bartoli
@francbartoli
Parameters from the request are parsed in the api.py not in the providers @pvgenuchten
paul van genuchten
@pvgenuchten
makes sense
Sander Schaminee
@GeoSander
]
\
"{
:]
paul van genuchten
@pvgenuchten
but then i miss the point here,
Sander Schaminee
@GeoSander
[;
Sorry, that was my kid...
paul van genuchten
@pvgenuchten
:-)
Sander Schaminee
@GeoSander
Typing while I was away
paul van genuchten
@pvgenuchten
so language, like format, would be parsed in api.py and then sent to the provider with relevant calls?
these base-parameters can be wrapped in an object, so we wouldn't need to extend each of the calls when we add an additional property (like schema)
Sander Schaminee
@GeoSander
We could also find the best match for the requested provider language in api.py(we already have the provider definition there too) and pass that as a Babel Locale to the provider (e.g. in the query call). That would keep the providers "clean" while still keeping it semi-intuitive.
Sander Schaminee
@GeoSander
Experimenting a bit now...
How would you guys suggest passing the language to the query (and get) function? Simply add a language=None parameter? This means I'll have to change all the signatures for each provider query function. Then we'll have a parameter in there that most providers won't need. Changing the signature to just have **kwargs would also be a possibility and more future-proof, but we'll have to document this properly (like @tomkralidis did for the new XarrayEDRProvider), else developers will be in the dark as to which items are available in the kwargs dict.
Any other suggestions?
Sander Schaminee
@GeoSander
I guess that the best solution to do this would be to append a **kwargs dict to all provider query method signatures. The creators of providers that need an explicit language parameter could always add that to their query method and it would still work for the other provider classes.
Sander Schaminee
@GeoSander
I have created the an alternative PR geopython/pygeoapi#664. Please let me know what you guys think :)
Tom Kralidis
@tomkralidis
Hi Sander: I can take a deeper dive into this following Wednesday.
Sander Schaminee
@GeoSander
Great, thanks!
Tom Kralidis
@tomkralidis
nice demo of pygeoapi and OAProc at today’s OGC EO Exploitation DWG meeting — nice work @totycro !
rtrm
@freenode_rtrm:matrix.org
[m]
hello
Tom Kralidis
@tomkralidis

hey all: reminder of the 3 pygeoapi sessions at this Wednesday’s OGC Developer Track: https://github.com/opengeospatial/developer-track#agenda

@pvgenuchten, @francbartoli and myself will be presenting on OATiles, OARec, and OAProc.

paul van genuchten
@pvgenuchten
tom the timing on github is ok? on ogcmeet.org agend it indicates:
image.png
Tom Kralidis
@tomkralidis
@pvgenuchten (cc @francbartoli) . All times are EDT per the agenda.
paul van genuchten
@pvgenuchten
so the records track is at 15:15 - 17:15 edt, because ogcmeet.org indicates it at 11:15 AM - 12:45 PM edt
Tom Kralidis
@tomkralidis

@pvgenuchten @francbartoli from Gobe:

The agenda on the GitHub repo is authoritative.

https://github.com/opengeospatial/developer-track/discussions/4#discussioncomment-515138

Tom Kralidis
@tomkralidis
@pvgenuchten @francbartoli I am sending out the slides tomorrow at 13h UTC FYI. Let me know if this is okay.
Francesco Bartoli
@francbartoli
+1
Looking at the deck right now. Since I’m block 1 I guess slides 2-6 is up to me @tomkralidis?
Francesco Bartoli
@francbartoli
or they are meant to be shared for each pygeoapi block?
paul van genuchten
@pvgenuchten
i added those slides francesco, just to have some content, please update to your liking, openlayers is a nice-to-mention but probably too early to actually use?
but i guess we can also use it as a xyz tile source
Francesco Bartoli
@francbartoli
Yes I’m not going to use it but I can mention
paul van genuchten
@pvgenuchten
are you using leaflet instead?
Francesco Bartoli
@francbartoli
the pygeoapi template is using leaflet yes
with a plugin
Tom Kralidis
@tomkralidis
slides 1-6 are core for all pygeoapi exercises I think
Tom Kralidis
@tomkralidis
@pvgenuchten @francbartoli putting finishing touches on presentation and then sending out (in an hour)