Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Andrea Aime
    @aaime
    I like integrity yes
    Brad Hards
    @bradh
    The advantage of doing it on the Info class is that it keep
    S things localised.
    A comparitor class might also be valid though.
    Maybe can be shared among the info classes with some magic superclass or interface additions.
    Andrea Aime
    @aaime
    Back in the day we were using inheritance a lot, but think we moved more and more onto "composition over inheritance"
    Was a hot topic some 10 years ago, funny though, being talked about to date it seems: https://medium.com/better-programming/prefer-composition-over-inheritance-1602d5149ea1
    Andrea Aime
    @aaime
    The "magic superclass" could be a "NamedCatalogInfo" interface, going more or less like this:
    public interface NamedCatalogInfo {
         String getName();
    
        default int compareByName(NamedCatalogInfo other) {
             return getName().compareTo(other.getName()); // null handling missing here
        }
    would like to hear @jodygarnett opinion about this approach
    Brad Hards
    @bradh
    I'm looking at the existing inheritance hierarchy, and PublishedInfo already has getName(), so a Comparitor could be in terms of PublishedInfo.
    Andrea Aime
    @aaime
    Yes that too. The above suggestion would expand the reach to StoreInfo (and maybe StyleInfo) too
    although one might want to compare by qualified name too
    that's why I tend to lean towards external comparators, there are so many ways comparisons can be done
    al-tabb
    @al-tabb
    @aaime Thanks, I wasn't aware of the developer manual! I'll give it a read
    Peter Rushforth
    @prushforth
    Hi, I am trying to build and run a geoserver.war from current snapshots (with my community module code on top). My module runs into an Maps4HTML/geoserver#21. I would like to build and run a version of GeoServer from around the middle - end of last November, but is that possible, given the snapshots are generated (and thrown away?) each day? I would like to see if the problem is something I did or if it's a regression elsewhere. Thanks!
    Andrea Aime
    @aaime
    @prushforth use git to checkout a revision of geotools/geowebcache/geoserver all at the same date
    if you want the module to get better protection against these issues, you should consider applying for graduation, if/when that happens you'll get the test of the module run along with the build
    al-tabb
    @al-tabb
    Hi, I'm still in the process of building geoserver and I think I am getting close. I've switched to Intellij and find it much more user friendly. I've followed the steps in the developer manual and have gotten the following error when running a 'mvn clean install' on wcs1_1: Failure to transfer org.geoserver.security:gs-sec-jdbc:2.19-SNAPSHOT/maven-metadata.xml from https://maven.geo-solutions.it/ was cached in the local repository, resolution will not be reattempted until the update interval of geosolutions has elapsed or updates are forced. Original error: Could not transfer metadata org.geoserver.security:gs-sec-jdbc:2.19-SNAPSHOT/maven-metadata.xml from/to geosolutions (https://maven.geo-solutions.it/): Transfer failed for https://maven.geo-solutions.it/org/geoserver/security/gs-sec-jdbc/2.19-SNAPSHOT/maven-metadata.xml
    Please let me know if there is a more appropriate place to ask this question.
    Andrea Aime
    @aaime
    @al-tabb odd, it should have picked it from the main geoserver repository, the geosolutions one is in the list only because there are extra jars popping up there
    I believe maven is giving you an error based on the last repo it visited
    Just to be sure, you're working on the master branch right?
    al-tabb
    @al-tabb
    Yes, I'm on the master branch
    Andrea Aime
    @aaime
    Every time an IDE messes up (which is frequent enough) I drop on the command line, do a full build with maven, and then refresh... that typically fixes things
    al-tabb
    @al-tabb
    @aaime OK I'll give it a try. Thanks
    al-tabb
    @al-tabb
    @aaime Success! I did have to run 'mvn -DskipTests clean install' however in order to get a build success
    Andrea Aime
    @aaime
    works fine with full tests on my machine, jenkins build server, github actions on both linux, osx and windows... but yep, there are a few random failures in the build
    Brad Hards
    @bradh
    @aaime Thanks for ogcapi review. I have some more functional changes in work.
    Andrea Aime
    @aaime
    @bradh awesome
    Peter Rushforth
    @prushforth
    @aaime thanks, good plan, will give that a try!
    Peter Rushforth
    @prushforth
    @aime I built, tested and ran the changes in my community module's feature branch against the 2.18.1 tag, but I get the error described here Maps4HTML/geoserver#21 when trying to do the same on the 2.18.2 tag (I notice it's changing right up to today). I think the issue I'm having is related to GEOS-9800. I notice in that issue you suggest alternative setup possibilities (maybe instead of GWC.get()?). Do you have a link to descriptions of these alternatives? Thanks!
    al-tabb
    @al-tabb
    @aaime Just wanted to thank you for your help in getting me started. I've now put in a JIRA issue (GEOS-9865) and pull request for the new feature!
    Andrea Aime
    @aaime
    @prushforth if you need GWC during startup, your spring beans better depend on it explicitly in the spring context
    @al-tabb always happy to help a fellow developer
    Peter Rushforth
    @prushforth
    @aaime right thanks
    Peter Rushforth
    @prushforth
    @aaime that fixed it, thanks for your help!
    Andrea Aime
    @aaime
    awesome :-D
    if you have at least 3 users and some time to put on it, I'd recomment pushing the module for extension status
    it's going to avoid unpleasant suprises in the future (well, at least some!)
    Peter Rushforth
    @prushforth
    Yes, I'll try. It's a matter of improving test coverage. Re-starting development after putting down tools for a while is always painful initially, and I tend to want to work on this exclusively once I get going again, as the ideas just grow like daisies.
    Andrea Aime
    @aaime
    Love the methaphor :-D
    Peter Rushforth
    @prushforth
    :-)
    Brad Hards
    @bradh
    Should I split up the github workflow into separate jobs?
    Andrea Aime
    @aaime
    @bradh that would be useful, we can restart only the part that glitched due to network downloads
    Brad Hards
    @bradh
    It seems like GH really wanted to be able to restart individual jobs (because its a pulldown element in the UI), but didn't implement it all (because its "all or nothing")
    Andrea Aime
    @aaime
    yup
    sounds like a "temporary situation" that became permanent