by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jody Garnett
    @jodygarnett
    Can we get the exact mvn command that is failing?
    James Hughes
    @jnh5y
    @jodygarnett I pulled this command from the Jenkins
    mvn -f pom.xml clean install -Dall -fae -T4 -Dqa -Dfmt.action=check
    I tried locally with JDK 8 and it was happy
    Jody Garnett
    @jodygarnett

    running with java 11 gives me:

    [ERROR] Failed to execute goal com.coveo:fmt-maven-plugin:2.4.0:format (default) on project gt-grid

    restarted java11 build here https://build.geoserver.org/view/geotools/job/geotools-master-java11/78/
    Jody Garnett
    @jodygarnett
    Build had trouble with oracle jdk11, works on openjdk11, ... now running with -Dqa=true
    Jody Garnett
    @jodygarnett
    Still bad:
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default) on project geotools:
Failed during checkstyle execution: Unable to find configuration file at location: /var/lib/jenkins/workspace/java11/geotools/build/qa/checkstyle.xml:
Could not find resource '/var/lib/jenkins/workspace/java11/geotools/build/qa/checkstyle.xml'. -> [Help 1]
    James Hughes
    @jnh5y
    bizarre.... it cannot find this file: https://github.com/geotools/geotools/blob/master/build/qa/checkstyle.xml ?
    I'm outta time to look right now; let me know what I can do to help later
    Andrea Aime
    @aaime
    @jodygarnett you probaly still have the overlapping workspaces
    across all java 11 builds
    Jody Garnett
    @jodygarnett
    Across the different branches of java11 builds eh?
    Andrea Aime
    @aaime
    yep
    Jody Garnett
    @jodygarnett
    How do we change that
    Andrea Aime
    @aaime
    I think you go in each build, there is an advanced section, hidden by default, reporting the workspace
    @tbarsballe was saying it's already correctly setup for the non java11 builds
    Torben Barsballe
    @tbarsballe
    Specifically, under the “Advanced” button that comes right after “Restrict where this project is run”, you can set a custom workspace. All the branches have their own workspaces (shared between the core build, the nightly, and the doc build), but all the java11 builds just share the “workspace/java11” workspace.
    Jody Garnett
    @jodygarnett
    okay so we need workspace/java11master, workspace/java11a, workspace/java11b or something ...
    Jody Garnett
    @jodygarnett
    okay setup workspace/java11master jobs and are letting them run now
    Jody Garnett
    @jodygarnett
    Some good news, that approach appears to be working: geotools and geowebcached built, geoserver is started
    Andrea Aime
    @aaime
    To see if it really works you need to run multiple java11 builds in parallel, from different versions
    dhlambert
    @dhlambert
    Hi, there has been some work done around fixing issues https://osgeo-org.atlassian.net/browse/GEOS-9684 and https://osgeo-org.atlassian.net/browse/GEOS-9667 with corresponding pull requests. Just wondering if this is on the right track?
    Brad Hards
    @bradh
    @dhlambert I can't comment on the technical changes, but typically these PRs will take days to weeks to get reviewed. It depends on how much volunteer effort is available from those with expertise on that part of the code base, and these are unusual days...
    Jody Garnett
    @jodygarnett
    image.png
    Okay @aaime / @tbarsballe it is set up for each branch now
    Brad Hards
    @bradh
    @jodygarnett In the work on JTS, it looks like the top level pom declares 1.3.9, but the module says 1.3.7.
    Possibly we could remove the top level declaration, just use the per-module thing, and then we could use their repo as a reference in the module pom.xml
    Gah.
    For https://github.com/geotools/geotools/blob/master/modules/unsupported/mbtiles/pom.xml#L102 (no.ecc.vectortiles)
    dhlambert
    @dhlambert
    @bradh Thanks for the reply, I'm aware that it all will depend on time availability. Just making sure its on the right track, when someone has some time to have a look.
    Jody Garnett
    @jodygarnett
    Ah. The top level dependency management version should be used. Plugins should not provide a version number (in part so we can manage version upgrades across projects).
    Do you want to remove version from the module @bradh? And thanks for catching the inconsistency.
    Jody Garnett
    @jodygarnett
    @bradh please see geotools/geotools#3068
    Brad Hards
    @bradh
    @jodygarnett Approved and merged it.
    Jody Garnett
    @jodygarnett
    oh good thank you
    Brad Hards
    @bradh
    I was really just trying to avoid you having to upload to osgeo repo.
    Jody Garnett
    @jodygarnett
    I think you saw that I setup your repo to be mirrored by osgeo
    Brad Hards
    @bradh
    not my repo.
    Jody Garnett
    @jodygarnett
    ah okay
    thinking
    Brad Hards
    @bradh
    Solves the problem though.
    Jody Garnett
    @jodygarnett
    I would prefer to follow the geotools dev guide and upload specific jars as needed, rather than blindly cache
    ... but I guess this is low effort
    Brad Hards
    @bradh
    (or addresses my concern about manual work).
    Jody Garnett
    @jodygarnett
    thanks for reviewing, and lets keep an eye on this ...
    Brad Hards
    @bradh
    If you'd prefer to upload, thats certainly OK with me.
    Jody Garnett
    @jodygarnett
    I also like less manual effort; so let's see how this goes :)
    Brad Hards
    @bradh
    Or you're just more comfortable with that, then no problem.
    Jody Garnett
    @jodygarnett
    We collect a lot of jars over time, so some balance is needed to avoid depending on dozens of repositories.
    Brad Hards
    @bradh
    I hoped that having it in the only location that it is used would be enough to keep the complexity down, which is why I removed the top level.