Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Carlo Cancellieri
    @ccancellieri
    Yep, I thought that, but the challenge is to check the biggest request, but definitely it make sense to have a limit... let me check we should have...
    Andrea Aime
    @aaime
    limit times the concurret requests allowed by control flow, and you get how much heap you need
    (well, add 1GB for the rest of GeoServer)
    Carlo Cancellieri
    @ccancellieri
    Good point, I'll do that in a different environment. the WMS limit was not set... :( thank you all :)
    Carlo Cancellieri
    @ccancellieri
    I set that even if it's also on the controlflow, anyhow it will probably not help so much, the estimated size of the rendered image is rarely reached the problem in this case is the number of touched resources and something which is not going well with the memory management which grows rapidly (i'm over geoserver 2.18.0 + adoptjdk11 and 'all' the 'recommended' settings for production).
    Jody Garnett
    @jodygarnett

    @jnh5y for the JTS upgrade for geoserver - it has some failure

    geoserver/geoserver#5258
    geotools/geotools#3617
    GeoWebCache/geowebcache#982

    Does this need to be done in conjunction with GT and GWC prs? I think you have a CI integration build showing the combo is successful.

    James Hughes
    @jnh5y
    only one of the GS jobs failed
    re-running it
    James Hughes
    @jnh5y
    the GS build has green checks now!
    Gotta continue my streak of 1 line PRs:)
    Jody Garnett
    @jodygarnett
    Thanks James, it is a minor update indeed (only changing version number)
    Is there anything for the upgrade instructions, perhaps how to enable/disable overlay ng ?
    2 replies
    Björn Harrtell
    @bjornharrtell
    Getting fairly inconsistent results attempting to build and test GeoServer with Java 17. But at least one dependency sticks out as especially problematic and that is cglib-nodep used in core stuff like GetFeature.java. cglib appears stagnant and depends on asm 7. Asm added JDK 17 support in version 9.
    Issue has been filed since April - cglib/cglib#191.
    Björn Harrtell
    @bjornharrtell
    Looks like the only place cglib is used is in GetFeature.java (https://github.com/geoserver/geoserver/blob/f732201d424c0aaf9545b2d0858016ea636450d5/src/wfs/src/main/java/org/geoserver/wfs/GetFeature.java#L705-L717) so perhaps that can be reworked.
    Andrea Aime
    @aaime
    @bjornharrtell that bit is an important element vs performance, it allows to lazily comput the feature count (something much complained and maligned about)
    a rework might need to rewrite the EMF generated classes.... which requires goat killing, the right moon, and the right version of Eclipse, and someone willing to use that abomination
    4 replies
    (not Eclipse per se, I'm talking about the EMF code generator)
    Björn Harrtell
    @bjornharrtell
    @aaime: it looks like it was somehow taken care of in springframework 5.3 (they import cglib with some quirks and things in place)... but upgrading to that looks like it needs servlet-api 4.0.1.
    Andrea Aime
    @aaime
    ugh
    which implies minimum version of Tomcat to use GeoServer to be 10 I believe
    and a bunch of import changes, at a minimum
    upgrading spring also brings an upgrade of spring-security, which we are strongly tied to, even on the internals... might be annoying
    I was also reading about wicket using cglib and having troubles.. wicket upgrades have been very painful so far
    Björn Harrtell
    @bjornharrtell
    Looks like Tomcat 9 is enough.
    As for Jetty, 10 is required.
    And well, didn't expect this to be easy :D
    Björn Harrtell
    @bjornharrtell
    Not sure but perhaps the use of cglib can be replaced with objenesis?
    Andrea Aime
    @aaime
    Maybe
    or maybe there is a newer cglib in the works with fixes? who knows
    Peter Rushforth
    @prushforth
    I opened a geoserver/geoserver#5259 that depends on a recently merged geotools change geotools/geotools#3620, and I'm not sure how to get the workflow to use the most recent gt-xml SNAPSHOT artifact. Can anyone give me a hint how to re-run the workflows with updated artifacts? Thanks!
    Andrea Aime
    @aaime
    @prushforth I actually restarted them a few hours ago
    Peter Rushforth
    @prushforth
    Me too, but the artifacts seem to be old e.g.: https://repo.osgeo.org/repository/snapshot/org/geotools/gt-xml/26-SNAPSHOT/gt-xml-26-20210818.092924-109.jar
    Peter Rushforth
    @prushforth
    I was able to reproduce the build error on my machine by building with gt-xml artifacts from the snapshot repo instead of my locally built repo. It seems the osgeo snapshot repo is not up to date with the geotools code, so there's nothing to be done on the geoserver side that will change that. I can just wait until the osgeo repo is updated. Thanks for your help!
    Andrea Aime
    @aaime
    The gt-main build has been broken for a number of days it seems
    Peter Rushforth
    @prushforth
    OK I reported it sort of on the geotools developer list. If it's broken I guess it's my duty :-)
    Jody Garnett
    @jodygarnett
    I sent a couple emails to geotools-devel list, the builds are indeed failing right now.
    Andrea Aime
    @aaime
    I sent a PR that might solve the issue
    the thing is, the biulds are not failing locally, nor in the PR checks
    just on the build server
    Daniele sent a mail the other day about disk space being exhausted, I could not follow up yet
    Brad Hards
    @bradh
    If I was looking to make a coverage provider, do I really need the RenderedImage part of https://docs.geotools.org/stable/javadocs/org/geotools/coverage/grid/GridCoverage2D.html ? I have a DTED parser, and looking at whether I can just present the whole world as a coverage without needing the image.
    Brad Hards
    @bradh
    Oh, is the important part GridCoverage2DReader, and the GridCoverage2D is just the sub-part that I'm handing back?
    Andrea Aime
    @aaime
    You're handing back a GridCoverage2D, which wraps a RenderedImage that contains the actual data
    you might want to look at the Gtopo30 module I just removed, it's likely pretty close to what you need
    Brad Hards
    @bradh
    Thanks @aaime
    Nasir Rashid
    @nextgen-pk

    Hi everyone, i'm getting following error when "Test Connection" on GeoFence Admin Page, on geoserver 2.17.2, using it with Geonode 3.1.0 (dockerized), due to which i think am unable to upload/edit layers in geonode.

    org.springframework.transaction.CannotCreateTransactionException: Could not open JPA EntityManager for transaction; nested exception is javax.persistence.PersistenceException: org.hibernate.exception.GenericJDBCException: Cannot open connection

    Can anyone please guide me how to fix it? Thank you

    Brad Hards
    @bradh
    I am not familiar with your configuration but you should at least upgrade to current releases. Possibly the docker configuration is bad? Does it work with a base build of just geoserver? If so, maybe you should ask on a geonode mailing list or forum.
    Jody Garnett
    @jodygarnett

    Can I ask for a review of geoserver/geoserver.github.io#109

    (and also geoserver/geoserver#5282 fixing some documentation issues noticed with new content)

    Andrea Aime
    @aaime
    @jodygarnett reviewed a few hours ago (just the announcement though)