by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Andrea Aime
    @aaime
    "lightweight Java object model" music to my ears
    Jody Garnett
    @jodygarnett
    digging into the details shows it is under active development with a 2020 release

    it seem to be @aaime bait:

    Apache XMLSchema is quite a versatile piece of code that can be used to manipulate and generate XML Schemas. It has minimum dependencies and can be used inside another project with ease.

    James Hughes
    @jnh5y
    now we just need to find the open source project which helps people automatically rewrite swathes of code from EMF to their project:)
    Jody Garnett
    @jodygarnett
    Since we often used the generated EMF objects get/set methods it is not as terrible to migrate to POJOs as it could be. It is not like we really cared about the event notification to my knoweldge
    Andrea Aime
    @aaime
    All object creation needs re-doing
    damn factories :D
    Jody Garnett
    @jodygarnett
    blah
    Andrea Aime
    @aaime
    Names of the classes are also pretty horrible, but guess we might have to live with that
    GetFeatureType ... why Type dammit :-p
    Jody Garnett
    @jodygarnett
    if only java interfaces supported constructors
    Brad Hards
    @bradh
    @aaime for the diamond work, where is the coordination document?
    as I mentioned on the list, I started trying to help a little today
    Brad Hards
    @bradh
    I have some time, will take a look.
    James Hughes
    @jnh5y
    cool
    I added the column that gives a (rough) count of the number of warnings in each module
    since I'm not familiar with these warnings, I found starting with a smaller module helpful to warm up
    Brad Hards
    @bradh
    Have requested edit.
    May need to look at the changes that have already gone in. Appears that Param is a widely shared problem.
    Brad Hards
    @bradh
    I submitted a PR for the VPF module. I can't update the spreadsheet yet though.
    Andrea Aime
    @aaime
    @bradh there is no diamond sheet because we believe it can be done by one person in one shot, with some grep/sed and a pass of manual fixes
    the main issue is anonymous inner class creation, which cannot accept diamond usage
    creating a regex that handles that case too may be challenging
    Brad Hards
    @bradh
    @aaime thanks. I really meant the unchecked warning thing.
    Of course, I couldn't help myself doing a few diamond changes too...
    Andrea Aime
    @aaime
    You have access to the sheet now
    Added a note on the sheet on what I've used so far for diamond, along with its limitations
    one of them, the multiparam, should be easy to fix
    the second one, anonymous inner class, probably harder
    As the old adage says... "You tried to solve a problem with a regex.... now you have two problems"
    Brad Hards
    @bradh
    Oh yes.
    Brad Hards
    @bradh
    Grr, managed to change behaviour.
    Brad Hards
    @bradh
    Is there a preferred way to make dependencies respect the JDK (or potentially runtime)? Trying to do the JavaFX module, but the tests are b0rken with JDK8. I can just revert the problematic one to get it building again, but presumably that will break with JDK11.
    Jody Garnett
    @jodygarnett
    that is tricky
    we have some filters for like "online" tests
    Brad Hards
    @bradh
    Those are words to inspire confidence :-)
    Jody Garnett
    @jodygarnett
    I wonder if you could make a filter for Java8 or Java11 tests, and then use a profile (activated by jdk version) to enable?
    So "yes" we have a way, but "no" it has not been used for this yet :)

    See https://github.com/geotools/geotools/blob/master/pom.xml#L84

        <online.skip.pattern>**/*OnlineTest.java</online.skip.pattern>

    Enabled using:

         <profile>
          <id>online</id>
          <properties>
            <online.skip.pattern>disabled</online.skip.pattern>
          </properties>
        </profile>
    Brad Hards
    @bradh
    So maybe I can rename the test class from FXMapTest.java to FXMapJDK11Test.java and do the same kind of profile thing, which would get enabled in the JDK11 Travis builds?
    Seems a little hacky, but its one unsupported module that isn't even in the build right now.
    Brad Hards
    @bradh
    @aaime Do the PMD checks work at module scope? So if It works with -Dqa at the module level, is that enough?
    (in relation to the javafx re-add).
    If the fixes are easy, I'll do those, otherwise I'll drop the part of the change to put it back in to -Dall
    Andrea Aime
    @aaime
    @bradh yep that works
    The PMD checks can be disabled on a per module basis, I did for the autogenerated EMF modules for examples
    but those are beyond salvation, they are not meant for hand editing
    I'd avoid having modules around that could make the cut, but did not because of lack of resources
    Brad Hards
    @bradh
    OK. Happy to leave that module out of it - more effort than its worth.