Also, I realized other problems like our boolean handling for non-postgres dialects was fundementally broken and unless we introduce a notion of BooleanValue/BooleanExpression into the AST as types, issues like #1685 can never, ever be properly addressed.
Additionally, after struggling to get quill-spark expansions to work with complex subqueries (having already rewritten the whole mechanism several times), I realized that this machinery is highly dependent on knowing the field-names of select values in super-queries. Things like #1843 are symptoms of this problem but it goes far, far deeper.
Finally, because of the brittle nature of RenameProperties, doing infix operations on renamed columns (and tables) can break query-schema renaming and yield bad results. #1625 is just one symptom of this.
Based on all of these things, I have realized that Quill's AST needs to be substantially changed in order to accommodate some level of typing of root-level elements such as Idents, Entities, and Infixes. This is a substantial change to the core mechanisms operating inside of Quill and doing anything to change them has massive ripple effects throughout the system. Due to this, I have attempted not to make this level of change for the past two years but I recent months I've realized it absolutely has to be done.
Additionally, because inferring Ident-level AST has consequences on Quill-Dotty as well, I decided to make this change now before "that" system evolves to the point where changes of this magnitude require substantial rewrites.
I hope that this explains some of my motivations and the reasons I have been out of the daily loop for so long. I know we have to push out new context with better async handling and I will work on this as soon as I have a free moment.
1 reply
I'm also struggling to create Postgresql enum encoders/decoders for an async context (Finagle, in my case). The guide in the README that involves
encoder(java.sql.Types.OTHER, (index, value, row) =>
row.setObject(index, value, java.sql.Types.OTHER))only works with a jdbc context. Has anyone had this problem, or am I misunderstanding the api?
select * from cycles where ARRAY[1,9] <@ features;implicit class ArrayOps[T](array: Seq[T]) {
def containsValue(value: T) = quote(infix"ANY($array) = $value".as[Boolean])
def containsValues(values: Seq[T]) = quote(infix"$values <@ $array".as[Boolean])
}
Hello, dear Quill community!
I am using quill as my application's query engine by migrating from an old SQL based persistence engine.
I have the need to access the mapping of the attributes of a case class to the definition of the columns of the database.
I will create a Wrapper for my old classes to the new syntax, how could I access the tuple to know which class case attribute corresponds to the column of the database?
schemaMeta[AgreementClauseCategory] ("SAgreementClauseCategory", .clientId -> "AD_ClientID", .orgId -> "AD_OrgID", .created -> "Created",
.createdBy -> "CreatedBy", .description -> "Description",
.help -> "Help", .isActive -> "IsActive",
.name -> "Name", .agreementClauseCategoryId -> "S_AgreementClauseCategoryID", .uuid -> "UUID",
.updated -> "Updated", .updatedBy -> "UpdatedBy",
_.value -> "Value")
AgreementClauseCategorySchemaMeta.entity.getDBColumns.foreach { (columntName, value) =>
//Legacy Persistence code
val contract = new MSContract(Env.getCtx, 0 , null)
contract.set_ValueOfColumn(columntName, value)
}
Hi, Sorry if this is a basic question, i have a table defined by
case class Person(id: Long, age: Int)and i would like to run a query where the result is for each age, a list of all the ids with that age (so the return type should eventually be Seq[(Int, Seq[Long])]). I've tried
quote(query[Person].groupBy(p => p.age).map(x => (x._1, x._2.foreach(_.id))))but i get an error saying No implicit view available from Long => A. Any insights into what i am doing wrong?
Is there a way to specify a particular namespace in Postgresql?
As an example, I have a namespace auth that contains a table role defined like below:
CREATE TABLE auth.role
(
id integer NOT NULL,
name character varying,
CONSTRAINT role_pkey PRIMARY KEY (id)
)ctx.run(quote{query[Role]}) produces the following script that doesn't run when executed directly on postgres: SELECT x.id, x.name FROM role x.
Hi everyone. I'm working on a project using quill with postgres and during some profiling I've seen a huge amount of time spent in quill (not postgres). We have some helper functions like:
def queryVisibleToTenant[T <: FilterableEntity,
U <: FilterableTenant](tenantId: UUID)
(implicit t: SchemaMeta[T], u: SchemaMeta[U]) = {
quote {
query[T]
.join(query[U])
.on((_, te) => te.id == lift(tenantId))
.filter(eTe => infix"${eTe._1.lft} BETWEEN ${eTe._2.lft} AND ${eTe._2.rgt}".pure.as[Boolean])
.map(_._1)
}
}Which we then use like so:
val q = quote {
queryVisibleToTenant[MyFilterableEntity, MyFilterableTenant](tenantid)
.join(query[MyFilterableEntity])
.on((fe, ft) => fe.id == ft.id)
.map(_._2)
.filter(_.id == lift(primaryKey))
}
run(q)This and others seems to be very very expensive for quill to process. I can post jprofiler screenshots if anyone is interested (and may be bug-worthy in it's own right). I'm wondering if there's some way of preserving the code-reuse of queryVisibleToTenant while speeding this up. If I inline the code from queryVisibleToTenant the query presumably returns to being non-dynamic and generated at compile time and there is a massive speedup.
.get functions on them and they all lead to these three places in quill being hotspots. Not all of them are using the above snippet but I've manually inlined that function, reprofiled and observed that it went away.
I’m suddenly getting these compile errors which has been compiled fine before.
[error] ……. : not found: value Ord
[error] .sortBy(_._3)(Ord.desc)I think DSLs such as Ord or Query should be imported by import ctx._.
I’m not sure what triggered this issue. I was just messing around sbt and scala version.