These are chat archives for getredash/redash

25th
Jun 2015
Cory
@clevinson
Jun 25 2015 14:42
@arikfr i think i've found a bit more detail about the issue with the web text-editor in redash
that my coworkers were having
and i can now replicate the issue
can you let me know what library / plugin you use to render the query editor? or is it all built by you?
Arik Fraimovich
@arikfr
Jun 25 2015 14:47
@clevinson it's CodeMirror. I'm curious, what are the steps to reproduce? Is it something you can do on the demo instance?
Cory
@clevinson
Jun 25 2015 14:58
hmm
trying, but having issues
seems related to this issue
codemirror/CodeMirror#1787
Arik Fraimovich
@arikfr
Jun 25 2015 15:05
@clevinson it looks like it was fixed a while ago, and I'm almost sure we run with a more recent version. if you have STR, I can try to reproduce and then see if newer version fixes it
Cory
@clevinson
Jun 25 2015 15:08
@arikfr ha!
got it!
:)
and i figured out exactly what is causing it (not in code, but in UI) and why this was only introduced with the latest release
@arikfr seems the bug only happens for lines that get automatically soft wrapped when the schema browser div is rendered
i tried reproducing with queries that have a softwrap when the browser resizes, but i couldn't reproduce it that way.... the bug only seems to happen when somehow the codemirror div get's resized by javascript and a soft wrap is introduced
Arik Fraimovich
@arikfr
Jun 25 2015 15:21
@clevinson that's really helpful! I'll see if I can tell CM to remeasure itself. Thanks!
Cory
@clevinson
Jun 25 2015 15:26
cheers! i've told our team-mates to try to just use short lines and add some carriage returns to any super long lines to avoid this bug. So hopefully this won't be a problem for us anymore, but please let me know if you do find someway to fix this
Arik Fraimovich
@arikfr
Jun 25 2015 15:34
Sure thing. You'll be the first to know ;-)