These are chat archives for getredash/redash

8th
Nov 2016
Allen Short
@washort
Nov 08 2016 19:23
@arikfr Think you might have time to look at getredash/redash#1353 this week?
Arik Fraimovich
@arikfr
Nov 08 2016 20:24
@washort I hope so, although I will probably merge it only after 0.12 is released.
Allen Short
@washort
Nov 08 2016 20:50
@arikfr No worries :)
Arik Fraimovich
@arikfr
Nov 08 2016 20:51
@washort while you're here... how do you guys feel about Django?
Allen Short
@washort
Nov 08 2016 21:12
@arikfr Mozilla uses lots of Django, so fairly positive
Nearly all of my Python experience at Mozilla has been with Django (and Django REST Framework).
Arik Fraimovich
@arikfr
Nov 08 2016 21:12
I thought that maybe converting to Django's ORM will be easier as it supposed to be similar to Peewee. Only problem is that I need to convert the rest of the code then... but might get the benefit of using something like Django Rest Framework.
Have to admit, that until about two years ago every so often I was trying to create a new project with Django and shortly after giving up and going back to Flask. :)
Allen Short
@washort
Nov 08 2016 21:13
I'm not convinced it'd be a major benefit to switch at this point
Arik Fraimovich
@arikfr
Nov 08 2016 21:14
The options at the moment are:
  1. Create our own migrations for peewee (and implement other missing features - like optimistic locking that I did recently).
  2. SQLAlchemy + Flask.
  3. Django.
So the path forward seems to be either 1 or 2. At first I thought that maybe switching to Django will be less work because of the ORM similraties, but I'm no longer sure of that.
Allen Short
@washort
Nov 08 2016 21:15
My intuition is that sqlalchemy is the best overall choice, both in terms of final quality and difficulty of porting
django orm is not very similar to peewee in my experience.
Arik Fraimovich
@arikfr
Nov 08 2016 21:16
well it's definitely more similar than sqla :)
but I guess you're right
staying on course to switch to sqla
Allen Short
@washort
Nov 08 2016 21:17
OK. Let me know if I can help with that, I'm going to run out of stuff I can do for our internal customers in a week or two
also, @openjck is going to have time to assist with frontend stuff fairly soon
Arik Fraimovich
@arikfr
Nov 08 2016 21:18
I still don't know how much of effort it's going to be, but code review will definitely be welcomed.
Allen Short
@washort
Nov 08 2016 21:19
Sure, I definitely can do that :)
Arik Fraimovich
@arikfr
Nov 08 2016 21:19
do you recommend using flask-sqlalchemy? in some other project I used alchy (along with flask-alchy) which supposed to provide the same functionality but with less coupling to flask
Allen Short
@washort
Nov 08 2016 21:20
i am not familiar, i have little flask experience
Arik Fraimovich
@arikfr
Nov 08 2016 21:30
:+1: