Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 15 14:45
    kvark assigned #102
  • Sep 15 14:45
    kvark labeled #102
  • Sep 15 14:45
    kvark edited #102
  • Sep 15 14:45
    kvark commented #102
  • Sep 15 14:44
    kvark unlabeled #102
  • Sep 13 17:43
  • Sep 13 13:43
    seivan opened #114
  • Sep 13 02:44
    kvark opened #102
  • Sep 13 02:44
    kvark labeled #102
  • Sep 12 21:09

    kvark on master

    First step in converting a modu… (compare)

  • Sep 12 21:09
    kvark closed #87
  • Sep 12 20:02
    kvark commented #87
  • Sep 12 20:01
    kvark synchronize #87
  • Sep 12 16:57
    kvark commented #87
  • Sep 10 09:58
    sp4ghet starred gfx-rs/rspirv
  • Sep 10 07:11
    lavignes starred gfx-rs/rspirv
  • Sep 08 21:25
    Veykril starred gfx-rs/rspirv
  • Sep 08 03:08
    grovesNL commented #113
  • Sep 08 02:51
    grovesNL commented #113
  • Sep 08 01:56
    kvark commented #113
Dzmitry Malyshau
@kvark
Yeah
Jack Rickard
@AIOOB
@kvark Do you have any ideas as to how to represent SSA in memory? I've been thinking about it for a while now but it's surprisingly hard.
Dzmitry Malyshau
@kvark
Just a bunch of token<variable> isn't doing it?
Or rather, token<temporary> or something...
Jack Rickard
@AIOOB
The problem is that then we have to manually enforce the whole SSA thing, although I think we are going to have to hand enforce something,
I'm currently trying to work out what the easiest to enforce will be
The way Cranelift does it that I'm looking at now is having a Storage<Op>and then storing a Vec<Token<Op>> in the basic blocks
Dzmitry Malyshau
@kvark
Wait. Since every operation result is unique anyway, there should be no need to refer to the same operation more than ones, should it? Why can't it just be a Vec<Op>?
Jack Rickard
@AIOOB
Mostly because instructions need to reference other instructions and it's hard to create a stable way to do that
The result can be used by multiple instructions
I really wish we could use enum variants as types :cry:
Dzmitry Malyshau
@kvark
Oh I see. We either box them inside, or do Token<Op> then.
Jack Rickard
@AIOOB
Exactly
May as well stick em in an arena, which is what I'm converting Storage into atm
Although there are lots of different arena crates and working out the differences is quite difficult
Dzmitry Malyshau
@kvark
Wait, how is storage not an arena?
Btw, I'm mostly offline till Thursday... can't check the code atm
Jack Rickard
@AIOOB
That's fine, I'm starting a new job next Monday so I'm probably going to drop off the radar for a while.
I guess storage is currently an arena, I was just going to use an actual arena crate to let us easily reclaim memory etc
Stuff like slotmap and generational-arena
Dzmitry Malyshau
@kvark
oh snap! man, I was so excited seeing you hacking this
fwiw, I don't think at this point we need to care about reclaiming memory
Dzmitry Malyshau
@kvark
@AIOOB perhaps we should focus on cleaning up and landing at least the stuff you already have
Jack Rickard
@AIOOB
I don't have any open PR's atm, and I can probably get a bit done this week.
Dzmitry Malyshau
@kvark
you have gfx-rs/rspirv#60
Jack Rickard
@AIOOB
I'm not really sure what to do with that one
Dzmitry Malyshau
@kvark
out of arguments convincing Lei? :)
Jack Rickard
@AIOOB
It's not actually getting out of date as it doesn't hit anything to do with sr.
The problem is that I still don't really understand where they're coming from.
It's quite funny seeing what everyone puts more emphasis on
Dzmitry Malyshau
@kvark
heh
I think Lei provides some good guidance. My concern was mostly about latency...
would you like me to get into the discussion and re-review the PR with Lei's notes in mind?
Jack Rickard
@AIOOB
I agree, they are a very useful moderating force.
I would be interested in your opinions, although I'm a bit wary because I sometimes feel like we can get a bit overwhelming if we agree.
Jack Rickard
@AIOOB
When will you be able to rebase your PR's? 87 is something I've been looking forward to for a while but it's a bit of a pain to review with all the extraneous changes.
Dzmitry Malyshau
@kvark
will do, but only closer to the end of the week...
Jack Rickard
@AIOOB
Ok, I may try to review the unique commits then.
Could you change the review style on reviewable to each commit separately?
Dzmitry Malyshau
@kvark
yes
Dzmitry Malyshau
@kvark
@AIOOB how is your occupation these days? Totally busy on the new work place?
Jack Rickard
@AIOOB
I'm alright, the biggest problem is that I don't currently have anywhere to set up my computer so I can't really do anything.
Dzmitry Malyshau
@kvark
Need a laptop?
Jack Rickard
@AIOOB
Sounds like you're offering! But no, I have a laptop but it would take a while to set up and doesn't really solve the problem of not having a good space to work at.
Dzmitry Malyshau
@kvark
ok. I can always figure something out and send you one.
Dzmitry Malyshau
@kvark
I'm so happy we got rid of those license headers!
Dzmitry Malyshau
@kvark
@AIOOB are you around for gfx-rs/rspirv#101 ?
Jack Rickard
@AIOOB
Possibly, but I'm out of the country over the weekend, so maybe not.
Dzmitry Malyshau
@kvark
@AIOOB are you back to review gfx-rs/rspirv#87 ?