These are chat archives for gianlucadelgobbo/avnode

12th
Jan 2016
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 12:28
are you there?
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 12:51
Yes, sorry but I didn’t get that notification from yesterday.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 14:59
how is going?
we need your help
the master is quite old and we need to understand how to have it updated at the last one at least
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 15:05
Well, how can I help? I can’t see any recent changes or pull requests.
And as far as I know I’m not able to accept any pull requests by the way.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 15:39
was done in the master
we have a backup
is more or less 1 month of work of 2 people
mainly
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 15:41
And you want me what to do, now?
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 15:41
we need to update that part
but the structure is very different
also the db
there is all the settings for the submission
and the part to save the subscription
we have to be ready in a few days now
we need to open the call
and the submission was done
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 15:42
Okay, wait a second.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 15:43
also the design of the event
with all the sub pages
and of the performer
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 15:43
I have to understand that first.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 15:44
ok
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 15:45
I thought Stefan and Andy told you the want to make a structure first.
Including mangoose and some jade improvements.
Before anyone start to develop new features.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 15:46
yes at that point we stopped
but that version is much older then the one at that moment
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 15:47
Well, than I guess those people you’ve mentioned have to refactor their work to be compatible with the current master.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 15:48
why they started from such an old version?
anyway we have backup but now we have to understand how to work with the new structure
most of the templates are empty
and also the single one the most dont do anything
so is hard to understand where to start from
for example all the submission form was based on step management very complex
where I have to go to put that code?
when we can work on this issue?
but...
if we was not making a backup
you was just trashing 2 month of our work?
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 15:53
seems a little crazy
or git have the backup?
you have used the version of the first time we meet
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 15:56
No, you don’t have throw that away.
But, I guess you have to refactor it.
All your database queries and stuff related to mongodb should be written in a way like andreas or stefan did.
Andreas Lappe
@alappe
Jan 12 2016 16:00
Ciao gianluca, i cannot be online very long
what exactly is missing on your part and how did it come
to that?
Everything that was ever committed in git is saved, as long as nobody deletes the directory... All history is stored and you can jump back to every point in time...
Andreas Lappe
@alappe
Jan 12 2016 16:10
As I have no computer with me, I cannot work on code until the weekend...
as you only ever committed to master before, your work very likely is in there, we just have to find it
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:23
ok
but anyway we have a backup
can I understand when you can focus on that project?
we are spending a lot of money...
Andreas Lappe
@alappe
Jan 12 2016 16:26
Stefan and me will be working on the project again from this weekend on, Patrick can work on it in the meantime if I know correctly...
What kind of backup do you have? How do you plan to restore that?
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:31
no no
but i can take some part if we cannot find it
maybe i can chat with patrick to understand how to work with the new structure
place some code already written could help us to understand how it works
Andreas Lappe
@alappe
Jan 12 2016 16:34
Yes, please speak to Patrick about it. What is the part you have been working on?
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 16:39
Have you tried to merge your part into the current master?
you just worked on copy of 2 month ago
anyway we have the backup
but let us understand where you can we can put it
patrick is here?
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 16:42
Yes, I’m right here :)
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:45
great
where is all the control panel?
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 16:50
Whats wrong with that part? I can see the controlpanel (when I’m logged in)
Stefan Isak
@stefanisak
Jan 12 2016 16:53
The controlpanel is the part I worked on recently.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:54
ok I cant see it
Stefan Isak
@stefanisak
Jan 12 2016 16:54
What you may miss is the old routes.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:54
Stefan Isak
@stefanisak
Jan 12 2016 16:54
Most of the controlpanel routes are to be refactored next.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:55
I can not see anything
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 16:55
Are you logged in?!
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:55

504 Gateway Time-out

nginx/1.4.6 (Ubuntu)

yes
Stefan Isak
@stefanisak
Jan 12 2016 16:56
Right now it's just the routes not resolving.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:56
ok
Stefan Isak
@stefanisak
Jan 12 2016 16:56
But most of the code is still in place.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:56
anyway this is not a problem because if is not done can be done on the last version
Stefan Isak
@stefanisak
Jan 12 2016 16:56
So it's more or less putting it together again.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:56
If you dont have it I sent it by email :)
but please do not use the one of 2 month ago
Stefan Isak
@stefanisak
Jan 12 2016 16:57
That's what I meant saying "bumpy road ahead".
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:57
Stefan Isak
@stefanisak
Jan 12 2016 16:58
And I guess we need to talk about Git soon ;)
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:58
anyway then the is all the templates that was done
I think this is not too hard to update it
Stefan Isak
@stefanisak
Jan 12 2016 16:58
I don't know what you mean by "old master".
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 16:59
Me neither…
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:59
but was much better if you was starting from the last
Stefan Isak
@stefanisak
Jan 12 2016 16:59
We used the latest master available.
There is no old master in that case.
I guess you may have local changes.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 16:59
you simpli started to from a version of 2 month ago
Stefan Isak
@stefanisak
Jan 12 2016 16:59
That never got pushed.
We can't fork a version that is just on your local machine.
Please insure that you commit all your changes and also push them e.g. to a feature branch.
If you don't have any local changes, then everything should be fine and we don't have an "old version".
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:02
yes the master we have now
is very old
but with your new structure
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 17:03
Okay, so we have to merge your latest commits into master again.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:03
anyway we do it
2 month of commits
but we do it
Andreas Lappe
@alappe
Jan 12 2016 17:03
The base for our fork was the latest master available in your repo, gianluca...
can you give us one commit id of your missing commits?
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:04
but please explain how the new structure work
no
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 17:04
You can simply create a new branch with your current master and push that branch to github.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:04
is of 2 month ago
if you want I share my screen on my last and you will see the difference
but is not a problem
Andreas Lappe
@alappe
Jan 12 2016 17:05
with 'git log' you get the history of all commits ever done in the branch...
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:05
is a good exercise for us to understand
Andreas Lappe
@alappe
Jan 12 2016 17:05
there should also be your commits with the corresponding ids
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:06
anyway
if now I need to add all the developmento for the participate, how I can do?
this is easy because you renamed performer.js into user.js
so the code is there
can you explain how to put that code in the new structure?
in this case you used the performer.js of 2 month ago
and also if i stopped working on it
you have not updated the file
now I have created the new route
based on your routes
app.get('/(:user)/events/(:event)/participate', userRoutes.getUserEventParticipate);
I need a post too
and till there is easy
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:11
now how to put all the case I have?
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 17:12
You know what merge means?
You dont have to put all those files together by hand…
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:13
is copletly different
you deleted and added a lot of file
many jade
are not there
Patrick Finkbeiner
@pfinkbeiner
Jan 12 2016 17:14
Yes, Stefan did this to reduce the complexity in the views
Andreas Lappe
@alappe
Jan 12 2016 17:14
They are mostly only moved and structured into directories per model
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:14
if you open routes/user.js and routes/performer.js
mostly
better all of 2 month ago
but now le me understand
please
Stefan Isak
@stefanisak
Jan 12 2016 17:18
Your route you wrote is right.
Andreas Lappe
@alappe
Jan 12 2016 17:18
Stefan is currently looking something up on his phone to guide you, give him a second... As said we are without computers on a fragile internet connection until the weekend...
Stefan Isak
@stefanisak
Jan 12 2016 17:18
Then proceed with the route itself.
Add methods you need to user.js and use the moongose API as you can already see in the same file.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:19
ok if you can not now is ok
I can wait
but this routes/performer.js
is a survivor
Stefan Isak
@stefanisak
Jan 12 2016 17:20
Exactly
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:20
all the jade that call where they are?
how I can merge that route in the user.js?
Stefan Isak
@stefanisak
Jan 12 2016 17:20
It's just there because not everything is already refactored. For example the post route.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:21
ok
Stefan Isak
@stefanisak
Jan 12 2016 17:21
Each route calls the respective jade template.
The templates make now more use of layouts mixins and partials.
And they almost never use inlined JS.
Put the template you need inside the view folder named after your route.
@gianlucadelgobbo is your performer.js different from this one?
Stefan Isak
@stefanisak
Jan 12 2016 17:35
@gianlucadelgobbo I have to go now. You can't merge performer.js and user.js automatically as user.js is more or less new code. Besides the JSON part everything from the former get method is already in place in user.js.
So just move what you need from performer.js to user.js and refactor it on the fly.
And the post parts also need refactoring! I guess no one really knows what happens in all that if for switch else if for each if else magic.
Stefan Isak
@stefanisak
Jan 12 2016 17:41
This is kind of cyclomatic complexity humans can't handle.
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 17:55
i tried to manual merge but i need your help
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 18:26
I can not find the queries
/lpm-team/events/lpm-2013-rome/
this also do not work as all the details
Gianluca Del Gobbo
@gianlucadelgobbo
Jan 12 2016 21:32
I think is easyer
you just miss a lot of page to refactor