These are chat archives for gianlucadelgobbo/avnode

20th
Jun 2016
Gianluca Del Gobbo
@gianlucadelgobbo
Jun 20 2016 08:08
Good Morning
To be able to login I have made working again the login on flyer.net
because the users on the new db is without passwords
as you can please check it
we have to save the password at the first login
Gianluca Del Gobbo
@gianlucadelgobbo
Jun 20 2016 08:17
app/server/authentication/strategies/local.js
ROW 36
Stefan Isak
@stefanisak
Jun 20 2016 08:43
Good morning, I’ll have a look. Next time please create a separate branch and create a pull request. Makes it way easier ;)
Gianluca Del Gobbo
@gianlucadelgobbo
Jun 20 2016 09:45
you mean not in design?
Stefan Isak
@stefanisak
Jun 20 2016 09:50
Yeah, exactly. You’ll be then able to create a pull request. That makes it easier for everybody to follow current progress and we can get things faster back to master and therefore get it faster online.
Gianluca Del Gobbo
@gianlucadelgobbo
Jun 20 2016 16:44
was better a branch only to fix authenticate?
how to have it into design then?
Stefan Isak
@stefanisak
Jun 20 2016 19:45
That’s right. Usually you create a new branch from the most latest development branch. In our case that’s design right now.
Switch to the design branch and make sure you’re up to date, e.g.:
git checkout design
git pull origin design
Then proceed creating the new branch, e.g.:
git checkout -b fix-authentication
Make all your changes/commits as usual and then push it to create the respective remote branch:
git push origin fix-authentication
Now you can create a pull request following Githubs UI.
Gianluca Del Gobbo
@gianlucadelgobbo
Jun 20 2016 22:09
ok, we try