by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    grapemix
    @grapemix
    It seems the trigger mechanism of spark-scroll-callback is broken. When I try the spark-trigger way, the trigger is not being used. When I try the spark-scroll way, it only fire the event based on the top of the page. I would expect the callback event will be fired after passing a spark-id, otherwise, the spark-scroll-callback feature will be useless. Would you mind take a look of the problem? Thanks.
    Gil Birman
    @gilbox
    I responded in the github issue, please take a look
    Aleš
    @fxck
    @gilbox I seriously like what you've done here
    if only it had little less dependencies, lodash, shifty, rekapi + the lib itself make it nearly 10 times the size of skroller, and had a little better documentation
    I can help with the latter eventually
    Aleš
    @fxck
    but have you considered making a version that doesn't depend on so many other libs?
    Gil Birman
    @gilbox
    @fxck I pretty much did already, but for react. I don't use angular anymore
    Gil Birman
    @gilbox
    ... it's broken out into projects react-track and react-imation ... iirc neither project has any dependencies other than react
    Aleš
    @fxck
    @gilbox no chance you'd backport it to angular now that you are not using it I suppose?
    Aleš
    @fxck
    _.isString and _.isFunction and _.clone could be all replaced with its angular counterparts, so there's no need for lodash in the spark scroll itself.. unfortunately it's still a dependency inside Rekapi..
    juegas
    @juegas
    is there any issues with angular1.47 one should know about?
    juegas
    @juegas
    ping
    Gil Birman
    @gilbox
    ¯\_(ツ)_/¯
    Brhernann
    @Brhernann
    HI