Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 19 04:02

    chinesedfan on master

    test: Add UserListItem componen… (compare)

  • Oct 19 04:02
    chinesedfan closed #897
  • Oct 18 15:17
    coveralls commented #897
  • Oct 18 15:13
    nersoh opened #897
  • Oct 18 13:21

    chinesedfan on master

    fix(locale): Update locale text… (compare)

  • Oct 18 13:21
    chinesedfan closed #896
  • Oct 18 07:11
    coveralls commented #896
  • Oct 18 07:07
    nersoh synchronize #896
  • Oct 17 16:46
    coveralls commented #896
  • Oct 17 16:45
    coveralls commented #896
  • Oct 17 16:42
    nersoh synchronize #896
  • Oct 17 16:42
    nersoh edited #896
  • Oct 17 16:41
    nersoh edited #896
  • Oct 17 16:41
    nersoh synchronize #896
  • Oct 17 14:21

    chinesedfan on master

    feat: add new Swedish translati… (compare)

  • Oct 17 14:21
    chinesedfan closed #895
  • Oct 17 14:20
    chinesedfan commented #895
  • Oct 17 11:03
    coveralls commented #896
  • Oct 17 11:01
    nersoh edited #896
  • Oct 17 10:59
    nersoh opened #896
Houssein Djirdeh
@housseindjirdeh
And yep! Any PR that looks doable, isn't being worked on is a good grab
any questions, don't hesitate to ask here mate
Xianming Zhong
@chinesedfan
hi, does someone have time to take a look on #848? If not, I may merge it in next week.
Because I am also working on repicking #258. See branch repick_258, which was checked out from #848 to avoid merge conflicts.
Xianming Zhong
@chinesedfan
by the way, was there a closed PR tried to show PR review comments? Or my memory is in chaos. :monkey_face:
Houssein Djirdeh
@housseindjirdeh
Yep I’ll have time in a few hours :)
Will take a look today
Hmm you mean a PR that explains how to make PR template + add comments?
Xianming Zhong
@chinesedfan
@housseindjirdeh Thanks. I mean a PR for #472.
Houssein Djirdeh
@housseindjirdeh
Approved @chinesedfan
thanks so much for that
And oooh
I don't think there ever was one for that issue
CC @andrewda in case you happened to start working on it?
Michael Johnsey
@mjohnsey
:wave: Hello all, wanted to pop in and ask if a bug around the notch for the Google Pixel 3 XL on (at least) the repo "about" screen. Didn't see any issues that hit the keywords I would know to look for and thought I'd ask here before opening a bug.
Xianming Zhong
@chinesedfan
@mjohnsey Go ahead. Similar PR for iPhoneX is #707.
Michael Johnsey
@mjohnsey
OK #854 open, thanks!
Houssein Djirdeh
@housseindjirdeh
Thanks for opening that Michael 🙏🏾
slyfy27
@slyfy27
error 'config.h' file not found,how can I fix this
Bryan Kok
@Transfusion
Hi, i just freshly cloned the master branch but i encountered a couple issues after building for android
Screenshot_1544359571.png
repositories don't appear to load completely
Xianming Zhong
@chinesedfan
@Transfusion I think it has been fixed in #856. But not merged yet.
Houssein Djirdeh
@housseindjirdeh
approved :white_check_mark:
Ulises Martinez Adon
@umartinez22
Hello guys, i am new here and i want to colaborate with this project.
Arjun
@Arjun-sna
Welcome @umartinez22 . Go through this doc to get started.
Houssein Djirdeh
@housseindjirdeh
Any questions you have as well @umartinez22, please don't hesitate to let us know!!
Ulises Martinez Adon
@umartinez22
Okay, Thanks.
Arjun
@Arjun-sna
hi. are there any docs on details about architecture of api module? kind of explaining use of proxies, client.js functionalities.
Xianming Zhong
@chinesedfan
@Arjun-sna You can check #750 and #770. And feel free to ask questions here.
Anand Mutyala
@andy14312
hello
is anybody there?
George Jose
@G2Jose
Anyone get this error when running tests? setup.js: babel-plugin-jest-hoist: The module factory ofjest.mock()is not allowed to reference any out-of-scope variables
Xianming Zhong
@chinesedfan
Did you install with yarn? The CI should be OK.
George Jose
@G2Jose
Yeah - used yarn to install deps
Xianming Zhong
@chinesedfan
I have no computer currently, but I can check later.
George Jose
@G2Jose
Lmk if you try it @chinesedfan. Also please check your node version. I’m on v12.1.0. Seems like this was an issue on 10 - facebook/react-native#19120, but should be fixed by now
Xianming Zhong
@chinesedfan
@G2Jose According to the issue you provided, it should be a jest problem in Node.js 10. Our CI uses Node.js 8, so nobody found it.
George Jose
@G2Jose
Hey guys - how do we feel about typescript? I know there was some very brief discussion on this much earlier on but haven’t been following this project too closely since.
I think it could add a lot of value by making it easier to get started & contribute to this project. Adding typescript support to a react native project is also much easier now than it used to be. I’ve created a PR for this - gitpoint/git-point#874. Would love to start a discussion around this. This is the most relevant commit - https://github.com/gitpoint/git-point/pull/874/commits/d6d4b56e6d1f98ad72fb23d44110eff48da4dfb5
Xianming Zhong
@chinesedfan
Thanks for much help from @housseindjirdeh and hope we can release iOS soon.
Nelson Henrique
@nersoh
Screenshot 2019-10-12 at 19.42.12.png
Has anyone faced that problem?
Ed Luff
@Rexogamer
When might iOS get updated?
Xianming Zhong
@chinesedfan
@nersoh Try to re-link. It saves me.
npx react-native unlink react-native-device-info
npx react-native link react-native-device-info
@Rexogamer It depends on when @housseindjirdeh will be back.
Ed Luff
@Rexogamer
@chinesedfan I see, he’s been a while
Nelson Henrique
@nersoh
@chinesedfan you definitely saved me. Thank you!!