Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 15 13:39
    brandly commented #879
  • Nov 11 06:42
    chinesedfan commented #879
  • Nov 11 06:13
    coveralls commented #902
  • Nov 11 06:09
    dependabot[bot] synchronize #902
  • Nov 11 06:09

    dependabot[bot] on npm_and_yarn

    chore(deps): bump lodash from 4… (compare)

  • Nov 11 06:09
    dependabot[bot] edited #902
  • Nov 11 06:09
    dependabot[bot] edited #902
  • Nov 11 06:09

    chinesedfan on master

    test: Add repository and organi… (compare)

  • Nov 11 06:09
    chinesedfan closed #912
  • Nov 11 06:07
    chinesedfan commented #879
  • Nov 11 04:12
    brandly commented #879
  • Nov 11 04:12
    brandly commented #879
  • Nov 11 00:03
    coveralls commented #912
  • Nov 11 00:00
    nersoh synchronize #912
  • Nov 09 09:32
    chinesedfan labeled #887
  • Nov 09 09:32
    chinesedfan labeled #885
  • Nov 09 09:31

    chinesedfan on master

    chore: use alias path (compare)

  • Nov 09 07:38
    chinesedfan labeled #871
  • Nov 09 07:38
    chinesedfan labeled #850
  • Nov 09 07:38
    chinesedfan labeled #873
Petru Alin Gheorghe
@palingheorghe
Hi guys I can't really build the app... Entry, ":CFBundleIdentifier", Does Not Exist this is the error i receive in the terminal
Do you have any idea what's going on?
Oleg Korol
@olegkorol
Hi everyone!
Houssein Djirdeh
@housseindjirdeh
Hi @palingheorghe, are you seeing this on a real device?
And is this on iOS or Android?
Could you double check the info.plist file and see if a key with 'localhost' is in the file if you're running on iOS?
Hi @olegkorol!!!
James Glover
@jglover

The issue @ioveracker and @RolfKoenders and @palingheorghe are experiencing is this
facebook/react-native#20774

The new build system in xcode 10 / Mac OS mojave will break when trying to compile when it hits third-party-scripts in the RN's node module

An upgrade of React native doesn't solve it, I'm testing using the legacy build system project setting in XCode vs the manually installing third party scripts workaround at the moment
James Glover
@jglover
Temporarily, I had some success using the Legacy build system with the following steps:
Go to XCode
File > Project Settings > Build system dropdown > Select "Use Legacy build system"
Then
Product > Clean, Product > Build, Product > Run (gets the bundle installed into the simulator)
Return to your terminal and yarn start:ios
Far from ideal, but Facebook have an issue open with RN and even the workaround is not particularly pretty
Oleg Korol
@olegkorol
Is there a quick guide on how to set up both android/ios environments in order to be able to run the app?
For someone who is quite new to mobile development (like me) this could be a real pain in the ass (really, not kidding). I though it would be quite straightforward but, to my surprise, not even close :D
Thanks in advance ;)
After spending half a day trying to make things run on Android, it is still not quite working :/
Here are roughly the steps I followed:
// installed required dependencies
brew cask install adoptopenjdk8
brew cask install homebrew/cask-versions/java8
brew cask install android-sdk
export ANDROID_SDK_ROOT="/usr/local/share/android-sdk"

// downloaded image, e.g.
sdkmanager "system-images;android-23;google_apis;x86"
// accepted SDK licenses
yes | sudo sdkmanager --licenses
// created virtual device, e.g.
avdmanager create avd -n pixel_xl -k "system-images;android-23;google_apis;x86"


export ANDROID_HOME="/usr/local/share/android-sdk"
// Setting the env var didn't help, so under the android directory, I created a file called “local.properties” and added the
// following line (substituting USER with the current user):
sdk.dir = /usr/local/share/android-sdk

// then start emulated device
alias emu="$ANDROID_HOME/tools/emulator"
emu -avd pixel_xl
// this wasn’t working so I decided to go to Android Studio, start the project using projects’ SDK, created new virtual device and then I was able to start the device from there… so the virtual device is running now

// then you should be able to run it, I though
yarn start:android

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':react-native-linear-gradient'.
> Could not resolve all artifacts for configuration ':react-native-linear-gradient:classpath'.
   > Could not resolve net.sf.proguard:proguard-gradle:5.3.2.
     Required by:
         project :react-native-linear-gradient > com.android.tools.build:gradle:2.3.3 > com.android.tools.build:gradle-core:2.3.3
[…]

// then I tried
react-native upgrade

// trying to run again... and new error...

* What went wrong:
Could not resolve all files for configuration ':react-native-code-push:_internal_aapt2_binary'.
> Could not find com.android.tools.build:aapt2:3.2.1-4818971.
  Required by:
      project :react-native-code-push

// giving up for today :D
Chandrasekar Gokulanathan
@Chandrasekar-G
@palingheorghe Try downgrading the react-native version in your local alone. Say, instead of "0.54.4" I used "0.52.0" and it worked like charm. Let us know if it works
Houssein Djirdeh
@housseindjirdeh
Wow, thanks for digging in @jglover, I had no idea there were issues around Mojave
Appreciate you finding out the root cause 🙏🏾
@olegkorol Ideally the instructions here should be everything needed
But life is never that simple :)
Are you using a Mac? And are you on High Sierra?
I have a newer machine that I need to boot up Android from scratch on, so what I'll do is list out all the steps and keep you posted
Those build issues look gnarly (react-native-linear-gradient, react-native-code-push??) so will see
Oleg Korol
@olegkorol

Hey, thanks for the feedback @housseindjirdeh .
You are right, life is never that simple :D

Yep, I am using a Mac, on High Sierra indeed (10.13.6).
Thanks, just let me know then. Appreciate it.

James Glover
@jglover
@Chandrasekar-that doesn't appear to resolve the issue on XCode 10/Mac OS Mojave
No problem @housseindjirdeh , hopefully they fix the issue or we can find a reliable workaround for now
Xianming Zhong
@chinesedfan
@housseindjirdeh hi, can you add git tag for 1.6.0? So we can track bugs more easily
Houssein Djirdeh
@housseindjirdeh
@chinesedfan will do
1.6.0 was released on iOS about 2 weeks ago (apologies for the delay on Android, but will do that in the coming days)
And ill update the Releases tab accordingly
But we can bucket issues/PRs for 1.7.0 if that's alright 👍🏾
Kirk D.
@kiorq
Hey. Where i can find tasks that need to be done? I will like to contribute and help with anything that I can.
Kirk D.
@kiorq
I’m guessing i can start with PR’s?
Houssein Djirdeh
@housseindjirdeh
@kiorq hey Kirk, thanks a million for helping :)
And yep! Any PR that looks doable, isn't being worked on is a good grab
any questions, don't hesitate to ask here mate
Xianming Zhong
@chinesedfan
hi, does someone have time to take a look on #848? If not, I may merge it in next week.
Because I am also working on repicking #258. See branch repick_258, which was checked out from #848 to avoid merge conflicts.
Xianming Zhong
@chinesedfan
by the way, was there a closed PR tried to show PR review comments? Or my memory is in chaos. :monkey_face:
Houssein Djirdeh
@housseindjirdeh
Yep I’ll have time in a few hours :)
Will take a look today
Hmm you mean a PR that explains how to make PR template + add comments?
Xianming Zhong
@chinesedfan
@housseindjirdeh Thanks. I mean a PR for #472.
Houssein Djirdeh
@housseindjirdeh
Approved @chinesedfan
thanks so much for that
And oooh
I don't think there ever was one for that issue
CC @andrewda in case you happened to start working on it?
Michael Johnsey
@mjohnsey
:wave: Hello all, wanted to pop in and ask if a bug around the notch for the Google Pixel 3 XL on (at least) the repo "about" screen. Didn't see any issues that hit the keywords I would know to look for and thought I'd ask here before opening a bug.
Xianming Zhong
@chinesedfan
@mjohnsey Go ahead. Similar PR for iPhoneX is #707.
Michael Johnsey
@mjohnsey
OK #854 open, thanks!