Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 15 13:39
    brandly commented #879
  • Nov 11 06:42
    chinesedfan commented #879
  • Nov 11 06:13
    coveralls commented #902
  • Nov 11 06:09
    dependabot[bot] synchronize #902
  • Nov 11 06:09

    dependabot[bot] on npm_and_yarn

    chore(deps): bump lodash from 4… (compare)

  • Nov 11 06:09
    dependabot[bot] edited #902
  • Nov 11 06:09
    dependabot[bot] edited #902
  • Nov 11 06:09

    chinesedfan on master

    test: Add repository and organi… (compare)

  • Nov 11 06:09
    chinesedfan closed #912
  • Nov 11 06:07
    chinesedfan commented #879
  • Nov 11 04:12
    brandly commented #879
  • Nov 11 04:12
    brandly commented #879
  • Nov 11 00:03
    coveralls commented #912
  • Nov 11 00:00
    nersoh synchronize #912
  • Nov 09 09:32
    chinesedfan labeled #887
  • Nov 09 09:32
    chinesedfan labeled #885
  • Nov 09 09:31

    chinesedfan on master

    chore: use alias path (compare)

  • Nov 09 07:38
    chinesedfan labeled #871
  • Nov 09 07:38
    chinesedfan labeled #850
  • Nov 09 07:38
    chinesedfan labeled #873
Houssein Djirdeh
@housseindjirdeh
Those build issues look gnarly (react-native-linear-gradient, react-native-code-push??) so will see
Oleg Korol
@olegkorol

Hey, thanks for the feedback @housseindjirdeh .
You are right, life is never that simple :D

Yep, I am using a Mac, on High Sierra indeed (10.13.6).
Thanks, just let me know then. Appreciate it.

James Glover
@jglover
@Chandrasekar-that doesn't appear to resolve the issue on XCode 10/Mac OS Mojave
No problem @housseindjirdeh , hopefully they fix the issue or we can find a reliable workaround for now
Xianming Zhong
@chinesedfan
@housseindjirdeh hi, can you add git tag for 1.6.0? So we can track bugs more easily
Houssein Djirdeh
@housseindjirdeh
@chinesedfan will do
1.6.0 was released on iOS about 2 weeks ago (apologies for the delay on Android, but will do that in the coming days)
And ill update the Releases tab accordingly
But we can bucket issues/PRs for 1.7.0 if that's alright 👍🏾
Kirk D.
@kiorq
Hey. Where i can find tasks that need to be done? I will like to contribute and help with anything that I can.
Kirk D.
@kiorq
I’m guessing i can start with PR’s?
Houssein Djirdeh
@housseindjirdeh
@kiorq hey Kirk, thanks a million for helping :)
And yep! Any PR that looks doable, isn't being worked on is a good grab
any questions, don't hesitate to ask here mate
Xianming Zhong
@chinesedfan
hi, does someone have time to take a look on #848? If not, I may merge it in next week.
Because I am also working on repicking #258. See branch repick_258, which was checked out from #848 to avoid merge conflicts.
Xianming Zhong
@chinesedfan
by the way, was there a closed PR tried to show PR review comments? Or my memory is in chaos. :monkey_face:
Houssein Djirdeh
@housseindjirdeh
Yep I’ll have time in a few hours :)
Will take a look today
Hmm you mean a PR that explains how to make PR template + add comments?
Xianming Zhong
@chinesedfan
@housseindjirdeh Thanks. I mean a PR for #472.
Houssein Djirdeh
@housseindjirdeh
Approved @chinesedfan
thanks so much for that
And oooh
I don't think there ever was one for that issue
CC @andrewda in case you happened to start working on it?
Michael Johnsey
@mjohnsey
:wave: Hello all, wanted to pop in and ask if a bug around the notch for the Google Pixel 3 XL on (at least) the repo "about" screen. Didn't see any issues that hit the keywords I would know to look for and thought I'd ask here before opening a bug.
Xianming Zhong
@chinesedfan
@mjohnsey Go ahead. Similar PR for iPhoneX is #707.
Michael Johnsey
@mjohnsey
OK #854 open, thanks!
Houssein Djirdeh
@housseindjirdeh
Thanks for opening that Michael 🙏🏾
slyfy27
@slyfy27
error 'config.h' file not found,how can I fix this
Bryan Kok
@Transfusion
Hi, i just freshly cloned the master branch but i encountered a couple issues after building for android
Screenshot_1544359571.png
repositories don't appear to load completely
Xianming Zhong
@chinesedfan
@Transfusion I think it has been fixed in #856. But not merged yet.
Houssein Djirdeh
@housseindjirdeh
approved :white_check_mark:
Ulises Martinez Adon
@umartinez22
Hello guys, i am new here and i want to colaborate with this project.
Arjun
@Arjun-sna
Welcome @umartinez22 . Go through this doc to get started.
Houssein Djirdeh
@housseindjirdeh
Any questions you have as well @umartinez22, please don't hesitate to let us know!!
Ulises Martinez Adon
@umartinez22
Okay, Thanks.
Arjun
@Arjun-sna
hi. are there any docs on details about architecture of api module? kind of explaining use of proxies, client.js functionalities.
Xianming Zhong
@chinesedfan
@Arjun-sna You can check #750 and #770. And feel free to ask questions here.
Anand Mutyala
@andy14312
hello
is anybody there?
George Jose
@G2Jose
Anyone get this error when running tests? setup.js: babel-plugin-jest-hoist: The module factory ofjest.mock()is not allowed to reference any out-of-scope variables
Xianming Zhong
@chinesedfan
Did you install with yarn? The CI should be OK.
George Jose
@G2Jose
Yeah - used yarn to install deps
Xianming Zhong
@chinesedfan
I have no computer currently, but I can check later.
George Jose
@G2Jose
Lmk if you try it @chinesedfan. Also please check your node version. I’m on v12.1.0. Seems like this was an issue on 10 - facebook/react-native#19120, but should be fixed by now
Xianming Zhong
@chinesedfan
@G2Jose According to the issue you provided, it should be a jest problem in Node.js 10. Our CI uses Node.js 8, so nobody found it.