Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
xogium
@xogium
well I'm not sure
but at least what I did here was to upgrade pgsql, then built the latest commit from git master
and it chokes to death related to web hooks
if I go back to my backed up .jar everything works
Naoki Takezoe
@takezoe
I see. The report from @ilgrosso is also suggesting the possibility of the migration issue. I will take a closer look, anyway.
xogium
@xogium
sure. Just thought I'd mention this
Naoki Takezoe
@takezoe
Yeah, thank you for reporting!
xogium
@xogium
I could try to do some bisecting if you want help with this
Naoki Takezoe
@takezoe
Ah... This line in the database migration in the latest release causes duplication in WEB_HOOK.HOOK_ID if there are records in the table.
https://github.com/gitbucket/gitbucket/blob/66be84289dff6bb090648a74ea10d7662b8b9af3/src/main/resources/update/gitbucket-core_4.35.xml#L6-L8
This works if WEB_HOOK table is empty, but if there are registered webhooks database migration will fail.
cc: @onukura
Naoki Takezoe
@takezoe
In this case, we need to add nullable column first, then fill the column with unique values somehow. Or create a new table with an auto-incremented unique-id column and copy records from the existing table.
Since we already published 4.35.0, we cannot update 4.35.0 released artifacts. We should release 4.35.1 (or 4.36.0) with a fix for this issue.
Naoki Takezoe
@takezoe
I'm working on fixing the issue in gitbucket/gitbucket#2610.
xogium
@xogium
nice, thank you for working on this
onukura
@onukura
@takezoe thanks for working on this issue. And I’m sorry for this bug... i didnt notice because i tested on only empty table. And maybe it might be better if gitbukcet migration test consider non empty table migration.
Naoki Takezoe
@takezoe
Right, but I know covering existing records cases would be annoying. I wonder if we could find an automated solution for that.
Naoki Takezoe
@takezoe
Or simply checking the existence of adding non-null columns without default value in migration scripts might work.
Naoki Takezoe
@takezoe
@ilgrosso @xogium gitbucket/gitbucket#2610 fixes the migration issue. Could you try this branch if possible?
xogium
@xogium
sure !
so I should apply this on top of master ?
Naoki Takezoe
@takezoe
@xogium The current master changes since 4.35.0 isn't required to test the migration fix. You can just use fix_webhook_migration branch.
xogium
@xogium
oh
okay
Naoki Takezoe
@takezoe
Sorry, I'm pushing another change to the branch. Wait for a while.
xogium
@xogium
sure, no problem
I absolutely love gitbucket btw
:D
Naoki Takezoe
@takezoe
Thanks :-)
Waiting for CI...
xogium
@xogium
always runs without a problem and does exactly what I need
and its so easy to migrate I'm like, wow
Naoki Takezoe
@takezoe
Actually, database migration sometimes causes trouble.
xogium
@xogium
and most important to me, you folks care about accessibility. It's not a priority, but it's a ton better than not caring about
yeah ;) sometimes. But when there's problem, they are fixed really fast
I'm still searching for a simple and easy ticket system for my project, like support tickets
thought I found one but turns out no, because I sent them a message to signal accessbility issues and even with gentle pings over the months, they didn't reply at all since july
xogium
@xogium
so I should be good to try out the branch now ?
Naoki Takezoe
@takezoe
Which one? Isn't GitBucket's issue enough? :-P
Oh yes. CI passed. You can try the branch.
xogium
@xogium
hehehe I wish ! But no, not that kind of issues… More like a ticket system for customers and agents
I really don't need a complicated solution, just simple things like people sending messages to a support email, and then one of us in the project can answer things
we don't need all those fancy video and audio conferencing and helpdesk management
xogium
@xogium
okay so building here, lets see
I like to keep on top of things, if not in prod, for my personnal gitbucket instance, so that's how I found out the problem
:D
xogium
@xogium
good news :) it works
Naoki Takezoe
@takezoe
Great. Thank you gor trying!
xogium
@xogium
no problem at all :) I like helping in any way I can, and that includes raising issues and help test a fix or some bisecting sometimes ;)
Naoki Takezoe
@takezoe
Due to the our limited development resources, feedback from users is really important to improve product and fix problems efficiently.